From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754379AbcAHK5y (ORCPT ); Fri, 8 Jan 2016 05:57:54 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:42898 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752795AbcAHK5w (ORCPT ); Fri, 8 Jan 2016 05:57:52 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Andy Shevchenko Cc: Andy Shevchenko , Julian Margetson , Tejun Heo , linux-ide@vger.kernel.org, "linux-kernel\@vger.kernel.org" Subject: Re: [PATCH 1/3] ata: sata_dwc_460ex: use "dmas" DT property to find dma channel References: <1450221935-6034-1-git-send-email-mans@mansr.com> <5675BB2F.6060107@candw.ms> <5675C452.2080206@candw.ms> <5676E906.1060603@candw.ms> <1450724880.30729.250.camel@linux.intel.com> <1450731289.30729.282.camel@linux.intel.com> <1450781890.30729.298.camel@linux.intel.com> <1452159294.30729.405.camel@linux.intel.com> <1452243464.30729.430.camel@linux.intel.com> Date: Fri, 08 Jan 2016 10:57:44 +0000 In-Reply-To: <1452243464.30729.430.camel@linux.intel.com> (Andy Shevchenko's message of "Fri, 08 Jan 2016 10:57:44 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andy Shevchenko writes: > On Thu, 2016-01-07 at 18:32 +0000, Måns Rullgård wrote: > >> Andy Shevchenko writes: >> >> > On Wed, 2016-01-06 at 19:36 +0200, Andy Shevchenko wrote: >> > >  >> > So, Måns, Julian, I just have published my repository containing >> > Måns' and my patches regarding dw_dmac and sata_dwc_460ex drivers >> > here >> > >> > https://bitbucket.org/andy-shev/linux/branch/topic%2Fdw%2Fnext >> >> I've picked out the relevant changes from your branch and made some >> additional improvements.  A few notes: >> >> - The __be32/__le32 typedefs for the DMA descriptor fields are necessary >>   to avoid a million sparse warnings (and sparse is correct to warn). > > Hmm… Which version of sparse are you using? I always run builds with > sparse enabled and didn't see anything. You need to enable endian checking with CF=-D__CHECK_ENDIAN__ >> - Using #ifdef CONFIG_AVR32 is a step back, IMO, since this driver may >>   well be used on another big endian system some day.  The Kconfig logic >>   for selecting this option could perhaps be improved though. > > Maybe runtime chosen accessors will be better than ifdefs? Are there any systems that could otherwise run the same kernel that use this hardware with different byte order? I doubt it. > I don't like the Kconfig option which limits application of the > (compiled) driver. It's no more limited than a hard #ifdef AVR32 in the driver code. -- Måns Rullgård