From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934963AbbLQP6D (ORCPT ); Thu, 17 Dec 2015 10:58:03 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:45997 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S934785AbbLQP6A convert rfc822-to-8bit (ORCPT ); Thu, 17 Dec 2015 10:58:00 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Andy Shevchenko Cc: Tejun Heo , linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] ata: sata_dwc_460ex: get rid of global data References: <1450221935-6034-1-git-send-email-mans@mansr.com> <1450221935-6034-3-git-send-email-mans@mansr.com> <1450364765.30729.139.camel@linux.intel.com> <1450366673.30729.144.camel@linux.intel.com> Date: Thu, 17 Dec 2015 15:57:57 +0000 In-Reply-To: <1450366673.30729.144.camel@linux.intel.com> (Andy Shevchenko's message of "Thu, 17 Dec 2015 17:37:53 +0200") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Andy Shevchenko writes: > On Thu, 2015-12-17 at 15:19 +0000, Måns Rullgård wrote: >> Andy Shevchenko writes: >> >> > On Tue, 2015-12-15 at 23:25 +0000, Mans Rullgard wrote: >> > > This moves all global data into the driver private struct, thus >> > > permitting multiple devices of this type to be used. >> > > >> > >> > Nice! >> > >> > Btw, last time Linus complained about new warnings. Most of them I >> > have >> > fixed when moved to external DMA driver. Leftovers IIRC are related >> > to >> > address space. Are you going to fix them? Otherwise it might be a >> > headache for him again with strong wording to our address I >> > suppose. >> >> There are some issues with __iomem annotations.  Is that the warnings >> you refer to?  I'm not getting any regular compiler warnings. >> > > I guess I got them because I'am checking sparse warnings as well. > > There is the original Linus' complain. > http://permalink.gmane.org/gmane.linux.ide/59391 He's right, those casts are ugly and possibly wrong. I was thinking of cleaning it up, but first I wanted to get it working at all with my hardware. -- Måns Rullgård