From: "Måns Rullgård" <mans@mansr.com>
To: David Miller <davem@davemloft.net>
Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org
Subject: Re: [PATCH v6] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller
Date: Mon, 16 Nov 2015 20:59:18 +0000 [thread overview]
Message-ID: <yw1xsi45irtl.fsf@unicorn.mansr.com> (raw)
In-Reply-To: <20151116.155327.1432148371996261050.davem@davemloft.net> (David Miller's message of "Mon, 16 Nov 2015 15:53:27 -0500 (EST)")
David Miller <davem@davemloft.net> writes:
> From: Mans Rullgard <mans@mansr.com>
> Date: Mon, 16 Nov 2015 18:23:35 +0000
>
>> +static int nb8800_alloc_rx(struct net_device *dev, int i, bool napi)
>
> "i" is passed in as a signed int here, but:
>
>> +static void nb8800_receive(struct net_device *dev, unsigned i, unsigned len)
> ...
>> + err = nb8800_alloc_rx(dev, i, true);
>
> It comes from an 'unsigned' value.
>
> Please pick one type and use it consistently.
Darn, missed one.
> Also, always fully spell out "unsigned int" rather than use "unsigned"
> as a shorthand.
OK
Anything else?
--
Måns Rullgård
mans@mansr.com
next prev parent reply other threads:[~2015-11-16 20:59 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-11-16 18:23 Mans Rullgard
2015-11-16 20:53 ` David Miller
2015-11-16 20:59 ` Måns Rullgård [this message]
2015-11-16 21:18 ` David Miller
2015-11-16 21:21 ` Måns Rullgård
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=yw1xsi45irtl.fsf@unicorn.mansr.com \
--to=mans@mansr.com \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®