From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753833AbcBHOul (ORCPT ); Mon, 8 Feb 2016 09:50:41 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:58061 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751637AbcBHOuj convert rfc822-to-8bit (ORCPT ); Mon, 8 Feb 2016 09:50:39 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: Sebastian Frias Cc: "David S. Miller" , netdev@vger.kernel.org, LKML , mason Subject: Re: [PATCH v3] net: ethernet: support "fixed-link" DT node on nb8800 driver References: <56B4A445.7080402@laposte.net> <56B4A877.4020800@laposte.net> <56B4ACC4.1000607@laposte.net> <56B4B013.5030407@laposte.net> <56B4B81D.3000108@laposte.net> <56B4BDDA.9010708@laposte.net> <56B86F44.3030806@laposte.net> <56B8A6F5.9060409@laposte.net> Date: Mon, 08 Feb 2016 14:50:38 +0000 In-Reply-To: <56B8A6F5.9060409@laposte.net> (Sebastian Frias's message of "Mon, 08 Feb 2016 15:32:21 +0100") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Sebastian Frias writes: >>> By the way, I know some people like the command line, email, etc. but >>> there ought to be other tools better suited for patch review... >> >> Some kernel subsystems use http://patchwork.ozlabs.org/ to track status >> of various patches. >> > > Thanks, I see that netdev is part of it, and that the patches are there: > > https://patchwork.ozlabs.org/patch/580217/ > > seems like a slight layer over plain email and mailinglists; I was > thinking of something more in the line of > https://www.gerritcodereview.com/ > I believe Google uses Gerrit for Android. > I think Gerrit would probably be too big (and being written in Java, > using Prolog and other DSLs, implementing its own Git server in Java, > etc, may make some -or lots?- of kernel developers cry :-) ) > However, in Gerrit it is easier to know where in the "review" process > we are, because people have to explicitly give a score "+/- X" when > commenting on a patch. > Also, the diff can operate between different versions of the patches > themselves to see if the inlined comments were addressed. Gerrit has some merits, but for seasoned developers it's largely a nuisance. It's probably good at keeping junior/undisciplined developers from doing too much damage by strictly enforcing a cumbersome process. -- Måns Rullgård