From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751825AbbKJUxa (ORCPT ); Tue, 10 Nov 2015 15:53:30 -0500 Received: from unicorn.mansr.com ([81.2.72.234]:43152 "EHLO unicorn.mansr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751607AbbKJUx2 convert rfc822-to-8bit (ORCPT ); Tue, 10 Nov 2015 15:53:28 -0500 From: =?iso-8859-1?Q?M=E5ns_Rullg=E5rd?= To: David Miller Cc: eric.dumazet@gmail.com, linux-kernel@vger.kernel.org, netdev@vger.kernel.org, slash.tmp@free.fr Subject: Re: [PATCH v5] net: ethernet: add driver for Aurora VLSI NB8800 Ethernet controller References: <1447172063-27234-1-git-send-email-mans@mansr.com> <1447178145.17135.75.camel@edumazet-glaptop2.roam.corp.google.com> <20151110.150403.1195107307226924000.davem@davemloft.net> Date: Tue, 10 Nov 2015 20:53:19 +0000 In-Reply-To: <20151110.150403.1195107307226924000.davem@davemloft.net> (David Miller's message of "Tue, 10 Nov 2015 15:04:03 -0500 (EST)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org David Miller writes: > From: Måns Rullgård > Date: Tue, 10 Nov 2015 18:05:15 +0000 > >> Because I haven't been following the netdev list closely for the last >> five years, and no documentation I read mentioned this function. I can >> certainly change it. > > It is always advisable to mimick what other drivers do and use them as > a reference, rather than depend upon documentation which by definition > is always going to be out of sync with the source tree. Sure. The trick is to pick the right driver(s) to use as reference. Quite a few of them don't use that function. -- Måns Rullgård mans@mansr.com