From: Tachino Nobuhiro <tachino@open.nm.fujitsu.co.jp>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: rudo@internet.sk (Rudo Thomas), linux-kernel@vger.kernel.org
Subject: Re: kernel oops when burning CDs
Date: Tue, 05 Jun 2001 10:33:36 +0900 [thread overview]
Message-ID: <zobn90cv.wl@frostrubin.open.nm.fujitsu.co.jp> (raw)
In-Reply-To: <E15728I-00060D-00@the-village.bc.nu>
In-Reply-To: <200106042037.f54KbgU08004@smtp.kolej.mff.cuni.cz> <E15728I-00060D-00@the-village.bc.nu>
Hello,
At Mon, 4 Jun 2001 22:43:30 +0100 (BST),
Alan Cox wrote:
>
> > I get an ooops and immediate kernel panic when I break (CTRL-C) cdrecord. I
> > can reproduce it anytime. I use 2.4.5-ac series. Obviously, Linus' 2.4.5 is
> > fine.
> > I know, I know. I was supposed to make a serios oops report, BUT I wasn't
>
> Write down the EIP and the call trace then look them up in System.map. Also
> include the hardware details. The -ac tree has a newer version of the scsi
> generic code. It fixes some oopses but in your case it apparently added a new
> failure case
Oops occures in SG driver. This patch fixes the problem.
diff -r -u linux.org/drivers/scsi/sg.c linux/drivers/scsi/sg.c
--- linux.org/drivers/scsi/sg.c Fri Jun 1 10:10:22 2001
+++ linux/drivers/scsi/sg.c Fri Jun 1 17:08:00 2001
@@ -1114,7 +1114,8 @@
sg_remove_sfp(sdp, sfp);
sfp = NULL;
}
- __MOD_DEC_USE_COUNT(sg_template.module);
+ if (sg_template.module)
+ __MOD_DEC_USE_COUNT(sg_template.module);
if (sdp->device->host->hostt->module)
__MOD_DEC_USE_COUNT(sdp->device->host->hostt->module);
}
@@ -1311,7 +1312,8 @@
sg_finish_rem_req(srp);
}
if (sfp->closed) {
- __MOD_DEC_USE_COUNT(sg_template.module);
+ if (sg_template.module)
+ __MOD_DEC_USE_COUNT(sg_template.module);
if (sdp->device->host->hostt->module)
__MOD_DEC_USE_COUNT(sdp->device->host->hostt->module);
__sg_remove_sfp(sdp, sfp);
@@ -2207,7 +2209,8 @@
else {
sfp->closed = 1; /* flag dirty state on this fd */
/* MOD_INC's to inhibit unloading sg and associated adapter driver */
- __MOD_INC_USE_COUNT(sg_template.module);
+ if (sg_template.module)
+ __MOD_INC_USE_COUNT(sg_template.module);
if (sdp->device->host->hostt->module)
__MOD_INC_USE_COUNT(sdp->device->host->hostt->module);
SCSI_LOG_TIMEOUT(1, printk(
next prev parent reply other threads:[~2001-06-05 1:34 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2001-06-04 20:46 Rudo Thomas
2001-06-04 21:43 ` Alan Cox
2001-06-05 1:33 ` Tachino Nobuhiro [this message]
2001-06-05 4:19 ` Rudo Thomas
2001-06-07 2:11 Douglas Gilbert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=zobn90cv.wl@frostrubin.open.nm.fujitsu.co.jp \
--to=tachino@open.nm.fujitsu.co.jp \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=rudo@internet.sk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®