mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
* [PATCH 0/7] dts: amlogic: enable UART RX and TX pull up by default
@ 2025-03-29 18:58 Martin Blumenstingl
  2025-03-29 18:58 ` [PATCH 1/7] ARM: dts: amlogic: meson8: " Martin Blumenstingl
                   ` (8 more replies)
  0 siblings, 9 replies; 10+ messages in thread
From: Martin Blumenstingl @ 2025-03-29 18:58 UTC (permalink / raw)
  To: linux-amlogic
  Cc: devicetree, neil.armstrong, Martin Blumenstingl, khilman,
	linux-kernel, linux-arm-kernel, jbrunet

On the LibreELEC forum there have been reports that Odroid-C2 does not
boot when UART is left disconnected [0]. It turns out that this can be
solved by enabling the SoCs pull-up resistor on the UART RX and TX
pads [1].
It's not clear whether that specific Odroid-C2 board has a broken
resistor, the resistor is not populated (either by accident or on
purpose) or if there's another reason.

Testing on an SM1 X96-Air shows that pull-ups being enabled on UART
RX and TX is actually the default (either set in vendor u-boot or an
actual hardware default).

This series enables the UART RX and TX pull up resistors in the
default pin configuration on all supported SoCs.

Testing has been done on:
- GXBB Odroid-C1 on u-boot by a user in the LibreELEC forums [2]
- Meson8b Odroid-C1 on Linux (with vendor u-boot)
- SM1 X96-Air on Linux (with vendor u-boot)

Please include this early so the various CI systems can test these
patches.


[0] https://forum.libreelec.tv/thread/28586-odroid-c2-gxbb-s905-and-le-11-06-or-12-does-not-boot/?postID=195481#post195481
[1] https://forum.libreelec.tv/thread/28586-odroid-c2-gxbb-s905-and-le-11-06-or-12-does-not-boot/?postID=195667#post195667
[2] https://forum.libreelec.tv/thread/28586-odroid-c2-gxbb-s905-and-le-11-06-or-12-does-not-boot/?postID=195674#post195674


Martin Blumenstingl (7):
  ARM: dts: amlogic: meson8: enable UART RX and TX pull up by default
  ARM: dts: amlogic: meson8b: enable UART RX and TX pull up by default
  arm64: dts: amlogic: gxbb: enable UART RX and TX pull up by default
  arm64: dts: amlogic: gxl: enable UART RX and TX pull up by default
  arm64: dts: amlogic: g12: enable UART RX and TX pull up by default
  arm64: dts: amlogic: axg: enable UART RX and TX pull up by default
  arm64: dts: amlogic: a1: enable UART RX and TX pull up by default

 arch/arm/boot/dts/amlogic/meson8.dtsi             |  4 ++--
 arch/arm/boot/dts/amlogic/meson8b.dtsi            |  4 ++--
 arch/arm64/boot/dts/amlogic/meson-a1.dtsi         |  1 +
 arch/arm64/boot/dts/amlogic/meson-axg.dtsi        | 12 ++++++------
 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 10 +++++-----
 arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi       | 10 +++++-----
 arch/arm64/boot/dts/amlogic/meson-gxl.dtsi        | 12 ++++++------
 7 files changed, 27 insertions(+), 26 deletions(-)

-- 
2.49.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 1/7] ARM: dts: amlogic: meson8: enable UART RX and TX pull up by default
  2025-03-29 18:58 [PATCH 0/7] dts: amlogic: enable UART RX and TX pull up by default Martin Blumenstingl
@ 2025-03-29 18:58 ` Martin Blumenstingl
  2025-03-29 18:58 ` [PATCH 2/7] ARM: dts: amlogic: meson8b: " Martin Blumenstingl
                   ` (7 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Martin Blumenstingl @ 2025-03-29 18:58 UTC (permalink / raw)
  To: linux-amlogic
  Cc: devicetree, neil.armstrong, Martin Blumenstingl, khilman,
	linux-kernel, linux-arm-kernel, jbrunet

Some boards have noise on the UART RX line when the UART pins are not
connected to another device (such as an USB UART adapter). This can
be addressed by using a pull up resistor. Not all boards may provide
such a pull up resistor on the PCB so enable the SoC's pull-up on the
UART RX and TX pads by default. This matches the default (from u-boot
or SoC hardware) state for the pinmux configuration on these pads.

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
 arch/arm/boot/dts/amlogic/meson8.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/amlogic/meson8.dtsi b/arch/arm/boot/dts/amlogic/meson8.dtsi
index 847f7b1f1e96..7fe0c7d3ee6e 100644
--- a/arch/arm/boot/dts/amlogic/meson8.dtsi
+++ b/arch/arm/boot/dts/amlogic/meson8.dtsi
@@ -398,7 +398,7 @@ uart_ao_a_pins: uart_ao_a {
 			mux {
 				groups = "uart_tx_ao_a", "uart_rx_ao_a";
 				function = "uart_ao";
-				bias-disable;
+				bias-pull-up;
 			};
 		};
 
@@ -567,7 +567,7 @@ mux {
 				groups = "uart_tx_a1",
 				       "uart_rx_a1";
 				function = "uart_a";
-				bias-disable;
+				bias-pull-up;
 			};
 		};
 
-- 
2.49.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 2/7] ARM: dts: amlogic: meson8b: enable UART RX and TX pull up by default
  2025-03-29 18:58 [PATCH 0/7] dts: amlogic: enable UART RX and TX pull up by default Martin Blumenstingl
  2025-03-29 18:58 ` [PATCH 1/7] ARM: dts: amlogic: meson8: " Martin Blumenstingl
@ 2025-03-29 18:58 ` Martin Blumenstingl
  2025-03-29 18:58 ` [PATCH 3/7] arm64: dts: amlogic: gxbb: " Martin Blumenstingl
                   ` (6 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Martin Blumenstingl @ 2025-03-29 18:58 UTC (permalink / raw)
  To: linux-amlogic
  Cc: devicetree, neil.armstrong, Martin Blumenstingl, khilman,
	linux-kernel, linux-arm-kernel, jbrunet

Some boards have noise on the UART RX line when the UART pins are not
connected to another device (such as an USB UART adapter). This can
be addressed by using a pull up resistor. Not all boards may provide
such a pull up resistor on the PCB so enable the SoC's pull-up on the
UART RX and TX pads by default. This matches the default (from u-boot
or SoC hardware) state for the pinmux configuration on these pads.

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
 arch/arm/boot/dts/amlogic/meson8b.dtsi | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/arch/arm/boot/dts/amlogic/meson8b.dtsi b/arch/arm/boot/dts/amlogic/meson8b.dtsi
index 0876611ce26a..faf09f77c605 100644
--- a/arch/arm/boot/dts/amlogic/meson8b.dtsi
+++ b/arch/arm/boot/dts/amlogic/meson8b.dtsi
@@ -368,7 +368,7 @@ uart_ao_a_pins: uart_ao_a {
 			mux {
 				groups = "uart_tx_ao_a", "uart_rx_ao_a";
 				function = "uart_ao";
-				bias-disable;
+				bias-pull-up;
 			};
 		};
 
@@ -521,7 +521,7 @@ mux {
 				groups = "uart_tx_b0",
 				       "uart_rx_b0";
 				function = "uart_b";
-				bias-disable;
+				bias-pull-up;
 			};
 		};
 
-- 
2.49.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 3/7] arm64: dts: amlogic: gxbb: enable UART RX and TX pull up by default
  2025-03-29 18:58 [PATCH 0/7] dts: amlogic: enable UART RX and TX pull up by default Martin Blumenstingl
  2025-03-29 18:58 ` [PATCH 1/7] ARM: dts: amlogic: meson8: " Martin Blumenstingl
  2025-03-29 18:58 ` [PATCH 2/7] ARM: dts: amlogic: meson8b: " Martin Blumenstingl
@ 2025-03-29 18:58 ` Martin Blumenstingl
  2025-03-29 18:58 ` [PATCH 4/7] arm64: dts: amlogic: gxl: " Martin Blumenstingl
                   ` (5 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Martin Blumenstingl @ 2025-03-29 18:58 UTC (permalink / raw)
  To: linux-amlogic
  Cc: devicetree, neil.armstrong, Martin Blumenstingl, khilman,
	linux-kernel, linux-arm-kernel, jbrunet

Some boards have noise on the UART RX line when the UART pins are not
connected to another device (such as an USB UART adapter). This can
be addressed by using a pull up resistor. Not all boards may provide
such a pull up resistor on the PCB so enable the SoC's pull-up on the
UART RX and TX pads by default. This matches the default (from u-boot
or SoC hardware) state for the pinmux configuration on these pads.

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
 arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
index 8ebce7114a60..c4a9f855e5de 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi
@@ -105,7 +105,7 @@ uart_ao_a_pins: uart_ao_a {
 			mux {
 				groups = "uart_tx_ao_a", "uart_rx_ao_a";
 				function = "uart_ao";
-				bias-disable;
+				bias-pull-up;
 			};
 		};
 
@@ -122,7 +122,7 @@ uart_ao_b_pins: uart_ao_b {
 			mux {
 				groups = "uart_tx_ao_b", "uart_rx_ao_b";
 				function = "uart_ao_b";
-				bias-disable;
+				bias-pull-up;
 			};
 		};
 
@@ -520,7 +520,7 @@ mux {
 				groups = "uart_tx_a",
 				       "uart_rx_a";
 				function = "uart_a";
-				bias-disable;
+				bias-pull-up;
 			};
 		};
 
@@ -538,7 +538,7 @@ mux {
 				groups = "uart_tx_b",
 				       "uart_rx_b";
 				function = "uart_b";
-				bias-disable;
+				bias-pull-up;
 			};
 		};
 
@@ -556,7 +556,7 @@ mux {
 				groups = "uart_tx_c",
 				       "uart_rx_c";
 				function = "uart_c";
-				bias-disable;
+				bias-pull-up;
 			};
 		};
 
-- 
2.49.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 4/7] arm64: dts: amlogic: gxl: enable UART RX and TX pull up by default
  2025-03-29 18:58 [PATCH 0/7] dts: amlogic: enable UART RX and TX pull up by default Martin Blumenstingl
                   ` (2 preceding siblings ...)
  2025-03-29 18:58 ` [PATCH 3/7] arm64: dts: amlogic: gxbb: " Martin Blumenstingl
@ 2025-03-29 18:58 ` Martin Blumenstingl
  2025-03-29 18:58 ` [PATCH 5/7] arm64: dts: amlogic: g12: " Martin Blumenstingl
                   ` (4 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Martin Blumenstingl @ 2025-03-29 18:58 UTC (permalink / raw)
  To: linux-amlogic
  Cc: devicetree, neil.armstrong, Martin Blumenstingl, khilman,
	linux-kernel, linux-arm-kernel, jbrunet

Some boards have noise on the UART RX line when the UART pins are not
connected to another device (such as an USB UART adapter). This can
be addressed by using a pull up resistor. Not all boards may provide
such a pull up resistor on the PCB so enable the SoC's pull-up on the
UART RX and TX pads by default. This matches the default (from u-boot
or SoC hardware) state for the pinmux configuration on these pads.

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
 arch/arm64/boot/dts/amlogic/meson-gxl.dtsi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
index 2dc2fdaecf9f..460c46cfad6a 100644
--- a/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl.dtsi
@@ -163,7 +163,7 @@ uart_ao_a_pins: uart_ao_a {
 			mux {
 				groups = "uart_tx_ao_a", "uart_rx_ao_a";
 				function = "uart_ao";
-				bias-disable;
+				bias-pull-up;
 			};
 		};
 
@@ -180,7 +180,7 @@ uart_ao_b_pins: uart_ao_b {
 			mux {
 				groups = "uart_tx_ao_b", "uart_rx_ao_b";
 				function = "uart_ao_b";
-				bias-disable;
+				bias-pull-up;
 			};
 		};
 
@@ -188,7 +188,7 @@ uart_ao_b_0_1_pins: uart_ao_b_0_1 {
 			mux {
 				groups = "uart_tx_ao_b_0", "uart_rx_ao_b_1";
 				function = "uart_ao_b";
-				bias-disable;
+				bias-pull-up;
 			};
 		};
 
@@ -522,7 +522,7 @@ mux {
 				groups = "uart_tx_a",
 				       "uart_rx_a";
 				function = "uart_a";
-				bias-disable;
+				bias-pull-up;
 			};
 		};
 
@@ -540,7 +540,7 @@ mux {
 				groups = "uart_tx_b",
 				       "uart_rx_b";
 				function = "uart_b";
-				bias-disable;
+				bias-pull-up;
 			};
 		};
 
@@ -558,7 +558,7 @@ mux {
 				groups = "uart_tx_c",
 				       "uart_rx_c";
 				function = "uart_c";
-				bias-disable;
+				bias-pull-up;
 			};
 		};
 
-- 
2.49.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 5/7] arm64: dts: amlogic: g12: enable UART RX and TX pull up by default
  2025-03-29 18:58 [PATCH 0/7] dts: amlogic: enable UART RX and TX pull up by default Martin Blumenstingl
                   ` (3 preceding siblings ...)
  2025-03-29 18:58 ` [PATCH 4/7] arm64: dts: amlogic: gxl: " Martin Blumenstingl
@ 2025-03-29 18:58 ` Martin Blumenstingl
  2025-03-29 18:58 ` [PATCH 6/7] arm64: dts: amlogic: axg: " Martin Blumenstingl
                   ` (3 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Martin Blumenstingl @ 2025-03-29 18:58 UTC (permalink / raw)
  To: linux-amlogic
  Cc: devicetree, neil.armstrong, Martin Blumenstingl, khilman,
	linux-kernel, linux-arm-kernel, jbrunet

Some boards have noise on the UART RX line when the UART pins are not
connected to another device (such as an USB UART adapter). This can
be addressed by using a pull up resistor. Not all boards may provide
such a pull up resistor on the PCB so enable the SoC's pull-up on the
UART RX and TX pads by default. This matches the default (from u-boot
or SoC hardware) state for the pinmux configuration on these pads.

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
index ab2b3f15ef19..12e8daaa1c9b 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
@@ -1503,7 +1503,7 @@ mux {
 							groups = "uart_a_tx",
 								 "uart_a_rx";
 							function = "uart_a";
-							bias-disable;
+							bias-pull-up;
 						};
 					};
 
@@ -1521,7 +1521,7 @@ mux {
 							groups = "uart_b_tx",
 								 "uart_b_rx";
 							function = "uart_b";
-							bias-disable;
+							bias-pull-up;
 						};
 					};
 
@@ -1918,7 +1918,7 @@ mux {
 						groups = "uart_ao_a_tx",
 							 "uart_ao_a_rx";
 						function = "uart_ao_a";
-						bias-disable;
+						bias-pull-up;
 					};
 				};
 
@@ -1936,7 +1936,7 @@ mux {
 						groups = "uart_ao_b_tx_2",
 							 "uart_ao_b_rx_3";
 						function = "uart_ao_b";
-						bias-disable;
+						bias-pull-up;
 					};
 				};
 
@@ -1945,7 +1945,7 @@ mux {
 						groups = "uart_ao_b_tx_8",
 							 "uart_ao_b_rx_9";
 						function = "uart_ao_b";
-						bias-disable;
+						bias-pull-up;
 					};
 				};
 
-- 
2.49.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 6/7] arm64: dts: amlogic: axg: enable UART RX and TX pull up by default
  2025-03-29 18:58 [PATCH 0/7] dts: amlogic: enable UART RX and TX pull up by default Martin Blumenstingl
                   ` (4 preceding siblings ...)
  2025-03-29 18:58 ` [PATCH 5/7] arm64: dts: amlogic: g12: " Martin Blumenstingl
@ 2025-03-29 18:58 ` Martin Blumenstingl
  2025-03-29 18:58 ` [PATCH 7/7] arm64: dts: amlogic: a1: " Martin Blumenstingl
                   ` (2 subsequent siblings)
  8 siblings, 0 replies; 10+ messages in thread
From: Martin Blumenstingl @ 2025-03-29 18:58 UTC (permalink / raw)
  To: linux-amlogic
  Cc: devicetree, neil.armstrong, Martin Blumenstingl, khilman,
	linux-kernel, linux-arm-kernel, jbrunet

Some boards have noise on the UART RX line when the UART pins are not
connected to another device (such as an USB UART adapter). This can
be addressed by using a pull up resistor. Not all boards may provide
such a pull up resistor on the PCB so enable the SoC's pull-up on the
UART RX and TX pads by default. This matches the default (from u-boot
or SoC hardware) state for the pinmux configuration on these pads.

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
 arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 12 ++++++------
 1 file changed, 6 insertions(+), 6 deletions(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
index a6924d246bb1..2df143aa77ce 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
@@ -1164,7 +1164,7 @@ mux {
 						groups = "uart_tx_a",
 							 "uart_rx_a";
 						function = "uart_a";
-						bias-disable;
+						bias-pull-up;
 					};
 				};
 
@@ -1182,7 +1182,7 @@ mux {
 						groups = "uart_tx_b_x",
 							 "uart_rx_b_x";
 						function = "uart_b";
-						bias-disable;
+						bias-pull-up;
 					};
 				};
 
@@ -1200,7 +1200,7 @@ mux {
 						groups = "uart_tx_b_z",
 							 "uart_rx_b_z";
 						function = "uart_b";
-						bias-disable;
+						bias-pull-up;
 					};
 				};
 
@@ -1218,7 +1218,7 @@ mux {
 						groups = "uart_ao_tx_b_z",
 							 "uart_ao_rx_b_z";
 						function = "uart_ao_b_z";
-						bias-disable;
+						bias-pull-up;
 					};
 				};
 
@@ -1654,7 +1654,7 @@ mux {
 						groups = "uart_ao_tx_a",
 							 "uart_ao_rx_a";
 						function = "uart_ao_a";
-						bias-disable;
+						bias-pull-up;
 					};
 				};
 
@@ -1672,7 +1672,7 @@ mux {
 						groups = "uart_ao_tx_b",
 							 "uart_ao_rx_b";
 						function = "uart_ao_b";
-						bias-disable;
+						bias-pull-up;
 					};
 				};
 
-- 
2.49.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 10+ messages in thread

* [PATCH 7/7] arm64: dts: amlogic: a1: enable UART RX and TX pull up by default
  2025-03-29 18:58 [PATCH 0/7] dts: amlogic: enable UART RX and TX pull up by default Martin Blumenstingl
                   ` (5 preceding siblings ...)
  2025-03-29 18:58 ` [PATCH 6/7] arm64: dts: amlogic: axg: " Martin Blumenstingl
@ 2025-03-29 18:58 ` Martin Blumenstingl
  2025-03-31  6:42 ` [PATCH 0/7] dts: amlogic: " neil.armstrong
  2025-03-31  7:01 ` Neil Armstrong
  8 siblings, 0 replies; 10+ messages in thread
From: Martin Blumenstingl @ 2025-03-29 18:58 UTC (permalink / raw)
  To: linux-amlogic
  Cc: devicetree, neil.armstrong, Martin Blumenstingl, khilman,
	linux-kernel, linux-arm-kernel, jbrunet

Some boards have noise on the UART RX line when the UART pins are not
connected to another device (such as an USB UART adapter). This can
be addressed by using a pull up resistor. Not all boards may provide
such a pull up resistor on the PCB so enable the SoC's pull-up on the
UART RX and TX pads by default. This matches the default (from u-boot
or SoC hardware) state for the pinmux configuration on these pads.

Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
 arch/arm64/boot/dts/amlogic/meson-a1.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
index 1eba0afb3fd9..f7f25a10f409 100644
--- a/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-a1.dtsi
@@ -233,6 +233,7 @@ mux {
 						groups = "uart_a_tx",
 							 "uart_a_rx";
 						function = "uart_a";
+						bias-pull-up;
 					};
 				};
 
-- 
2.49.0


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 0/7] dts: amlogic: enable UART RX and TX pull up by default
  2025-03-29 18:58 [PATCH 0/7] dts: amlogic: enable UART RX and TX pull up by default Martin Blumenstingl
                   ` (6 preceding siblings ...)
  2025-03-29 18:58 ` [PATCH 7/7] arm64: dts: amlogic: a1: " Martin Blumenstingl
@ 2025-03-31  6:42 ` neil.armstrong
  2025-03-31  7:01 ` Neil Armstrong
  8 siblings, 0 replies; 10+ messages in thread
From: neil.armstrong @ 2025-03-31  6:42 UTC (permalink / raw)
  To: Martin Blumenstingl, linux-amlogic
  Cc: devicetree, khilman, linux-kernel, linux-arm-kernel, jbrunet

On 29/03/2025 19:58, Martin Blumenstingl wrote:
> On the LibreELEC forum there have been reports that Odroid-C2 does not
> boot when UART is left disconnected [0]. It turns out that this can be
> solved by enabling the SoCs pull-up resistor on the UART RX and TX
> pads [1].
> It's not clear whether that specific Odroid-C2 board has a broken
> resistor, the resistor is not populated (either by accident or on
> purpose) or if there's another reason.
> 
> Testing on an SM1 X96-Air shows that pull-ups being enabled on UART
> RX and TX is actually the default (either set in vendor u-boot or an
> actual hardware default).
> 
> This series enables the UART RX and TX pull up resistors in the
> default pin configuration on all supported SoCs.
> 
> Testing has been done on:
> - GXBB Odroid-C1 on u-boot by a user in the LibreELEC forums [2]
> - Meson8b Odroid-C1 on Linux (with vendor u-boot)
> - SM1 X96-Air on Linux (with vendor u-boot)
> 
> Please include this early so the various CI systems can test these
> patches.
> 
> 
> [0] https://forum.libreelec.tv/thread/28586-odroid-c2-gxbb-s905-and-le-11-06-or-12-does-not-boot/?postID=195481#post195481
> [1] https://forum.libreelec.tv/thread/28586-odroid-c2-gxbb-s905-and-le-11-06-or-12-does-not-boot/?postID=195667#post195667
> [2] https://forum.libreelec.tv/thread/28586-odroid-c2-gxbb-s905-and-le-11-06-or-12-does-not-boot/?postID=195674#post195674
> 
> 
> Martin Blumenstingl (7):
>    ARM: dts: amlogic: meson8: enable UART RX and TX pull up by default
>    ARM: dts: amlogic: meson8b: enable UART RX and TX pull up by default
>    arm64: dts: amlogic: gxbb: enable UART RX and TX pull up by default
>    arm64: dts: amlogic: gxl: enable UART RX and TX pull up by default
>    arm64: dts: amlogic: g12: enable UART RX and TX pull up by default
>    arm64: dts: amlogic: axg: enable UART RX and TX pull up by default
>    arm64: dts: amlogic: a1: enable UART RX and TX pull up by default
> 
>   arch/arm/boot/dts/amlogic/meson8.dtsi             |  4 ++--
>   arch/arm/boot/dts/amlogic/meson8b.dtsi            |  4 ++--
>   arch/arm64/boot/dts/amlogic/meson-a1.dtsi         |  1 +
>   arch/arm64/boot/dts/amlogic/meson-axg.dtsi        | 12 ++++++------
>   arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 10 +++++-----
>   arch/arm64/boot/dts/amlogic/meson-gxbb.dtsi       | 10 +++++-----
>   arch/arm64/boot/dts/amlogic/meson-gxl.dtsi        | 12 ++++++------
>   7 files changed, 27 insertions(+), 26 deletions(-)
> 

Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>

I'll apply them now so they can be tested on -next for this whole cycle.

Thanks,
Neil

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 10+ messages in thread

* Re: [PATCH 0/7] dts: amlogic: enable UART RX and TX pull up by default
  2025-03-29 18:58 [PATCH 0/7] dts: amlogic: enable UART RX and TX pull up by default Martin Blumenstingl
                   ` (7 preceding siblings ...)
  2025-03-31  6:42 ` [PATCH 0/7] dts: amlogic: " neil.armstrong
@ 2025-03-31  7:01 ` Neil Armstrong
  8 siblings, 0 replies; 10+ messages in thread
From: Neil Armstrong @ 2025-03-31  7:01 UTC (permalink / raw)
  To: linux-amlogic, Martin Blumenstingl
  Cc: devicetree, khilman, linux-kernel, linux-arm-kernel, jbrunet

Hi,

On Sat, 29 Mar 2025 19:58:48 +0100, Martin Blumenstingl wrote:
> On the LibreELEC forum there have been reports that Odroid-C2 does not
> boot when UART is left disconnected [0]. It turns out that this can be
> solved by enabling the SoCs pull-up resistor on the UART RX and TX
> pads [1].
> It's not clear whether that specific Odroid-C2 board has a broken
> resistor, the resistor is not populated (either by accident or on
> purpose) or if there's another reason.
> 
> [...]

Thanks, Applied to https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git (v6.16/arm64-dt)

[1/7] ARM: dts: amlogic: meson8: enable UART RX and TX pull up by default
      https://git.kernel.org/amlogic/c/cfd9d2466ed2891bacb6319bcf9af55f21d0263e
[2/7] ARM: dts: amlogic: meson8b: enable UART RX and TX pull up by default
      https://git.kernel.org/amlogic/c/7374b06e8099ce7345ff3afd4bb756dde25971c1
[3/7] arm64: dts: amlogic: gxbb: enable UART RX and TX pull up by default
      https://git.kernel.org/amlogic/c/b00fe005612080772fe4f00c61e2fcdd2dea18f0
[4/7] arm64: dts: amlogic: gxl: enable UART RX and TX pull up by default
      https://git.kernel.org/amlogic/c/bbeb3017f1596a0551ba0ee40866f8b4e0ca2d3e
[5/7] arm64: dts: amlogic: g12: enable UART RX and TX pull up by default
      https://git.kernel.org/amlogic/c/867c3760da4ebd760115f17eca0b4bd3b668941c
[6/7] arm64: dts: amlogic: axg: enable UART RX and TX pull up by default
      https://git.kernel.org/amlogic/c/48d5da715331f2fd5e17e64f9e75e74248223b66
[7/7] arm64: dts: amlogic: a1: enable UART RX and TX pull up by default
      https://git.kernel.org/amlogic/c/b85aae3714e65d7b92a6c2c28f62cf66393dfcac

These changes has been applied on the intermediate git tree [1].

The v6.16/arm64-dt branch will then be sent via a formal Pull Request to the Linux SoC maintainers
for inclusion in their intermediate git branches in order to be sent to Linus during
the next merge window, or sooner if it's a set of fixes.

In the cases of fixes, those will be merged in the current release candidate
kernel and as soon they appear on the Linux master branch they will be
backported to the previous Stable and Long-Stable kernels [2].

The intermediate git branches are merged daily in the linux-next tree [3],
people are encouraged testing these pre-release kernels and report issues on the
relevant mailing-lists.

If problems are discovered on those changes, please submit a signed-off-by revert
patch followed by a corrective changeset.

[1] https://git.kernel.org/pub/scm/linux/kernel/git/amlogic/linux.git
[2] https://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git
[3] https://git.kernel.org/pub/scm/linux/kernel/git/next/linux-next.git

-- 
Neil


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2025-03-31  7:04 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-29 18:58 [PATCH 0/7] dts: amlogic: enable UART RX and TX pull up by default Martin Blumenstingl
2025-03-29 18:58 ` [PATCH 1/7] ARM: dts: amlogic: meson8: " Martin Blumenstingl
2025-03-29 18:58 ` [PATCH 2/7] ARM: dts: amlogic: meson8b: " Martin Blumenstingl
2025-03-29 18:58 ` [PATCH 3/7] arm64: dts: amlogic: gxbb: " Martin Blumenstingl
2025-03-29 18:58 ` [PATCH 4/7] arm64: dts: amlogic: gxl: " Martin Blumenstingl
2025-03-29 18:58 ` [PATCH 5/7] arm64: dts: amlogic: g12: " Martin Blumenstingl
2025-03-29 18:58 ` [PATCH 6/7] arm64: dts: amlogic: axg: " Martin Blumenstingl
2025-03-29 18:58 ` [PATCH 7/7] arm64: dts: amlogic: a1: " Martin Blumenstingl
2025-03-31  6:42 ` [PATCH 0/7] dts: amlogic: " neil.armstrong
2025-03-31  7:01 ` Neil Armstrong

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®