From: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
To: Ronald Claveau <linux-kernel-dev@aliel.fr>
Cc: Guillaume La Roque <glaroque@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Jerome Brunet <jbrunet@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-pm@vger.kernel.org, Mark Brown <broonie@kernel.org>,
kernel test robot <lkp@intel.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Daniel Lezcano <daniel.lezcano@kernel.org>,
Zhang Rui <rui.zhang@intel.com>,
"Rafael J. Wysocki" <rafael@kernel.org>,
Lukasz Luba <lukasz.luba@arm.com>
Subject: Re: [PATCH v2] firmware: meson: sm: add stub functions when CONFIG_MESON_SM is disabled
Date: Sun, 31 May 2026 21:58:17 +0200 [thread overview]
Message-ID: <0c5033f7-1535-49e8-a502-426e54333496@oss.qualcomm.com> (raw)
In-Reply-To: <12d74340-0213-4f7e-a494-10ce147844ad@aliel.fr>
On 5/31/26 19:49, Ronald Claveau wrote:
> On 5/31/26 10:41 AM, Daniel Lezcano wrote:
>> On 5/31/26 09:51, Ronald Claveau via B4 Relay wrote:
>>> From: Ronald Claveau <linux-kernel-dev@aliel.fr>
[ ... ]
>>> +#if IS_ENABLED(CONFIG_MESON_SM)
>>> +
>>> struct meson_sm_firmware *meson_sm_get(struct device_node
>>> *firmware_node);
>>> int meson_sm_get_thermal_calib(struct meson_sm_firmware *fw, u32
>>> *trim_info,
>>> u32 tsensor_id);
>>
>> Do you really want to compile meson_sm as a module ?
>>
>>
>>
>
> I don't want, but if I send a patch to change tristate to bool, it will
> raise a warning because 'm' is not valid.
> If it is accepted to ignore this warning, I can send another patch.
Sorry, I don't get your point :/
'm' is a config option, make menuconfig should set it to yes or not set.
Compiling the firmware as a module means it must be loaded before the
amlogic thermal driver, right ? Where is the dependency declared in the
module ?
If the sm_meson is in the platform, it should be selected as part of the
platform's component. No need to have an option for that, no ?
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2026-05-31 19:58 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-31 7:51 Ronald Claveau via B4 Relay
2026-05-31 8:41 ` Daniel Lezcano
2026-05-31 17:49 ` Ronald Claveau
2026-05-31 19:58 ` Daniel Lezcano [this message]
2026-06-02 9:57 ` Daniel Lezcano
2026-06-02 11:58 ` Ronald Claveau
2026-06-02 12:15 ` Daniel Lezcano
2026-06-02 13:25 ` Ronald Claveau
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0c5033f7-1535-49e8-a502-426e54333496@oss.qualcomm.com \
--to=daniel.lezcano@oss.qualcomm.com \
--cc=broonie@kernel.org \
--cc=daniel.lezcano@kernel.org \
--cc=glaroque@baylibre.com \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel-dev@aliel.fr \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=lkp@intel.com \
--cc=lukasz.luba@arm.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
--cc=rafael@kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®