Re: [PATCH v2] firmware: meson: sm: add stub functions when CONFIG_MESON_SM is disabled

From: Ronald Claveau <linux-kernel-dev@aliel.fr>
To: Daniel Lezcano <daniel.lezcano@oss.qualcomm.com>
Cc: Guillaume La Roque <glaroque@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
	linux-pm@vger.kernel.org, Mark Brown <broonie@kernel.org>,
	kernel test robot <lkp@intel.com>,
	Neil Armstrong <neil.armstrong@linaro.org>,
	Daniel Lezcano <daniel.lezcano@kernel.org>,
	Zhang Rui <rui.zhang@intel.com>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	Lukasz Luba <lukasz.luba@arm.com>
Subject: Re: [PATCH v2] firmware: meson: sm: add stub functions when CONFIG_MESON_SM is disabled
Date: Tue, 2 Jun 2026 13:58:45 +0200	[thread overview]
Message-ID: <376eec65-20ea-434b-a6ee-edbc12e6d7d9@aliel.fr> (raw)
In-Reply-To: <59afecd4-7749-4be5-a261-a850634178b1@oss.qualcomm.com>

On 6/2/26 11:57 AM, Daniel Lezcano wrote:
> On 5/31/26 21:58, Daniel Lezcano wrote:
>> On 5/31/26 19:49, Ronald Claveau wrote:
>>> On 5/31/26 10:41 AM, Daniel Lezcano wrote:
>>>> On 5/31/26 09:51, Ronald Claveau via B4 Relay wrote:
>>>>> From: Ronald Claveau <linux-kernel-dev@aliel.fr>
>>
>> [ ... ]
>>
>>>>> +#if IS_ENABLED(CONFIG_MESON_SM)
>>>>> +
>>>>>    struct meson_sm_firmware *meson_sm_get(struct device_node
>>>>> *firmware_node);
>>>>>    int meson_sm_get_thermal_calib(struct meson_sm_firmware *fw, u32
>>>>> *trim_info,
>>>>>                       u32 tsensor_id);
>>>>
>>>> Do you really want to compile meson_sm as a module ?
>>>>
>>>>
>>>>
>>>
>>> I don't want, but if I send a patch to change tristate to bool, it will
>>> raise a warning because 'm' is not valid.
>>> If it is accepted to ignore this warning, I can send another patch.
>>
> 
> [ ... ]
> 
>> Compiling the firmware as a module means it must be loaded before the
>> amlogic thermal driver, right ? Where is the dependency declared in
>> the module ?
>>
>> If the sm_meson is in the platform, it should be selected as part of
>> the platform's component. No need to have an option for that, no ?
> 
> The questions remain and PR is approaching ...

Sorry for the delay.
The module issue was raised by the test robot here
https://lore.kernel.org/oe-kbuild-all/202605310154.bmdMBZHJ-lkp@intel.com/

If I understand correctly we can drop this stub change and only use a
"depends on MESON_SM" for the "AMLOGIC_THERMAL" config, is it correct ?

-- 
Best regards,
Ronald

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic