mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: jbrunet@baylibre.com (jbrunet at baylibre.com)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v4 0/2] clk: meson-g12a: Add EE clock controller driver
Date: Thu, 08 Nov 2018 14:34:37 +0100	[thread overview]
Message-ID: <1157f0a9419eea01c099d8dc08d7757593720286.camel@baylibre.com> (raw)
In-Reply-To: <1541682912-120480-1-git-send-email-jian.hu@amlogic.com>

On Thu, 2018-11-08 at 21:15 +0800, Jian Hu wrote:
> Changes since v3 at[4]
> -add fixed clocks clk_regmap definition

Jian,

When replying to the v1 of your clk_ao patchset : 
https://patchwork.kernel.org/patch/10562563/#22177627

I have explained that I would like to stop taking clock (such as xtal) from
nowhere. Clocks (even the xtal) should be properly claimed through DT.
I have specifically asked this to be taken into account for the EE controller.

If you need an exemple on how to get the input clock from DT to your
controller, please have look at the axg audio clock controller.

This comment does not appear to be addressed in this version. 
Please make sure you have addressed all the comments of past reviews before
reposting

Thx

> 
> Changes since v2 at[2]
> -fix fixed clocks's descriptions
> -fix aligment
> -add enable bit for plls base on [3] patches
> -add fixed clock gate bit
> 
> Changes since v1 at[1]
> -fix typo of 'Everything'.
> -change the word 'AmLogic' to 'Amlogic'
> -squash patch 1 and 2.
> -delete usless message of "Trying obsolete regs".
> -delete the empty line in include/dt-bindings/clock/g12a-clkc.h.
> -rebase on top of the "next/drivers" branch, and add g12a clock patch.
> -add CLK_MUX_ROUND_CLOSEST for g12a_sd_emmc_b_clk0_sel and
>  g12a_sd_emmc_c_clk0_sel.
> 
> [1]
> https://lkml.kernel.org/r/1531133549-25806-2-git-send-email-jian.hu at amlogic.com
> [2]
> https://lkml.kernel.org/r/1531728707-192230-2-git-send-email-jian.hu at amlogic.com
> [3]https://lkml.kernel.org/r/20180717095617.12240-1-jbrunet at baylibre.com
> [4]
> https://lkml.kernel.org/r/1533890858-113020-1-git-send-email-jian.hu at amlogic.com
> 
> Jian Hu (2):
>   dt-bindings: clk: meson-g12a: Add G12A EE Clock Bindings
>   clk: meson-g12a: Add EE Clock controller driver
> 
>  .../bindings/clock/amlogic,gxbb-clkc.txt           |    1 +
>  drivers/clk/meson/Kconfig                          |   10 +
>  drivers/clk/meson/Makefile                         |    1 +
>  drivers/clk/meson/g12a.c                           | 1134
> ++++++++++++++++++++
>  drivers/clk/meson/g12a.h                           |  128 +++
>  include/dt-bindings/clock/g12a-clkc.h              |   93 ++
>  6 files changed, 1367 insertions(+)
>  create mode 100644 drivers/clk/meson/g12a.c
>  create mode 100644 drivers/clk/meson/g12a.h
>  create mode 100644 include/dt-bindings/clock/g12a-clkc.h
> 

  parent reply	other threads:[~2018-11-08 13:34 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-08 13:15 Jian Hu
2018-11-08 13:15 ` [PATCH v4 1/2] dt-bindings: clk: meson-g12a: Add G12A EE Clock Bindings Jian Hu
2018-11-13  0:24   ` Rob Herring
2018-11-08 13:15 ` [PATCH v4 2/2] clk: meson-g12a: Add EE Clock controller driver Jian Hu
2018-11-25 16:19   ` Martin Blumenstingl
2018-11-28  7:12     ` Jian Hu
2018-11-08 13:34 ` jbrunet at baylibre.com [this message]
2018-11-09  7:51   ` [PATCH v4 0/2] clk: meson-g12a: Add EE clock " Jian Hu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1157f0a9419eea01c099d8dc08d7757593720286.camel@baylibre.com \
    --to=jbrunet@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®