From: mturquette@baylibre.com (Michael Turquette)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 4/7] meson: clk: Add CLKIDs for DT binding
Date: Tue, 05 Jul 2016 17:33:20 -0700 [thread overview]
Message-ID: <146776520074.35356.1068171268289036149@resonance> (raw)
In-Reply-To: <1467741391-60534-5-git-send-email-serveralex@gmail.com>
Hi Alexander,
Quoting Alexander M?ller (2016-07-05 10:56:28)
> +#define CLKID_AO_AHB_BUS 91
> +#define CLKID_AO_IFACE 92
>
> -#define CLK_NR_CLKS (CLKID_MPEG_DIV + 1)
> +#define CLK_NR_CLKS (CLKID_AO_IFACE + 1)
Did you take a look at how I did this for gxbb? I like to limit the
number of clocks exposed in DT as much as possible. This is because a DT
binding (of which this header is a part) constitutes an immutable ABI
which shall only be relinquished when the Sun burns out and our solar
system dies.
Also, putting NR_CLKS inside of the binding is kind of gross, since the
binding doesn't care about that value, but the driver does. The GXBB clk
driver has two headers: one internal to Linux with the bulk of the
clks and NR_CLKS, and a second one in the shared DT header chroot that
only exposes the bare minimum necessary.
Regards,
Mike
next prev parent reply other threads:[~2016-07-06 0:33 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 17:56 [PATCH 0/7] Add Amlogic meson8b clock gates Alexander Müller
2016-07-05 17:56 ` [PATCH 1/7] clk: meson: Rename meson8b-clkc.c to reflect gxbb naming convention Alexander Müller
2016-07-05 18:55 ` Carlo Caione
2016-07-05 19:15 ` Alexander Müller
2016-07-05 17:56 ` [PATCH 2/7] meson: clk: Move register definitions to meson8b.h Alexander Müller
2016-07-05 17:56 ` [PATCH 3/7] meson: clk: Rename register names according to Amlogic datasheet Alexander Müller
2016-07-06 0:28 ` Michael Turquette
2016-07-05 17:56 ` [PATCH 4/7] meson: clk: Add CLKIDs for DT binding Alexander Müller
2016-07-06 0:33 ` Michael Turquette [this message]
2016-07-05 17:56 ` [PATCH 5/7] gxbb: clk: Move MESON_GATE macro to gxbb Alexander Müller
2016-07-06 0:36 ` Michael Turquette
2016-07-13 17:43 ` Alexander Müller
2016-07-13 21:25 ` Michael Turquette
2016-07-05 17:56 ` [PATCH 6/7] meson: clk: Add support for clock gates Alexander Müller
2016-07-05 18:01 ` Ben Dooks
2016-07-06 0:51 ` Michael Turquette
2016-07-06 7:35 ` Ben Dooks
2016-07-06 8:11 ` Michael Turquette
2016-07-06 8:50 ` Ben Dooks
2016-07-06 20:36 ` Michael Turquette
2016-07-05 17:56 ` [PATCH 7/7] arm: amlogic: select meson8b clk driver Alexander Müller
2016-07-06 0:54 ` Michael Turquette
2016-07-06 21:41 ` Kevin Hilman
2016-07-13 17:53 ` Alexander Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=146776520074.35356.1068171268289036149@resonance \
--to=mturquette@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®