From: mturquette@baylibre.com (Michael Turquette)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 6/7] meson: clk: Add support for clock gates
Date: Tue, 05 Jul 2016 17:51:08 -0700 [thread overview]
Message-ID: <146776626852.35356.9847034661606022714@resonance> (raw)
In-Reply-To: <b42e2bb3-2cd0-3115-9be4-16e3a48b46fd@codethink.co.uk>
Hi Ben,
Quoting Ben Dooks (2016-07-05 11:01:14)
> On 05/07/16 18:56, Alexander M?ller wrote:
> > This patch adds support for the meson8b clock gates. Most of
> > them are disabled by Amlogic U-Boot, but need to be enabled
> > for ethernet, USB and many other components.
> >
> > Signed-off-by: Alexander M?ller <serveralex@gmail.com>
> > ---
>
> This seems to be a lot of structures for clocks that may
> never be use. I think it would be better to provide a custom
> lookup function that creates these as needed and use the ID
> in the dt as a offset+bit id.
We want the real clocks registered so that we can disable spuriously
enabled at late_initcall time with clk_disable_unused.
Furthermore, I'd like to not represent all of these gates in the DT
binding description (see my response to the earlier patches in this
series), since it becomes ABI (and a maintenance nightmare).
Regards,
Mike
>
> --
> Ben Dooks http://www.codethink.co.uk/
> Senior Engineer Codethink - Providing Genius
next prev parent reply other threads:[~2016-07-06 0:51 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 17:56 [PATCH 0/7] Add Amlogic meson8b " Alexander Müller
2016-07-05 17:56 ` [PATCH 1/7] clk: meson: Rename meson8b-clkc.c to reflect gxbb naming convention Alexander Müller
2016-07-05 18:55 ` Carlo Caione
2016-07-05 19:15 ` Alexander Müller
2016-07-05 17:56 ` [PATCH 2/7] meson: clk: Move register definitions to meson8b.h Alexander Müller
2016-07-05 17:56 ` [PATCH 3/7] meson: clk: Rename register names according to Amlogic datasheet Alexander Müller
2016-07-06 0:28 ` Michael Turquette
2016-07-05 17:56 ` [PATCH 4/7] meson: clk: Add CLKIDs for DT binding Alexander Müller
2016-07-06 0:33 ` Michael Turquette
2016-07-05 17:56 ` [PATCH 5/7] gxbb: clk: Move MESON_GATE macro to gxbb Alexander Müller
2016-07-06 0:36 ` Michael Turquette
2016-07-13 17:43 ` Alexander Müller
2016-07-13 21:25 ` Michael Turquette
2016-07-05 17:56 ` [PATCH 6/7] meson: clk: Add support for clock gates Alexander Müller
2016-07-05 18:01 ` Ben Dooks
2016-07-06 0:51 ` Michael Turquette [this message]
2016-07-06 7:35 ` Ben Dooks
2016-07-06 8:11 ` Michael Turquette
2016-07-06 8:50 ` Ben Dooks
2016-07-06 20:36 ` Michael Turquette
2016-07-05 17:56 ` [PATCH 7/7] arm: amlogic: select meson8b clk driver Alexander Müller
2016-07-06 0:54 ` Michael Turquette
2016-07-06 21:41 ` Kevin Hilman
2016-07-13 17:53 ` Alexander Müller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=146776626852.35356.9847034661606022714@resonance \
--to=mturquette@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®