* [PATCH] media: cec: meson: always include meson sub-directory in Makefile [not found] <CGME20231012103531eucas1p1f370bddcb690aa421498e961f4081f2b@eucas1p1.samsung.com> @ 2023-10-12 10:35 ` Marek Szyprowski 2023-10-12 10:42 ` Hans Verkuil 0 siblings, 1 reply; 3+ messages in thread From: Marek Szyprowski @ 2023-10-12 10:35 UTC (permalink / raw) To: linux-amlogic, linux-media, linux-kernel Cc: Marek Szyprowski, Hans Verkuil, Mauro Carvalho Chehab 'meson' directory contains two separate drivers, so it should be added to Makefile compilation hierarchy unconditionally, because otherwise the meson-ao-cec-g12a won't be compiled if meson-ao-cec is not selected. Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> --- drivers/media/cec/platform/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/cec/platform/Makefile b/drivers/media/cec/platform/Makefile index 26d2bc778394..a51e98ab4958 100644 --- a/drivers/media/cec/platform/Makefile +++ b/drivers/media/cec/platform/Makefile @@ -6,7 +6,7 @@ # Please keep it in alphabetic order obj-$(CONFIG_CEC_CROS_EC) += cros-ec/ obj-$(CONFIG_CEC_GPIO) += cec-gpio/ -obj-$(CONFIG_CEC_MESON_AO) += meson/ +obj-y += meson/ obj-$(CONFIG_CEC_SAMSUNG_S5P) += s5p/ obj-$(CONFIG_CEC_SECO) += seco/ obj-$(CONFIG_CEC_STI) += sti/ -- 2.34.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: cec: meson: always include meson sub-directory in Makefile 2023-10-12 10:35 ` [PATCH] media: cec: meson: always include meson sub-directory in Makefile Marek Szyprowski @ 2023-10-12 10:42 ` Hans Verkuil 2023-10-12 10:51 ` Marek Szyprowski 0 siblings, 1 reply; 3+ messages in thread From: Hans Verkuil @ 2023-10-12 10:42 UTC (permalink / raw) To: Marek Szyprowski, linux-amlogic, linux-media, linux-kernel Cc: Mauro Carvalho Chehab On 10/12/23 12:35, Marek Szyprowski wrote: > 'meson' directory contains two separate drivers, so it should be added > to Makefile compilation hierarchy unconditionally, because otherwise the > meson-ao-cec-g12a won't be compiled if meson-ao-cec is not selected. > > Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> Does this need a Fixes tag? Regards, Hans > --- > drivers/media/cec/platform/Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/media/cec/platform/Makefile b/drivers/media/cec/platform/Makefile > index 26d2bc778394..a51e98ab4958 100644 > --- a/drivers/media/cec/platform/Makefile > +++ b/drivers/media/cec/platform/Makefile > @@ -6,7 +6,7 @@ > # Please keep it in alphabetic order > obj-$(CONFIG_CEC_CROS_EC) += cros-ec/ > obj-$(CONFIG_CEC_GPIO) += cec-gpio/ > -obj-$(CONFIG_CEC_MESON_AO) += meson/ > +obj-y += meson/ > obj-$(CONFIG_CEC_SAMSUNG_S5P) += s5p/ > obj-$(CONFIG_CEC_SECO) += seco/ > obj-$(CONFIG_CEC_STI) += sti/ _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] media: cec: meson: always include meson sub-directory in Makefile 2023-10-12 10:42 ` Hans Verkuil @ 2023-10-12 10:51 ` Marek Szyprowski 0 siblings, 0 replies; 3+ messages in thread From: Marek Szyprowski @ 2023-10-12 10:51 UTC (permalink / raw) To: Hans Verkuil, linux-amlogic, linux-media, linux-kernel Cc: Mauro Carvalho Chehab On 12.10.2023 12:42, Hans Verkuil wrote: > On 10/12/23 12:35, Marek Szyprowski wrote: >> 'meson' directory contains two separate drivers, so it should be added >> to Makefile compilation hierarchy unconditionally, because otherwise the >> meson-ao-cec-g12a won't be compiled if meson-ao-cec is not selected. >> >> Signed-off-by: Marek Szyprowski <m.szyprowski@samsung.com> > Does this need a Fixes tag? Fixes: 4be5e8648b0c ("media: move CEC platform drivers to a separate directory") Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-10-12 10:51 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <CGME20231012103531eucas1p1f370bddcb690aa421498e961f4081f2b@eucas1p1.samsung.com>
2023-10-12 10:35 ` [PATCH] media: cec: meson: always include meson sub-directory in Makefile Marek Szyprowski
2023-10-12 10:42 ` Hans Verkuil
2023-10-12 10:51 ` Marek Szyprowski
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®