mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
* [PATCH] usb: dwc3-of-simple: fix error check of clk_get_bulk when disabled
@ 2018-04-12  8:13 Neil Armstrong
  2018-04-12  8:47 ` Marek Vasut
  0 siblings, 1 reply; 2+ messages in thread
From: Neil Armstrong @ 2018-04-12  8:13 UTC (permalink / raw)
  To: linus-amlogic

The disabled clk API returns -ENOSYS unlike the reset API returning -ENOTSUPP.

Fixes: ca7fdc8b1267 ("usb: host: Add simple of glue driver for DWC3 USB Controllers integration")
Reported-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
---
 drivers/usb/host/dwc3-of-simple.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/usb/host/dwc3-of-simple.c b/drivers/usb/host/dwc3-of-simple.c
index 54a5f60..1f08208 100644
--- a/drivers/usb/host/dwc3-of-simple.c
+++ b/drivers/usb/host/dwc3-of-simple.c
@@ -50,7 +50,7 @@ static int dwc3_of_simple_clk_init(struct udevice *dev,
 	int ret;
 
 	ret = clk_get_bulk(dev, &simple->clks);
-	if (ret == -ENOTSUPP)
+	if (ret == -ENOSYS)
 		return 0;
 	if (ret)
 		return ret;
-- 
2.7.4

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH] usb: dwc3-of-simple: fix error check of clk_get_bulk when disabled
  2018-04-12  8:13 [PATCH] usb: dwc3-of-simple: fix error check of clk_get_bulk when disabled Neil Armstrong
@ 2018-04-12  8:47 ` Marek Vasut
  0 siblings, 0 replies; 2+ messages in thread
From: Marek Vasut @ 2018-04-12  8:47 UTC (permalink / raw)
  To: linus-amlogic

On 04/12/2018 10:13 AM, Neil Armstrong wrote:
> The disabled clk API returns -ENOSYS unlike the reset API returning -ENOTSUPP.
> 
> Fixes: ca7fdc8b1267 ("usb: host: Add simple of glue driver for DWC3 USB Controllers integration")
> Reported-by: Jean-Jacques Hiblot <jjhiblot@ti.com>
> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
> ---
>  drivers/usb/host/dwc3-of-simple.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/dwc3-of-simple.c b/drivers/usb/host/dwc3-of-simple.c
> index 54a5f60..1f08208 100644
> --- a/drivers/usb/host/dwc3-of-simple.c
> +++ b/drivers/usb/host/dwc3-of-simple.c
> @@ -50,7 +50,7 @@ static int dwc3_of_simple_clk_init(struct udevice *dev,
>  	int ret;
>  
>  	ret = clk_get_bulk(dev, &simple->clks);
> -	if (ret == -ENOTSUPP)
> +	if (ret == -ENOSYS)
>  		return 0;
>  	if (ret)
>  		return ret;
> 

Applied, thanks

-- 
Best regards,
Marek Vasut

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-04-12  8:47 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-12  8:13 [PATCH] usb: dwc3-of-simple: fix error check of clk_get_bulk when disabled Neil Armstrong
2018-04-12  8:47 ` Marek Vasut

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®