mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: jbrunet@baylibre.com (Jerome Brunet)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH clk-fixes] clk: meson: meson8b: fix meson8b_cpu_clk parent clock name
Date: Mon, 23 Apr 2018 21:41:46 +0200	[thread overview]
Message-ID: <1524512506.4026.31.camel@baylibre.com> (raw)
In-Reply-To: <20180423193029.29428-1-martin.blumenstingl@googlemail.com>

On Mon, 2018-04-23 at 21:30 +0200, Martin Blumenstingl wrote:
> meson8b_cpu_clk has two parent clocks:
> - meson8b_xtal
> - meson8b_cpu_scale_out_sel
> 
> The name of the "xtal" clock parent is specified correctly. However,
> there is a typo in the name of the second parent clock. The
> meson8b_cpu_scale_out_sel definition uses the name "cpu_scale_out_sel"
> (which matches the name from the datasheet). However, the mux parent
> definition uses the name "cpu_out_sel" which does not match any existing
> clock.
> 
> Fixes: 251b6fd38bcb9c ("clk: meson: rework meson8b cpu clock")
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

Roohhh ... Sorry about that :(

I'll take it along with the other typo fix. Thx Martin !

> ---
>  drivers/clk/meson/meson8b.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/clk/meson/meson8b.c b/drivers/clk/meson/meson8b.c
> index 2c4ff6192852..d0524ec71aad 100644
> --- a/drivers/clk/meson/meson8b.c
> +++ b/drivers/clk/meson/meson8b.c
> @@ -632,7 +632,8 @@ static struct clk_regmap meson8b_cpu_clk = {
>  	.hw.init = &(struct clk_init_data){
>  		.name = "cpu_clk",
>  		.ops = &clk_regmap_mux_ro_ops,
> -		.parent_names = (const char *[]){ "xtal", "cpu_out_sel" },
> +		.parent_names = (const char *[]){ "xtal",
> +						  "cpu_scale_out_sel" },
>  		.num_parents = 2,
>  		.flags = (CLK_SET_RATE_PARENT |
>  			  CLK_SET_RATE_NO_REPARENT),

      reply	other threads:[~2018-04-23 19:41 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-23 19:30 Martin Blumenstingl
2018-04-23 19:41 ` Jerome Brunet [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1524512506.4026.31.camel@baylibre.com \
    --to=jbrunet@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®