* [PATCH clk-fixes] clk: meson: meson8b: fix meson8b_cpu_clk parent clock name
@ 2018-04-23 19:30 Martin Blumenstingl
2018-04-23 19:41 ` Jerome Brunet
0 siblings, 1 reply; 2+ messages in thread
From: Martin Blumenstingl @ 2018-04-23 19:30 UTC (permalink / raw)
To: linus-amlogic
meson8b_cpu_clk has two parent clocks:
- meson8b_xtal
- meson8b_cpu_scale_out_sel
The name of the "xtal" clock parent is specified correctly. However,
there is a typo in the name of the second parent clock. The
meson8b_cpu_scale_out_sel definition uses the name "cpu_scale_out_sel"
(which matches the name from the datasheet). However, the mux parent
definition uses the name "cpu_out_sel" which does not match any existing
clock.
Fixes: 251b6fd38bcb9c ("clk: meson: rework meson8b cpu clock")
Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
---
drivers/clk/meson/meson8b.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/meson/meson8b.c b/drivers/clk/meson/meson8b.c
index 2c4ff6192852..d0524ec71aad 100644
--- a/drivers/clk/meson/meson8b.c
+++ b/drivers/clk/meson/meson8b.c
@@ -632,7 +632,8 @@ static struct clk_regmap meson8b_cpu_clk = {
.hw.init = &(struct clk_init_data){
.name = "cpu_clk",
.ops = &clk_regmap_mux_ro_ops,
- .parent_names = (const char *[]){ "xtal", "cpu_out_sel" },
+ .parent_names = (const char *[]){ "xtal",
+ "cpu_scale_out_sel" },
.num_parents = 2,
.flags = (CLK_SET_RATE_PARENT |
CLK_SET_RATE_NO_REPARENT),
--
2.17.0
^ permalink raw reply [flat|nested] 2+ messages in thread* [PATCH clk-fixes] clk: meson: meson8b: fix meson8b_cpu_clk parent clock name
2018-04-23 19:30 [PATCH clk-fixes] clk: meson: meson8b: fix meson8b_cpu_clk parent clock name Martin Blumenstingl
@ 2018-04-23 19:41 ` Jerome Brunet
0 siblings, 0 replies; 2+ messages in thread
From: Jerome Brunet @ 2018-04-23 19:41 UTC (permalink / raw)
To: linus-amlogic
On Mon, 2018-04-23 at 21:30 +0200, Martin Blumenstingl wrote:
> meson8b_cpu_clk has two parent clocks:
> - meson8b_xtal
> - meson8b_cpu_scale_out_sel
>
> The name of the "xtal" clock parent is specified correctly. However,
> there is a typo in the name of the second parent clock. The
> meson8b_cpu_scale_out_sel definition uses the name "cpu_scale_out_sel"
> (which matches the name from the datasheet). However, the mux parent
> definition uses the name "cpu_out_sel" which does not match any existing
> clock.
>
> Fixes: 251b6fd38bcb9c ("clk: meson: rework meson8b cpu clock")
> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Roohhh ... Sorry about that :(
I'll take it along with the other typo fix. Thx Martin !
> ---
> drivers/clk/meson/meson8b.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/meson/meson8b.c b/drivers/clk/meson/meson8b.c
> index 2c4ff6192852..d0524ec71aad 100644
> --- a/drivers/clk/meson/meson8b.c
> +++ b/drivers/clk/meson/meson8b.c
> @@ -632,7 +632,8 @@ static struct clk_regmap meson8b_cpu_clk = {
> .hw.init = &(struct clk_init_data){
> .name = "cpu_clk",
> .ops = &clk_regmap_mux_ro_ops,
> - .parent_names = (const char *[]){ "xtal", "cpu_out_sel" },
> + .parent_names = (const char *[]){ "xtal",
> + "cpu_scale_out_sel" },
> .num_parents = 2,
> .flags = (CLK_SET_RATE_PARENT |
> CLK_SET_RATE_NO_REPARENT),
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-04-23 19:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-23 19:30 [PATCH clk-fixes] clk: meson: meson8b: fix meson8b_cpu_clk parent clock name Martin Blumenstingl
2018-04-23 19:41 ` Jerome Brunet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®