mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: sboyd@kernel.org (Stephen Boyd)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v6 1/3] clk: meson: add emmc sub clock phase delay driver
Date: Sat, 03 Nov 2018 20:02:43 -0700	[thread overview]
Message-ID: <154130056376.88331.17004780065573288593@swboyd.mtv.corp.google.com> (raw)
In-Reply-To: <1541089855-19356-2-git-send-email-jianxin.pan@amlogic.com>

Quoting Jianxin Pan (2018-11-01 09:30:53)
> diff --git a/drivers/clk/meson/clk-phase-delay.c b/drivers/clk/meson/clk-phase-delay.c
> new file mode 100644
> index 0000000..83e74ed
> --- /dev/null
> +++ b/drivers/clk/meson/clk-phase-delay.c
> @@ -0,0 +1,66 @@
> +// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
> +/*
> + * Amlogic Meson MMC Sub Clock Controller Driver
> + *
> + * Copyright (c) 2017 Baylibre SAS.
> + * Author: Jerome Brunet <jbrunet@baylibre.com>
> + *
> + * Copyright (c) 2018 Amlogic, inc.
> + * Author: Yixun Lan <yixun.lan@amlogic.com>
> + * Author: Jianxin Pan <jianxin.pan@amlogic.com>
> + */
> +
> +#include <linux/clk-provider.h>
> +#include "clkc.h"
> +
> +static int meson_clk_phase_delay_get_phase(struct clk_hw *hw)
> +{
> +       struct clk_regmap *clk = to_clk_regmap(hw);
> +       struct meson_clk_phase_delay_data *ph =
> +               meson_clk_get_phase_delay_data(clk);

Nitpick: Do this after declaring variables because it splits a line.

> +       unsigned long period_ps, p, d;
> +       int degrees;
> +
> +       p = meson_parm_read(clk->map, &ph->phase);
> +       degrees = p * 360 / (1 << (ph->phase.width));

Nitpick: Remove useless parenthesis.

> +
> +       period_ps = DIV_ROUND_UP((unsigned long)NSEC_PER_SEC * 1000,

Is the cast necessary?

> +                                clk_hw_get_rate(hw));
> +
> +       d = meson_parm_read(clk->map, &ph->delay);
> +       degrees += d * ph->delay_step_ps * 360 / period_ps;
> +       degrees %= 360;
> +
> +       return degrees;
> +}
> +
> +static int meson_clk_phase_delay_set_phase(struct clk_hw *hw, int degrees)
> +{
> +       struct clk_regmap *clk = to_clk_regmap(hw);
> +       struct meson_clk_phase_delay_data *ph =
> +               meson_clk_get_phase_delay_data(clk);
> +       unsigned long period_ps, d = 0, r;
> +       u64 p;
> +
> +       p = degrees % 360;

We don't allow phase to be larger than 360 so this isn't needed.

> +       period_ps = DIV_ROUND_UP((unsigned long)NSEC_PER_SEC * 1000,

Drop the cast?

> +                                clk_hw_get_rate(hw));
> +
> +       /* First compute the phase index (p), the remainder (r) is the

Nitpick: Please leave /* on it's own line.

> +        * part we'll try to acheive using the delays (d).
> +        */
> +       r = do_div(p, 360 / (1 << (ph->phase.width)));

Drop useless parenthesis please.

> +       d = DIV_ROUND_CLOSEST(r * period_ps,
> +                             360 * ph->delay_step_ps);
> +       d = min(d, PMASK(ph->delay.width));
> +
> +       meson_parm_write(clk->map, &ph->phase, p);
> +       meson_parm_write(clk->map, &ph->delay, d);
> +       return 0;
> +}

  reply	other threads:[~2018-11-04  3:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-11-01 16:30 [PATCH v6 0/3] clk: meson: add a sub EMMC clock controller support Jianxin Pan
2018-11-01 16:30 ` [PATCH v6 1/3] clk: meson: add emmc sub clock phase delay driver Jianxin Pan
2018-11-04  3:02   ` Stephen Boyd [this message]
2018-11-04 15:12     ` Jianxin Pan
2018-11-01 16:30 ` [PATCH v6 2/3] clk: meson: add DT documentation for emmc clock controller Jianxin Pan
2018-11-01 16:30 ` [PATCH v6 3/3] clk: meson: add sub MMC clock controller driver Jianxin Pan
2018-11-01 18:16   ` Martin Blumenstingl
2018-11-03  7:29     ` Jianxin Pan
2018-11-02 13:05   ` jbrunet at baylibre.com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=154130056376.88331.17004780065573288593@swboyd.mtv.corp.google.com \
    --to=sboyd@kernel.org \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®