* [PATCH] soc: amlogic: replace devm_reset_control_array_get()
@ 2020-11-18 2:48 Yejune Deng
2020-11-18 14:55 ` Philipp Zabel
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Yejune Deng @ 2020-11-18 2:48 UTC (permalink / raw)
To: khilman, narmstrong, jbrunet, martin.blumenstingl, p.zabel
Cc: linux-amlogic, linux-kernel, linux-arm-kernel, yejune.deng
devm_reset_control_array_get_exclusive() looks more readable
Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
---
drivers/soc/amlogic/meson-ee-pwrc.c | 3 +--
drivers/soc/amlogic/meson-gx-pwrc-vpu.c | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/drivers/soc/amlogic/meson-ee-pwrc.c b/drivers/soc/amlogic/meson-ee-pwrc.c
index ed7d2fb..50bf5d2 100644
--- a/drivers/soc/amlogic/meson-ee-pwrc.c
+++ b/drivers/soc/amlogic/meson-ee-pwrc.c
@@ -413,8 +413,7 @@ static int meson_ee_pwrc_init_domain(struct platform_device *pdev,
dev_warn(&pdev->dev, "Invalid resets count %d for domain %s\n",
count, dom->desc.name);
- dom->rstc = devm_reset_control_array_get(&pdev->dev, false,
- false);
+ dom->rstc = devm_reset_control_array_get_exclusive(&pdev->dev);
if (IS_ERR(dom->rstc))
return PTR_ERR(dom->rstc);
}
diff --git a/drivers/soc/amlogic/meson-gx-pwrc-vpu.c b/drivers/soc/amlogic/meson-gx-pwrc-vpu.c
index 8790627..b4615b2 100644
--- a/drivers/soc/amlogic/meson-gx-pwrc-vpu.c
+++ b/drivers/soc/amlogic/meson-gx-pwrc-vpu.c
@@ -304,7 +304,7 @@ static int meson_gx_pwrc_vpu_probe(struct platform_device *pdev)
return PTR_ERR(regmap_hhi);
}
- rstc = devm_reset_control_array_get(&pdev->dev, false, false);
+ rstc = devm_reset_control_array_get_exclusive(&pdev->dev);
if (IS_ERR(rstc)) {
if (PTR_ERR(rstc) != -EPROBE_DEFER)
dev_err(&pdev->dev, "failed to get reset lines\n");
--
1.9.1
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] soc: amlogic: replace devm_reset_control_array_get()
2020-11-18 2:48 [PATCH] soc: amlogic: replace devm_reset_control_array_get() Yejune Deng
@ 2020-11-18 14:55 ` Philipp Zabel
2020-11-22 21:55 ` Martin Blumenstingl
2020-12-01 0:03 ` Kevin Hilman
2 siblings, 0 replies; 4+ messages in thread
From: Philipp Zabel @ 2020-11-18 14:55 UTC (permalink / raw)
To: Yejune Deng, khilman, narmstrong, jbrunet, martin.blumenstingl
Cc: linux-amlogic, linux-kernel, linux-arm-kernel
Hi Yejune,
On Wed, 2020-11-18 at 10:48 +0800, Yejune Deng wrote:
> devm_reset_control_array_get_exclusive() looks more readable
>
> Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
> ---
> drivers/soc/amlogic/meson-ee-pwrc.c | 3 +--
> drivers/soc/amlogic/meson-gx-pwrc-vpu.c | 2 +-
> 2 files changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/soc/amlogic/meson-ee-pwrc.c b/drivers/soc/amlogic/meson-ee-pwrc.c
> index ed7d2fb..50bf5d2 100644
> --- a/drivers/soc/amlogic/meson-ee-pwrc.c
> +++ b/drivers/soc/amlogic/meson-ee-pwrc.c
> @@ -413,8 +413,7 @@ static int meson_ee_pwrc_init_domain(struct platform_device *pdev,
> dev_warn(&pdev->dev, "Invalid resets count %d for domain %s\n",
> count, dom->desc.name);
>
> - dom->rstc = devm_reset_control_array_get(&pdev->dev, false,
> - false);
> + dom->rstc = devm_reset_control_array_get_exclusive(&pdev->dev);
> if (IS_ERR(dom->rstc))
> return PTR_ERR(dom->rstc);
> }
> diff --git a/drivers/soc/amlogic/meson-gx-pwrc-vpu.c b/drivers/soc/amlogic/meson-gx-pwrc-vpu.c
> index 8790627..b4615b2 100644
> --- a/drivers/soc/amlogic/meson-gx-pwrc-vpu.c
> +++ b/drivers/soc/amlogic/meson-gx-pwrc-vpu.c
> @@ -304,7 +304,7 @@ static int meson_gx_pwrc_vpu_probe(struct platform_device *pdev)
> return PTR_ERR(regmap_hhi);
> }
>
> - rstc = devm_reset_control_array_get(&pdev->dev, false, false);
> + rstc = devm_reset_control_array_get_exclusive(&pdev->dev);
> if (IS_ERR(rstc)) {
> if (PTR_ERR(rstc) != -EPROBE_DEFER)
> dev_err(&pdev->dev, "failed to get reset lines\n");
Reviewed-by: Philipp Zabel <p.zabel@pengutronix.de>
regards
Philipp
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] soc: amlogic: replace devm_reset_control_array_get()
2020-11-18 2:48 [PATCH] soc: amlogic: replace devm_reset_control_array_get() Yejune Deng
2020-11-18 14:55 ` Philipp Zabel
@ 2020-11-22 21:55 ` Martin Blumenstingl
2020-12-01 0:03 ` Kevin Hilman
2 siblings, 0 replies; 4+ messages in thread
From: Martin Blumenstingl @ 2020-11-22 21:55 UTC (permalink / raw)
To: Yejune Deng
Cc: Neil Armstrong, khilman, linux-kernel, p.zabel, linux-amlogic,
linux-arm-kernel, jbrunet
On Wed, Nov 18, 2020 at 3:48 AM Yejune Deng <yejune.deng@gmail.com> wrote:
>
> devm_reset_control_array_get_exclusive() looks more readable
>
> Signed-off-by: Yejune Deng <yejune.deng@gmail.com>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] soc: amlogic: replace devm_reset_control_array_get()
2020-11-18 2:48 [PATCH] soc: amlogic: replace devm_reset_control_array_get() Yejune Deng
2020-11-18 14:55 ` Philipp Zabel
2020-11-22 21:55 ` Martin Blumenstingl
@ 2020-12-01 0:03 ` Kevin Hilman
2 siblings, 0 replies; 4+ messages in thread
From: Kevin Hilman @ 2020-12-01 0:03 UTC (permalink / raw)
To: Yejune Deng, jbrunet, p.zabel, narmstrong, martin.blumenstingl
Cc: linux-amlogic, linux-kernel, linux-arm-kernel
On Wed, 18 Nov 2020 10:48:20 +0800, Yejune Deng wrote:
> devm_reset_control_array_get_exclusive() looks more readable
Applied, thanks!
[1/1] soc: amlogic: replace devm_reset_control_array_get()
commit: 978d0dbb98c7ce9a5d6897744ac49ac5ff85831e
Best regards,
--
Kevin Hilman <khilman@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-12-01 0:04 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-18 2:48 [PATCH] soc: amlogic: replace devm_reset_control_array_get() Yejune Deng
2020-11-18 14:55 ` Philipp Zabel
2020-11-22 21:55 ` Martin Blumenstingl
2020-12-01 0:03 ` Kevin Hilman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®