mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: webczat@webczatnet.pl (Michał Zegan)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 2/2] mmc: meson-gx: remove mmc host on device removal
Date: Fri, 17 Feb 2017 20:50:55 +0100	[thread overview]
Message-ID: <171193cd-e82d-695a-22b3-c10d670baad7@webczatnet.pl> (raw)
In-Reply-To: <m2fujc61mu.fsf@baylibre.com>



W dniu 17.02.2017 o 20:47, Kevin Hilman pisze:
> Micha? Zegan <webczat@webczatnet.pl> writes:
>
>> The mmc host was added in meson_mmc_probe, but never removed in meson_mmc_remove.
>> Fix that by removing the host before deallocating other resources.
>>
>> Signed-off-by: Micha? Zegan <webczat@webczatnet.pl>
> Reviewed-by: Kevin Hilman <khilman@baylibre.com>
I do not know how the mmc driver looks like after Heiner's cleanup. Does
this patch get obsoleted by the prior cleanup, or conflict with it in
some way?
>
>> ---
>>  drivers/mmc/host/meson-gx-mmc.c | 2 ++
>>  1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/mmc/host/meson-gx-mmc.c b/drivers/mmc/host/meson-gx-mmc.c
>> index d444b6bfa02b..bb83446118a3 100644
>> --- a/drivers/mmc/host/meson-gx-mmc.c
>> +++ b/drivers/mmc/host/meson-gx-mmc.c
>> @@ -818,6 +818,8 @@ static int meson_mmc_remove(struct platform_device *pdev)
>>  	if (WARN_ON(!host))
>>  		return 0;
>>  
>> +	mmc_remove_host(host->mmc);
>> +
>>  	if (host->bounce_buf)
>>  		dma_free_coherent(host->dev, host->bounce_buf_size,
>>  				  host->bounce_buf, host->bounce_dma_addr);

  reply	other threads:[~2017-02-17 19:50 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-16 14:52 [PATCH 0/2] mmc: meson-gx: fix module unloading Michał Zegan
2017-02-16 14:52 ` [PATCH 1/2] mmc: meson-gx: prevent cfg_div_clk from being disabled on init Michał Zegan
2017-02-17 19:44   ` Kevin Hilman
2017-02-17 19:49     ` Michał Zegan
2017-02-16 14:52 ` [PATCH 2/2] mmc: meson-gx: remove mmc host on device removal Michał Zegan
2017-02-17 19:47   ` Kevin Hilman
2017-02-17 19:50     ` Michał Zegan [this message]
2017-02-17 23:03       ` Kevin Hilman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=171193cd-e82d-695a-22b3-c10d670baad7@webczatnet.pl \
    --to=webczat@webczatnet.pl \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®