From: webczat@webczatnet.pl (Michał Zegan)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 1/2] mmc: meson-gx: prevent cfg_div_clk from being disabled on init
Date: Fri, 17 Feb 2017 20:49:23 +0100 [thread overview]
Message-ID: <a7ea0b57-efa0-58a5-92d5-8bc97f357f4c@webczatnet.pl> (raw)
In-Reply-To: <m2k28o61qj.fsf@baylibre.com>
W dniu 17.02.2017 o 20:44, Kevin Hilman pisze:
> Micha? Zegan <webczat@webczatnet.pl> writes:
>
>> At the end of function meson_mmc_clk_init, the cfg_div clock was
>> prepared, enabled and configured, but then immediately disabled due to bogus if statements.
>> That made later calls to clk_disable_unprepare executed during module removal to fail with a kernel warning.
>> Fix that by changing the code to disable clock only when it failed to be configured.
>>
>> Signed-off-by: Micha? Zegan <webczat@webczatnet.pl>
> I believe this one is not needed any more after Heiner's cleanups?
I think it is not needed, yes.
>
> Kevin
next prev parent reply other threads:[~2017-02-17 19:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-16 14:52 [PATCH 0/2] mmc: meson-gx: fix module unloading Michał Zegan
2017-02-16 14:52 ` [PATCH 1/2] mmc: meson-gx: prevent cfg_div_clk from being disabled on init Michał Zegan
2017-02-17 19:44 ` Kevin Hilman
2017-02-17 19:49 ` Michał Zegan [this message]
2017-02-16 14:52 ` [PATCH 2/2] mmc: meson-gx: remove mmc host on device removal Michał Zegan
2017-02-17 19:47 ` Kevin Hilman
2017-02-17 19:50 ` Michał Zegan
2017-02-17 23:03 ` Kevin Hilman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=a7ea0b57-efa0-58a5-92d5-8bc97f357f4c@webczatnet.pl \
--to=webczat@webczatnet.pl \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®