From: Jerome Brunet <jbrunet@baylibre.com>
To: Anand Moon <linux.amoon@gmail.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: devicetree <devicetree@vger.kernel.org>,
Neil Armstrong <narmstrong@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Christian Hewitt <christianshewitt@gmail.com>,
Rob Herring <robh+dt@kernel.org>,
linux-amlogic@lists.infradead.org,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH v2 1/3] arm64: dts: meson-g12b-odroid-n2: Enable RTC controller node
Date: Tue, 18 Aug 2020 09:43:01 +0200 [thread overview]
Message-ID: <1j1rk4flh6.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <CANAwSgTq+4KQJJLJPxV+afAYiqfpJ_JvwdJHn4sf5NVJgedbUQ@mail.gmail.com>
>> > >
>> > > +&i2c3 {
>> > > + pinctrl-0 = <&i2c3_sda_a_pins>, <&i2c3_sck_a_pins>;
>> > > + pinctrl-1 = <&tdm_c_din3_a_pins>;
>
> Note: without setting this *pinctrl-1* configuration RTC wake up
> feature works as expected.
As pointed out by Martin, the pinctrl-1 here makes no sense for RTC on
i2c. If the rtc is on an I2C of AO bank, the pinctrl-0 is likely to be
wrong as well.
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2020-08-18 7:43 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 10:21 [PATCH v2 0/3] Enable RTC on Odroid N2 Anand Moon
2020-08-17 10:21 ` [PATCH v2 1/3] arm64: dts: meson-g12b-odroid-n2: Enable RTC controller node Anand Moon
2020-08-17 19:35 ` Martin Blumenstingl
2020-08-18 3:03 ` Anand Moon
2020-08-18 5:10 ` Anand Moon
2020-08-18 7:43 ` Jerome Brunet [this message]
2020-08-18 10:25 ` Anand Moon
2020-08-17 10:21 ` [PATCH v2 2/3] arm64: dts: meson-g12b-odroid-n2: Disable virtual RTC driver Anand Moon
2020-08-18 7:45 ` Jerome Brunet
2020-08-18 7:51 ` Christian Hewitt
2020-08-18 8:15 ` Anand Moon
2020-08-17 10:21 ` [PATCH v2 3/3] arm64: defconfig: Enable RTC devices for Amlogic boards Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1j1rk4flh6.fsf@starbuckisacylon.baylibre.com \
--to=jbrunet@baylibre.com \
--cc=christianshewitt@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux.amoon@gmail.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®