From: Jerome Brunet <jbrunet@baylibre.com>
To: Anand Moon <linux.amoon@gmail.com>,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org
Cc: Martin Blumenstingl <martin.blumenstingl@googlemail.com>,
Kevin Hilman <khilman@baylibre.com>,
Rob Herring <robh+dt@kernel.org>,
Christian Hewitt <christianshewitt@gmail.com>,
Neil Armstrong <narmstrong@baylibre.com>
Subject: Re: [PATCH v2 2/3] arm64: dts: meson-g12b-odroid-n2: Disable virtual RTC driver
Date: Tue, 18 Aug 2020 09:45:01 +0200 [thread overview]
Message-ID: <1jzh6se6te.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <20200817102122.434-3-linux.amoon@gmail.com>
On Mon 17 Aug 2020 at 12:21, Anand Moon <linux.amoon@gmail.com> wrote:
> Disable virtual RTC node on Odroid N2,
> since RTC PCF8563 support rtc wakeup.
>
> [ 7.171149] meson-vrtc ff8000a8.rtc: registered as rtc0
> [ 7.182875] meson-vrtc ff8000a8.rtc: setting system clock to 1970-01-01T00:00:07 UTC (7)
>
Maybe I'm missing something but why should disable this ?
Can't the 2 RTCs co-exist ?
> Cc: Neil Armstrong <narmstrong@baylibre.com>
> Cc: Kevin Hilman <khilman@baylibre.com>
> Signed-off-by: Anand Moon <linux.amoon@gmail.com>
> ---
> Changes v2
> --Fix the subject and commit message.
> ---
> arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> index f08ae1b337ad..7fb952a2a35e 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12b-odroid-n2.dts
> @@ -642,3 +642,7 @@ &usb2_phy1 {
> /* Enable the hub which is connected to this port */
> phy-supply = <&hub_5v>;
> };
> +
> +&vrtc {
> + status = "disabled";
> +};
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2020-08-18 7:45 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-17 10:21 [PATCH v2 0/3] Enable RTC on Odroid N2 Anand Moon
2020-08-17 10:21 ` [PATCH v2 1/3] arm64: dts: meson-g12b-odroid-n2: Enable RTC controller node Anand Moon
2020-08-17 19:35 ` Martin Blumenstingl
2020-08-18 3:03 ` Anand Moon
2020-08-18 5:10 ` Anand Moon
2020-08-18 7:43 ` Jerome Brunet
2020-08-18 10:25 ` Anand Moon
2020-08-17 10:21 ` [PATCH v2 2/3] arm64: dts: meson-g12b-odroid-n2: Disable virtual RTC driver Anand Moon
2020-08-18 7:45 ` Jerome Brunet [this message]
2020-08-18 7:51 ` Christian Hewitt
2020-08-18 8:15 ` Anand Moon
2020-08-17 10:21 ` [PATCH v2 3/3] arm64: defconfig: Enable RTC devices for Amlogic boards Anand Moon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1jzh6se6te.fsf@starbuckisacylon.baylibre.com \
--to=jbrunet@baylibre.com \
--cc=christianshewitt@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux.amoon@gmail.com \
--cc=martin.blumenstingl@googlemail.com \
--cc=narmstrong@baylibre.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®