* [PATCH 0/6] clk: meson: Delete a meaningless spinlock from the MPLL
@ 2024-09-20 8:16 Chuan Liu via B4 Relay
2024-09-20 8:16 ` [PATCH 1/6] clk: meson: mpll: " Chuan Liu via B4 Relay
` (6 more replies)
0 siblings, 7 replies; 9+ messages in thread
From: Chuan Liu via B4 Relay @ 2024-09-20 8:16 UTC (permalink / raw)
To: Neil Armstrong, Jerome Brunet, Michael Turquette, Stephen Boyd,
Kevin Hilman, Martin Blumenstingl
Cc: linux-amlogic, linux-clk, linux-arm-kernel, linux-kernel, Chuan Liu
The existing locking mechanism of CCF can effectively avoid concurrent
register access. struct meson_clk_mpll_data has no meaning in defining
a spinlock repeatedly.
In addition, the register corresponding to MPLL does not share the same
register with other module drivers, so there is no concurrent access to
the register with other modules drivers.
Every driver file with mpll defines a spinlock with the same name (even
if defined as "static"), giving the illusion of repeated definitions?
Signed-off-by: Chuan Liu <chuan.liu@amlogic.com>
---
Chuan Liu (6):
clk: meson: mpll: Delete a meaningless spinlock from the MPLL
clk: meson: axg: Delete the spinlock from the MPLL
clk: meson: meson8b: Delete the spinlock from the MPLL
clk: meson: gxbb: Delete the spinlock from the MPLL
clk: meson: g12a: Delete the spinlock from the MPLL
clk: meson: s4: Delete the spinlock from the MPLL
drivers/clk/meson/axg.c | 6 ------
drivers/clk/meson/clk-mpll.c | 11 -----------
drivers/clk/meson/clk-mpll.h | 1 -
drivers/clk/meson/g12a.c | 6 ------
drivers/clk/meson/gxbb.c | 6 ------
drivers/clk/meson/meson8b.c | 3 ---
drivers/clk/meson/s4-pll.c | 6 ------
7 files changed, 39 deletions(-)
---
base-commit: 0ef513560b53d499c824b77220c537eafe1df90d
change-id: 20240918-mpll_spinlock-4b9b55c44fd5
Best regards,
--
Chuan Liu <chuan.liu@amlogic.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 1/6] clk: meson: mpll: Delete a meaningless spinlock from the MPLL
2024-09-20 8:16 [PATCH 0/6] clk: meson: Delete a meaningless spinlock from the MPLL Chuan Liu via B4 Relay
@ 2024-09-20 8:16 ` Chuan Liu via B4 Relay
2024-09-20 8:16 ` [PATCH 2/6] clk: meson: axg: Delete the " Chuan Liu via B4 Relay
` (5 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Chuan Liu via B4 Relay @ 2024-09-20 8:16 UTC (permalink / raw)
To: Neil Armstrong, Jerome Brunet, Michael Turquette, Stephen Boyd,
Kevin Hilman, Martin Blumenstingl
Cc: linux-amlogic, linux-clk, linux-arm-kernel, linux-kernel, Chuan Liu
From: Chuan Liu <chuan.liu@amlogic.com>
The existing locking mechanism of CCF can effectively avoid concurrent
register access. struct meson_clk_mpll_data has no meaning in defining
a spinlock repeatedly.
Signed-off-by: Chuan Liu <chuan.liu@amlogic.com>
---
drivers/clk/meson/clk-mpll.c | 11 -----------
drivers/clk/meson/clk-mpll.h | 1 -
2 files changed, 12 deletions(-)
diff --git a/drivers/clk/meson/clk-mpll.c b/drivers/clk/meson/clk-mpll.c
index f639d56f0fd3..aa9abd06ae65 100644
--- a/drivers/clk/meson/clk-mpll.c
+++ b/drivers/clk/meson/clk-mpll.c
@@ -112,26 +112,15 @@ static int mpll_set_rate(struct clk_hw *hw,
struct clk_regmap *clk = to_clk_regmap(hw);
struct meson_clk_mpll_data *mpll = meson_clk_mpll_data(clk);
unsigned int sdm, n2;
- unsigned long flags = 0;
params_from_rate(rate, parent_rate, &sdm, &n2, mpll->flags);
- if (mpll->lock)
- spin_lock_irqsave(mpll->lock, flags);
- else
- __acquire(mpll->lock);
-
/* Set the fractional part */
meson_parm_write(clk->map, &mpll->sdm, sdm);
/* Set the integer divider part */
meson_parm_write(clk->map, &mpll->n2, n2);
- if (mpll->lock)
- spin_unlock_irqrestore(mpll->lock, flags);
- else
- __release(mpll->lock);
-
return 0;
}
diff --git a/drivers/clk/meson/clk-mpll.h b/drivers/clk/meson/clk-mpll.h
index a991d568c43a..4ffd3aeef799 100644
--- a/drivers/clk/meson/clk-mpll.h
+++ b/drivers/clk/meson/clk-mpll.h
@@ -20,7 +20,6 @@ struct meson_clk_mpll_data {
struct parm misc;
const struct reg_sequence *init_regs;
unsigned int init_count;
- spinlock_t *lock;
u8 flags;
};
--
2.42.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 2/6] clk: meson: axg: Delete the spinlock from the MPLL
2024-09-20 8:16 [PATCH 0/6] clk: meson: Delete a meaningless spinlock from the MPLL Chuan Liu via B4 Relay
2024-09-20 8:16 ` [PATCH 1/6] clk: meson: mpll: " Chuan Liu via B4 Relay
@ 2024-09-20 8:16 ` Chuan Liu via B4 Relay
2024-09-20 8:16 ` [PATCH 3/6] clk: meson: meson8b: " Chuan Liu via B4 Relay
` (4 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Chuan Liu via B4 Relay @ 2024-09-20 8:16 UTC (permalink / raw)
To: Neil Armstrong, Jerome Brunet, Michael Turquette, Stephen Boyd,
Kevin Hilman, Martin Blumenstingl
Cc: linux-amlogic, linux-clk, linux-arm-kernel, linux-kernel, Chuan Liu
From: Chuan Liu <chuan.liu@amlogic.com>
It is meaningless to define a spinlock in the struct meson_clk_mpll_data.
Signed-off-by: Chuan Liu <chuan.liu@amlogic.com>
---
drivers/clk/meson/axg.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/clk/meson/axg.c b/drivers/clk/meson/axg.c
index 757c7a28c53d..1b08daf579b2 100644
--- a/drivers/clk/meson/axg.c
+++ b/drivers/clk/meson/axg.c
@@ -23,8 +23,6 @@
#include <dt-bindings/clock/axg-clkc.h>
-static DEFINE_SPINLOCK(meson_clk_lock);
-
static struct clk_regmap axg_fixed_pll_dco = {
.data = &(struct meson_clk_pll_data){
.en = {
@@ -506,7 +504,6 @@ static struct clk_regmap axg_mpll0_div = {
.shift = 0,
.width = 1,
},
- .lock = &meson_clk_lock,
.flags = CLK_MESON_MPLL_ROUND_CLOSEST,
},
.hw.init = &(struct clk_init_data){
@@ -557,7 +554,6 @@ static struct clk_regmap axg_mpll1_div = {
.shift = 1,
.width = 1,
},
- .lock = &meson_clk_lock,
.flags = CLK_MESON_MPLL_ROUND_CLOSEST,
},
.hw.init = &(struct clk_init_data){
@@ -613,7 +609,6 @@ static struct clk_regmap axg_mpll2_div = {
.shift = 2,
.width = 1,
},
- .lock = &meson_clk_lock,
.flags = CLK_MESON_MPLL_ROUND_CLOSEST,
},
.hw.init = &(struct clk_init_data){
@@ -664,7 +659,6 @@ static struct clk_regmap axg_mpll3_div = {
.shift = 3,
.width = 1,
},
- .lock = &meson_clk_lock,
.flags = CLK_MESON_MPLL_ROUND_CLOSEST,
},
.hw.init = &(struct clk_init_data){
--
2.42.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 3/6] clk: meson: meson8b: Delete the spinlock from the MPLL
2024-09-20 8:16 [PATCH 0/6] clk: meson: Delete a meaningless spinlock from the MPLL Chuan Liu via B4 Relay
2024-09-20 8:16 ` [PATCH 1/6] clk: meson: mpll: " Chuan Liu via B4 Relay
2024-09-20 8:16 ` [PATCH 2/6] clk: meson: axg: Delete the " Chuan Liu via B4 Relay
@ 2024-09-20 8:16 ` Chuan Liu via B4 Relay
2024-09-20 8:16 ` [PATCH 4/6] clk: meson: gxbb: " Chuan Liu via B4 Relay
` (3 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Chuan Liu via B4 Relay @ 2024-09-20 8:16 UTC (permalink / raw)
To: Neil Armstrong, Jerome Brunet, Michael Turquette, Stephen Boyd,
Kevin Hilman, Martin Blumenstingl
Cc: linux-amlogic, linux-clk, linux-arm-kernel, linux-kernel, Chuan Liu
From: Chuan Liu <chuan.liu@amlogic.com>
It is meaningless to define a spinlock in the struct meson_clk_mpll_data.
Signed-off-by: Chuan Liu <chuan.liu@amlogic.com>
---
drivers/clk/meson/meson8b.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/clk/meson/meson8b.c b/drivers/clk/meson/meson8b.c
index b7417ac262d3..5011768c0f4e 100644
--- a/drivers/clk/meson/meson8b.c
+++ b/drivers/clk/meson/meson8b.c
@@ -492,7 +492,6 @@ static struct clk_regmap meson8b_mpll0_div = {
.shift = 25,
.width = 1,
},
- .lock = &meson_clk_lock,
},
.hw.init = &(struct clk_init_data){
.name = "mpll0_div",
@@ -537,7 +536,6 @@ static struct clk_regmap meson8b_mpll1_div = {
.shift = 16,
.width = 9,
},
- .lock = &meson_clk_lock,
},
.hw.init = &(struct clk_init_data){
.name = "mpll1_div",
@@ -582,7 +580,6 @@ static struct clk_regmap meson8b_mpll2_div = {
.shift = 16,
.width = 9,
},
- .lock = &meson_clk_lock,
},
.hw.init = &(struct clk_init_data){
.name = "mpll2_div",
--
2.42.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 4/6] clk: meson: gxbb: Delete the spinlock from the MPLL
2024-09-20 8:16 [PATCH 0/6] clk: meson: Delete a meaningless spinlock from the MPLL Chuan Liu via B4 Relay
` (2 preceding siblings ...)
2024-09-20 8:16 ` [PATCH 3/6] clk: meson: meson8b: " Chuan Liu via B4 Relay
@ 2024-09-20 8:16 ` Chuan Liu via B4 Relay
2024-09-20 8:16 ` [PATCH 5/6] clk: meson: g12a: " Chuan Liu via B4 Relay
` (2 subsequent siblings)
6 siblings, 0 replies; 9+ messages in thread
From: Chuan Liu via B4 Relay @ 2024-09-20 8:16 UTC (permalink / raw)
To: Neil Armstrong, Jerome Brunet, Michael Turquette, Stephen Boyd,
Kevin Hilman, Martin Blumenstingl
Cc: linux-amlogic, linux-clk, linux-arm-kernel, linux-kernel, Chuan Liu
From: Chuan Liu <chuan.liu@amlogic.com>
It is meaningless to define a spinlock in the struct meson_clk_mpll_data.
Signed-off-by: Chuan Liu <chuan.liu@amlogic.com>
---
drivers/clk/meson/gxbb.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/clk/meson/gxbb.c b/drivers/clk/meson/gxbb.c
index f071faad1ebb..262c318edbd5 100644
--- a/drivers/clk/meson/gxbb.c
+++ b/drivers/clk/meson/gxbb.c
@@ -19,8 +19,6 @@
#include <dt-bindings/clock/gxbb-clkc.h>
-static DEFINE_SPINLOCK(meson_clk_lock);
-
static const struct pll_params_table gxbb_gp0_pll_params_table[] = {
PLL_PARAMS(32, 1),
PLL_PARAMS(33, 1),
@@ -731,7 +729,6 @@ static struct clk_regmap gxbb_mpll0_div = {
.shift = 16,
.width = 9,
},
- .lock = &meson_clk_lock,
},
.hw.init = &(struct clk_init_data){
.name = "mpll0_div",
@@ -760,7 +757,6 @@ static struct clk_regmap gxl_mpll0_div = {
.shift = 16,
.width = 9,
},
- .lock = &meson_clk_lock,
},
.hw.init = &(struct clk_init_data){
.name = "mpll0_div",
@@ -812,7 +808,6 @@ static struct clk_regmap gxbb_mpll1_div = {
.shift = 16,
.width = 9,
},
- .lock = &meson_clk_lock,
},
.hw.init = &(struct clk_init_data){
.name = "mpll1_div",
@@ -855,7 +850,6 @@ static struct clk_regmap gxbb_mpll2_div = {
.shift = 16,
.width = 9,
},
- .lock = &meson_clk_lock,
},
.hw.init = &(struct clk_init_data){
.name = "mpll2_div",
--
2.42.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 5/6] clk: meson: g12a: Delete the spinlock from the MPLL
2024-09-20 8:16 [PATCH 0/6] clk: meson: Delete a meaningless spinlock from the MPLL Chuan Liu via B4 Relay
` (3 preceding siblings ...)
2024-09-20 8:16 ` [PATCH 4/6] clk: meson: gxbb: " Chuan Liu via B4 Relay
@ 2024-09-20 8:16 ` Chuan Liu via B4 Relay
2024-09-20 8:16 ` [PATCH 6/6] clk: meson: s4: " Chuan Liu via B4 Relay
2024-09-24 8:35 ` [PATCH 0/6] clk: meson: Delete a meaningless " Jerome Brunet
6 siblings, 0 replies; 9+ messages in thread
From: Chuan Liu via B4 Relay @ 2024-09-20 8:16 UTC (permalink / raw)
To: Neil Armstrong, Jerome Brunet, Michael Turquette, Stephen Boyd,
Kevin Hilman, Martin Blumenstingl
Cc: linux-amlogic, linux-clk, linux-arm-kernel, linux-kernel, Chuan Liu
From: Chuan Liu <chuan.liu@amlogic.com>
It is meaningless to define a spinlock in the struct meson_clk_mpll_data.
Signed-off-by: Chuan Liu <chuan.liu@amlogic.com>
---
drivers/clk/meson/g12a.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/clk/meson/g12a.c b/drivers/clk/meson/g12a.c
index 02dda57105b1..d3539fe9f7af 100644
--- a/drivers/clk/meson/g12a.c
+++ b/drivers/clk/meson/g12a.c
@@ -28,8 +28,6 @@
#include <dt-bindings/clock/g12a-clkc.h>
-static DEFINE_SPINLOCK(meson_clk_lock);
-
static struct clk_regmap g12a_fixed_pll_dco = {
.data = &(struct meson_clk_pll_data){
.en = {
@@ -2225,7 +2223,6 @@ static struct clk_regmap g12a_mpll0_div = {
.shift = 29,
.width = 1,
},
- .lock = &meson_clk_lock,
.init_regs = g12a_mpll0_init_regs,
.init_count = ARRAY_SIZE(g12a_mpll0_init_regs),
},
@@ -2279,7 +2276,6 @@ static struct clk_regmap g12a_mpll1_div = {
.shift = 29,
.width = 1,
},
- .lock = &meson_clk_lock,
.init_regs = g12a_mpll1_init_regs,
.init_count = ARRAY_SIZE(g12a_mpll1_init_regs),
},
@@ -2333,7 +2329,6 @@ static struct clk_regmap g12a_mpll2_div = {
.shift = 29,
.width = 1,
},
- .lock = &meson_clk_lock,
.init_regs = g12a_mpll2_init_regs,
.init_count = ARRAY_SIZE(g12a_mpll2_init_regs),
},
@@ -2387,7 +2382,6 @@ static struct clk_regmap g12a_mpll3_div = {
.shift = 29,
.width = 1,
},
- .lock = &meson_clk_lock,
.init_regs = g12a_mpll3_init_regs,
.init_count = ARRAY_SIZE(g12a_mpll3_init_regs),
},
--
2.42.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 9+ messages in thread
* [PATCH 6/6] clk: meson: s4: Delete the spinlock from the MPLL
2024-09-20 8:16 [PATCH 0/6] clk: meson: Delete a meaningless spinlock from the MPLL Chuan Liu via B4 Relay
` (4 preceding siblings ...)
2024-09-20 8:16 ` [PATCH 5/6] clk: meson: g12a: " Chuan Liu via B4 Relay
@ 2024-09-20 8:16 ` Chuan Liu via B4 Relay
2024-09-24 8:35 ` [PATCH 0/6] clk: meson: Delete a meaningless " Jerome Brunet
6 siblings, 0 replies; 9+ messages in thread
From: Chuan Liu via B4 Relay @ 2024-09-20 8:16 UTC (permalink / raw)
To: Neil Armstrong, Jerome Brunet, Michael Turquette, Stephen Boyd,
Kevin Hilman, Martin Blumenstingl
Cc: linux-amlogic, linux-clk, linux-arm-kernel, linux-kernel, Chuan Liu
From: Chuan Liu <chuan.liu@amlogic.com>
It is meaningless to define a spinlock in the struct meson_clk_mpll_data.
Signed-off-by: Chuan Liu <chuan.liu@amlogic.com>
---
drivers/clk/meson/s4-pll.c | 6 ------
1 file changed, 6 deletions(-)
diff --git a/drivers/clk/meson/s4-pll.c b/drivers/clk/meson/s4-pll.c
index 9697f6577e06..d8e621e79428 100644
--- a/drivers/clk/meson/s4-pll.c
+++ b/drivers/clk/meson/s4-pll.c
@@ -17,8 +17,6 @@
#include "meson-clkc-utils.h"
#include <dt-bindings/clock/amlogic,s4-pll-clkc.h>
-static DEFINE_SPINLOCK(meson_clk_lock);
-
/*
* These clock are a fixed value (fixed_pll is 2GHz) that is initialized by ROMcode.
* The chip was changed fixed pll for security reasons. Fixed PLL registers are not writable
@@ -547,7 +545,6 @@ static struct clk_regmap s4_mpll0_div = {
.shift = 29,
.width = 1,
},
- .lock = &meson_clk_lock,
.init_regs = s4_mpll0_init_regs,
.init_count = ARRAY_SIZE(s4_mpll0_init_regs),
},
@@ -601,7 +598,6 @@ static struct clk_regmap s4_mpll1_div = {
.shift = 29,
.width = 1,
},
- .lock = &meson_clk_lock,
.init_regs = s4_mpll1_init_regs,
.init_count = ARRAY_SIZE(s4_mpll1_init_regs),
},
@@ -655,7 +651,6 @@ static struct clk_regmap s4_mpll2_div = {
.shift = 29,
.width = 1,
},
- .lock = &meson_clk_lock,
.init_regs = s4_mpll2_init_regs,
.init_count = ARRAY_SIZE(s4_mpll2_init_regs),
},
@@ -709,7 +704,6 @@ static struct clk_regmap s4_mpll3_div = {
.shift = 29,
.width = 1,
},
- .lock = &meson_clk_lock,
.init_regs = s4_mpll3_init_regs,
.init_count = ARRAY_SIZE(s4_mpll3_init_regs),
},
--
2.42.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/6] clk: meson: Delete a meaningless spinlock from the MPLL
2024-09-20 8:16 [PATCH 0/6] clk: meson: Delete a meaningless spinlock from the MPLL Chuan Liu via B4 Relay
` (5 preceding siblings ...)
2024-09-20 8:16 ` [PATCH 6/6] clk: meson: s4: " Chuan Liu via B4 Relay
@ 2024-09-24 8:35 ` Jerome Brunet
2024-09-24 8:48 ` Chuan Liu
6 siblings, 1 reply; 9+ messages in thread
From: Jerome Brunet @ 2024-09-24 8:35 UTC (permalink / raw)
To: Chuan Liu via B4 Relay
Cc: Neil Armstrong, Michael Turquette, Stephen Boyd, Kevin Hilman,
Martin Blumenstingl, chuan.liu, linux-amlogic, linux-clk,
linux-arm-kernel, linux-kernel
On Fri 20 Sep 2024 at 16:16, Chuan Liu via B4 Relay <devnull+chuan.liu.amlogic.com@kernel.org> wrote:
> The existing locking mechanism of CCF can effectively avoid concurrent
> register access. struct meson_clk_mpll_data has no meaning in defining
> a spinlock repeatedly.
>
> In addition, the register corresponding to MPLL does not share the same
> register with other module drivers, so there is no concurrent access to
> the register with other modules drivers.
>
> Every driver file with mpll defines a spinlock with the same name (even
> if defined as "static"), giving the illusion of repeated definitions?
>
> Signed-off-by: Chuan Liu <chuan.liu@amlogic.com>
I'm ok with the patch in general but I have problem with the wording.
The lock is not meaningless. It has a meaning but it does not serve a
purpose, at least not anymore. You could write that it is useless, or
superfluous if you want to, but not meaningless.
Also, please squash the changes. 1 patch for this is fine.
> ---
> Chuan Liu (6):
> clk: meson: mpll: Delete a meaningless spinlock from the MPLL
> clk: meson: axg: Delete the spinlock from the MPLL
> clk: meson: meson8b: Delete the spinlock from the MPLL
> clk: meson: gxbb: Delete the spinlock from the MPLL
> clk: meson: g12a: Delete the spinlock from the MPLL
> clk: meson: s4: Delete the spinlock from the MPLL
>
> drivers/clk/meson/axg.c | 6 ------
> drivers/clk/meson/clk-mpll.c | 11 -----------
> drivers/clk/meson/clk-mpll.h | 1 -
> drivers/clk/meson/g12a.c | 6 ------
> drivers/clk/meson/gxbb.c | 6 ------
> drivers/clk/meson/meson8b.c | 3 ---
> drivers/clk/meson/s4-pll.c | 6 ------
> 7 files changed, 39 deletions(-)
> ---
> base-commit: 0ef513560b53d499c824b77220c537eafe1df90d
> change-id: 20240918-mpll_spinlock-4b9b55c44fd5
>
> Best regards,
--
Jerome
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 9+ messages in thread
* Re: [PATCH 0/6] clk: meson: Delete a meaningless spinlock from the MPLL
2024-09-24 8:35 ` [PATCH 0/6] clk: meson: Delete a meaningless " Jerome Brunet
@ 2024-09-24 8:48 ` Chuan Liu
0 siblings, 0 replies; 9+ messages in thread
From: Chuan Liu @ 2024-09-24 8:48 UTC (permalink / raw)
To: Jerome Brunet, Chuan Liu via B4 Relay
Cc: Neil Armstrong, Michael Turquette, Stephen Boyd, Kevin Hilman,
Martin Blumenstingl, linux-amlogic, linux-clk, linux-arm-kernel,
linux-kernel
hi Jerome:
Thanks for your advice, I will modify the commit message and squash
the patch before sending it.
On 2024/9/24 16:35, Jerome Brunet wrote:
> [ EXTERNAL EMAIL ]
>
> On Fri 20 Sep 2024 at 16:16, Chuan Liu via B4 Relay <devnull+chuan.liu.amlogic.com@kernel.org> wrote:
>
>> The existing locking mechanism of CCF can effectively avoid concurrent
>> register access. struct meson_clk_mpll_data has no meaning in defining
>> a spinlock repeatedly.
>>
>> In addition, the register corresponding to MPLL does not share the same
>> register with other module drivers, so there is no concurrent access to
>> the register with other modules drivers.
>>
>> Every driver file with mpll defines a spinlock with the same name (even
>> if defined as "static"), giving the illusion of repeated definitions?
>>
>> Signed-off-by: Chuan Liu <chuan.liu@amlogic.com>
> I'm ok with the patch in general but I have problem with the wording.
> The lock is not meaningless. It has a meaning but it does not serve a
> purpose, at least not anymore. You could write that it is useless, or
> superfluous if you want to, but not meaningless.
>
> Also, please squash the changes. 1 patch for this is fine.
>
>> ---
>> Chuan Liu (6):
>> clk: meson: mpll: Delete a meaningless spinlock from the MPLL
>> clk: meson: axg: Delete the spinlock from the MPLL
>> clk: meson: meson8b: Delete the spinlock from the MPLL
>> clk: meson: gxbb: Delete the spinlock from the MPLL
>> clk: meson: g12a: Delete the spinlock from the MPLL
>> clk: meson: s4: Delete the spinlock from the MPLL
>>
>> drivers/clk/meson/axg.c | 6 ------
>> drivers/clk/meson/clk-mpll.c | 11 -----------
>> drivers/clk/meson/clk-mpll.h | 1 -
>> drivers/clk/meson/g12a.c | 6 ------
>> drivers/clk/meson/gxbb.c | 6 ------
>> drivers/clk/meson/meson8b.c | 3 ---
>> drivers/clk/meson/s4-pll.c | 6 ------
>> 7 files changed, 39 deletions(-)
>> ---
>> base-commit: 0ef513560b53d499c824b77220c537eafe1df90d
>> change-id: 20240918-mpll_spinlock-4b9b55c44fd5
>>
>> Best regards,
> --
> Jerome
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2024-09-24 8:48 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-09-20 8:16 [PATCH 0/6] clk: meson: Delete a meaningless spinlock from the MPLL Chuan Liu via B4 Relay
2024-09-20 8:16 ` [PATCH 1/6] clk: meson: mpll: " Chuan Liu via B4 Relay
2024-09-20 8:16 ` [PATCH 2/6] clk: meson: axg: Delete the " Chuan Liu via B4 Relay
2024-09-20 8:16 ` [PATCH 3/6] clk: meson: meson8b: " Chuan Liu via B4 Relay
2024-09-20 8:16 ` [PATCH 4/6] clk: meson: gxbb: " Chuan Liu via B4 Relay
2024-09-20 8:16 ` [PATCH 5/6] clk: meson: g12a: " Chuan Liu via B4 Relay
2024-09-20 8:16 ` [PATCH 6/6] clk: meson: s4: " Chuan Liu via B4 Relay
2024-09-24 8:35 ` [PATCH 0/6] clk: meson: Delete a meaningless " Jerome Brunet
2024-09-24 8:48 ` Chuan Liu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®