From: Jerome Brunet <jbrunet@baylibre.com>
To: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
Cc: linus.walleij@linaro.org, neil.armstrong@linaro.org,
khilman@baylibre.com, martin.blumenstingl@googlemail.com,
linux-gpio@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-amlogic@lists.infradead.org, linux-kernel@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [PATCH 0/3] pinctrl: meson: Constify some structure
Date: Wed, 07 Aug 2024 16:14:04 +0200 [thread overview]
Message-ID: <1jy158xvwz.fsf@starbuckisacylon.baylibre.com> (raw)
In-Reply-To: <cover.1723022467.git.christophe.jaillet@wanadoo.fr> (Christophe JAILLET's message of "Wed, 7 Aug 2024 11:30:54 +0200")
On Wed 07 Aug 2024 at 11:30, Christophe JAILLET <christophe.jaillet@wanadoo.fr> wrote:
> These 3 patches constify some structures in order to move some data to a
> read-only section, so increase overall security.
>
> It is splitted in 3 to ease review.
I'm not entirely sure it eases review in this case.
If a v2 is necessary, I think a single patch would be better.
> Patch 1: struct meson_pmx_group and meson_pmx_func
> patch 2: struct meson_bank
> patch 3: struct meson_pmx_bank
Is there any reason for leaving out 'struct meson_pinctrl_data' and
'struct meson_axg_pmx_data' ? I don't think they get modified but maybe
I missed it.
>
> All patches are only compile tested.
Looks good anyway
Reviewed-by: Jerome Brunet <jbrunet@baylibre.com>
On the vim3l:
Tested-by: Jerome Brunet <jbrunet@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2024-08-07 14:15 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-07 9:30 Christophe JAILLET
2024-08-07 9:30 ` [PATCH 1/3] pinctrl: meson: Constify struct meson_pmx_group and meson_pmx_func Christophe JAILLET
2024-08-07 9:30 ` [PATCH 2/3] pinctrl: meson: Constify struct meson_bank Christophe JAILLET
2024-08-07 9:30 ` [PATCH 3/3] pinctrl: meson: Constify struct meson_pmx_bank Christophe JAILLET
2024-08-07 14:14 ` Jerome Brunet [this message]
2024-08-07 15:08 ` [PATCH 0/3] pinctrl: meson: Constify some structure Christophe JAILLET
2024-08-07 15:22 ` Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1jy158xvwz.fsf@starbuckisacylon.baylibre.com \
--to=jbrunet@baylibre.com \
--cc=christophe.jaillet@wanadoo.fr \
--cc=kernel-janitors@vger.kernel.org \
--cc=khilman@baylibre.com \
--cc=linus.walleij@linaro.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=neil.armstrong@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®