* [PATCH RESEND] arm64: dts: VIM3: Set the rates of the clocks for the NPU
@ 2023-11-06 9:22 Tomeu Vizoso
2023-11-06 9:26 ` Neil Armstrong
2023-11-14 15:48 ` [PATCH v2] arm64: dts: amlogic: meson-g12-common: " Tomeu Vizoso
0 siblings, 2 replies; 5+ messages in thread
From: Tomeu Vizoso @ 2023-11-06 9:22 UTC (permalink / raw)
To: linux-kernel
Cc: Tomeu Vizoso, Lucas Stach, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Amlogic Meson SoC support,
open list:ARM/Amlogic Meson SoC support
Otherwise they are left at 24MHz and the NPU runs very slowly.
Signed-off-by: Tomeu Vizoso <tomeu@tomeuvizoso.net>
Suggested-by: Lucas Stach <l.stach@pengutronix.de>
---
arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
index ff68b911b729..9d5eab6595d0 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
@@ -2502,6 +2502,9 @@ npu: npu@ff100000 {
clocks = <&clkc CLKID_NNA_CORE_CLK>,
<&clkc CLKID_NNA_AXI_CLK>;
clock-names = "core", "bus";
+ assigned-clocks = <&clkc CLKID_NNA_CORE_CLK>,
+ <&clkc CLKID_NNA_AXI_CLK>;
+ assigned-clock-rates = <800000000>, <800000000>;
resets = <&reset RESET_NNA>;
status = "disabled";
};
--
2.41.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH RESEND] arm64: dts: VIM3: Set the rates of the clocks for the NPU
2023-11-06 9:22 [PATCH RESEND] arm64: dts: VIM3: Set the rates of the clocks for the NPU Tomeu Vizoso
@ 2023-11-06 9:26 ` Neil Armstrong
2023-11-06 10:41 ` Jerome Brunet
2023-11-14 15:48 ` [PATCH v2] arm64: dts: amlogic: meson-g12-common: " Tomeu Vizoso
1 sibling, 1 reply; 5+ messages in thread
From: Neil Armstrong @ 2023-11-06 9:26 UTC (permalink / raw)
To: Tomeu Vizoso, linux-kernel
Cc: Lucas Stach, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Amlogic Meson SoC support,
open list:ARM/Amlogic Meson SoC support
On 06/11/2023 10:22, Tomeu Vizoso wrote:
> Otherwise they are left at 24MHz and the NPU runs very slowly.
>
> Signed-off-by: Tomeu Vizoso <tomeu@tomeuvizoso.net>
> Suggested-by: Lucas Stach <l.stach@pengutronix.de>
> ---
> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> index ff68b911b729..9d5eab6595d0 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> @@ -2502,6 +2502,9 @@ npu: npu@ff100000 {
> clocks = <&clkc CLKID_NNA_CORE_CLK>,
> <&clkc CLKID_NNA_AXI_CLK>;
> clock-names = "core", "bus";
> + assigned-clocks = <&clkc CLKID_NNA_CORE_CLK>,
> + <&clkc CLKID_NNA_AXI_CLK>;
> + assigned-clock-rates = <800000000>, <800000000>;
> resets = <&reset RESET_NNA>;
> status = "disabled";
> };
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH RESEND] arm64: dts: VIM3: Set the rates of the clocks for the NPU
2023-11-06 9:26 ` Neil Armstrong
@ 2023-11-06 10:41 ` Jerome Brunet
2024-01-10 15:40 ` Tomeu Vizoso
0 siblings, 1 reply; 5+ messages in thread
From: Jerome Brunet @ 2023-11-06 10:41 UTC (permalink / raw)
To: Neil Armstrong, Tomeu Vizoso, linux-kernel
Cc: Lucas Stach, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Kevin Hilman, Martin Blumenstingl,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Amlogic Meson SoC support,
open list:ARM/Amlogic Meson SoC support
On Mon 06 Nov 2023 at 10:26, Neil Armstrong <neil.armstrong@linaro.org> wrote:
> On 06/11/2023 10:22, Tomeu Vizoso wrote:
patch title is misleading. It does not target the vim3 only but all g12
and sm1 HWs.
It should start with "arm64: dts: amlogic: g12: " instead
>> Otherwise they are left at 24MHz and the NPU runs very slowly.
>> Signed-off-by: Tomeu Vizoso <tomeu@tomeuvizoso.net>
>> Suggested-by: Lucas Stach <l.stach@pengutronix.de>
>> ---
>> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 3 +++
>> 1 file changed, 3 insertions(+)
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
>> b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
>> index ff68b911b729..9d5eab6595d0 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
>> @@ -2502,6 +2502,9 @@ npu: npu@ff100000 {
>> clocks = <&clkc CLKID_NNA_CORE_CLK>,
>> <&clkc CLKID_NNA_AXI_CLK>;
>> clock-names = "core", "bus";
>> + assigned-clocks = <&clkc CLKID_NNA_CORE_CLK>,
>> + <&clkc CLKID_NNA_AXI_CLK>;
>> + assigned-clock-rates = <800000000>, <800000000>;
>> resets = <&reset RESET_NNA>;
>> status = "disabled";
>> };
>
> Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH RESEND] arm64: dts: VIM3: Set the rates of the clocks for the NPU
2023-11-06 10:41 ` Jerome Brunet
@ 2024-01-10 15:40 ` Tomeu Vizoso
0 siblings, 0 replies; 5+ messages in thread
From: Tomeu Vizoso @ 2024-01-10 15:40 UTC (permalink / raw)
To: Jerome Brunet
Cc: Neil Armstrong, linux-kernel, Lucas Stach, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Kevin Hilman,
Martin Blumenstingl,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
moderated list:ARM/Amlogic Meson SoC support,
open list:ARM/Amlogic Meson SoC support
On Mon, Nov 6, 2023 at 11:43 AM Jerome Brunet <jbrunet@baylibre.com> wrote:
>
>
> On Mon 06 Nov 2023 at 10:26, Neil Armstrong <neil.armstrong@linaro.org> wrote:
>
> > On 06/11/2023 10:22, Tomeu Vizoso wrote:
>
> patch title is misleading. It does not target the vim3 only but all g12
> and sm1 HWs.
>
> It should start with "arm64: dts: amlogic: g12: " instead
Thanks, have fixed and resent.
Cheers,
Tomeu
> >> Otherwise they are left at 24MHz and the NPU runs very slowly.
> >> Signed-off-by: Tomeu Vizoso <tomeu@tomeuvizoso.net>
> >> Suggested-by: Lucas Stach <l.stach@pengutronix.de>
> >> ---
> >> arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 3 +++
> >> 1 file changed, 3 insertions(+)
> >> diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> >> b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> >> index ff68b911b729..9d5eab6595d0 100644
> >> --- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> >> +++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
> >> @@ -2502,6 +2502,9 @@ npu: npu@ff100000 {
> >> clocks = <&clkc CLKID_NNA_CORE_CLK>,
> >> <&clkc CLKID_NNA_AXI_CLK>;
> >> clock-names = "core", "bus";
> >> + assigned-clocks = <&clkc CLKID_NNA_CORE_CLK>,
> >> + <&clkc CLKID_NNA_AXI_CLK>;
> >> + assigned-clock-rates = <800000000>, <800000000>;
> >> resets = <&reset RESET_NNA>;
> >> status = "disabled";
> >> };
> >
> > Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v2] arm64: dts: amlogic: meson-g12-common: Set the rates of the clocks for the NPU
2023-11-06 9:22 [PATCH RESEND] arm64: dts: VIM3: Set the rates of the clocks for the NPU Tomeu Vizoso
2023-11-06 9:26 ` Neil Armstrong
@ 2023-11-14 15:48 ` Tomeu Vizoso
1 sibling, 0 replies; 5+ messages in thread
From: Tomeu Vizoso @ 2023-11-14 15:48 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong,
Kevin Hilman, Jerome Brunet, Martin Blumenstingl
Cc: Tomeu Vizoso, Lucas Stach, devicetree, linux-arm-kernel,
linux-amlogic, linux-kernel
Otherwise they are left at 24MHz and the NPU runs very slowly.
Signed-off-by: Tomeu Vizoso <tomeu@tomeuvizoso.net>
Suggested-by: Lucas Stach <l.stach@pengutronix.de>
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
---
v2: Fix subject (Jerome Brunet)
---
arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 3 +++
1 file changed, 3 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
index ff68b911b729..9d5eab6595d0 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
@@ -2502,6 +2502,9 @@ npu: npu@ff100000 {
clocks = <&clkc CLKID_NNA_CORE_CLK>,
<&clkc CLKID_NNA_AXI_CLK>;
clock-names = "core", "bus";
+ assigned-clocks = <&clkc CLKID_NNA_CORE_CLK>,
+ <&clkc CLKID_NNA_AXI_CLK>;
+ assigned-clock-rates = <800000000>, <800000000>;
resets = <&reset RESET_NNA>;
status = "disabled";
};
--
2.41.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2024-01-10 15:40 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-06 9:22 [PATCH RESEND] arm64: dts: VIM3: Set the rates of the clocks for the NPU Tomeu Vizoso
2023-11-06 9:26 ` Neil Armstrong
2023-11-06 10:41 ` Jerome Brunet
2024-01-10 15:40 ` Tomeu Vizoso
2023-11-14 15:48 ` [PATCH v2] arm64: dts: amlogic: meson-g12-common: " Tomeu Vizoso
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®