mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: jbrunet@baylibre.com (Jerome Brunet)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 09/10] clk: fix CLK_SET_RATE_GATE with clock rate protection
Date: Thu, 18 May 2017 18:38:03 +0200	[thread overview]
Message-ID: <20170518163804.14123-10-jbrunet@baylibre.com> (raw)
In-Reply-To: <20170518163804.14123-1-jbrunet@baylibre.com>

Using clock rate protection, we can now enforce CLK_SET_RATE_GATE along the
clock tree

Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
 drivers/clk/clk.c | 14 +++++++++++---
 1 file changed, 11 insertions(+), 3 deletions(-)

diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index 5980080a86c0..1db3ad28dd85 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -491,6 +491,9 @@ static void clk_core_unprepare(struct clk_core *core)
 	if (WARN_ON(core->prepare_count == 1 && core->flags & CLK_IS_CRITICAL))
 		return;
 
+	if (core->flags & CLK_SET_RATE_GATE)
+		clk_core_rate_unprotect(core);
+
 	if (--core->prepare_count > 0)
 		return;
 
@@ -561,6 +564,14 @@ static int clk_core_prepare(struct clk_core *core)
 
 	core->prepare_count++;
 
+	/*
+	 * CLK_SET_RATE_GATE is a special case of clock protection
+	 * Instead of a consumer protection, the provider is protecting
+	 * itself when prepared
+	 */
+	if (core->flags & CLK_SET_RATE_GATE)
+		clk_core_rate_protect(core);
+
 	return 0;
 }
 
@@ -1710,9 +1721,6 @@ static int clk_core_set_rate_nolock(struct clk_core *core,
 	if (clk_core_rate_is_protected(core))
 		return -EBUSY;
 
-	if ((core->flags & CLK_SET_RATE_GATE) && core->prepare_count)
-		return -EBUSY;
-
 	/* calculate new rates and get the topmost changed clock */
 	top = clk_calc_new_rates(core, rate);
 	if (!top)
-- 
2.9.4

  parent reply	other threads:[~2017-05-18 16:38 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-18 16:37 [PATCH 00/10] clk: implement clock rate protection mechanism Jerome Brunet
2017-05-18 16:37 ` [PATCH 01/10] clk: take the prepare lock out of clk_core_set_paren Jerome Brunet
2017-05-18 16:37 ` [PATCH 02/10] clk: add clk_core_set_phase_nolock function Jerome Brunet
2017-05-18 16:37 ` [PATCH 03/10] clk: rework calls to round and determine rate callbacks Jerome Brunet
2017-05-18 16:37 ` [PATCH 04/10] clk: add support for clock protection Jerome Brunet
2017-05-18 16:37 ` [PATCH 05/10] clk: add clk_set_rate_protect Jerome Brunet
2017-05-18 16:38 ` [PATCH 07/10] clk: cosmetic changes to clk_summary debugfs entry Jerome Brunet
2017-05-18 16:38 ` [PATCH 08/10] clk: fix incorrect usage of ENOSYS Jerome Brunet
2017-05-18 16:38 ` Jerome Brunet [this message]
2017-05-18 16:38 ` [PATCH 10/10] clk: move CLK_SET_RATE_GATE protection from prepare to enable Jerome Brunet
2017-05-19 10:05 ` [PATCH 00/10] clk: implement clock rate protection mechanism Jerome Brunet

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170518163804.14123-10-jbrunet@baylibre.com \
    --to=jbrunet@baylibre.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®