From: jbrunet@baylibre.com (Jerome Brunet)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 08/10] clk: fix incorrect usage of ENOSYS
Date: Thu, 18 May 2017 18:38:02 +0200 [thread overview]
Message-ID: <20170518163804.14123-9-jbrunet@baylibre.com> (raw)
In-Reply-To: <20170518163804.14123-1-jbrunet@baylibre.com>
ENOSYS is special and should only be used for incorrect syscall number.
It does not seem to be the case here.
Reported by checkpatch.pl while working on clock protection.
Signed-off-by: Jerome Brunet <jbrunet@baylibre.com>
---
drivers/clk/clk.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/clk.c b/drivers/clk/clk.c
index e60d86d7c082..5980080a86c0 100644
--- a/drivers/clk/clk.c
+++ b/drivers/clk/clk.c
@@ -2004,7 +2004,7 @@ static int clk_core_set_parent_nolock(struct clk_core *core,
/* verify ops for for multi-parent clks */
if ((core->num_parents > 1) && (!core->ops->set_parent))
- return -ENOSYS;
+ return -EPERM;
/* check that we are allowed to re-parent if the clock is in use */
if ((core->flags & CLK_SET_PARENT_GATE) && core->prepare_count)
--
2.9.4
next prev parent reply other threads:[~2017-05-18 16:38 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-18 16:37 [PATCH 00/10] clk: implement clock rate protection mechanism Jerome Brunet
2017-05-18 16:37 ` [PATCH 01/10] clk: take the prepare lock out of clk_core_set_paren Jerome Brunet
2017-05-18 16:37 ` [PATCH 02/10] clk: add clk_core_set_phase_nolock function Jerome Brunet
2017-05-18 16:37 ` [PATCH 03/10] clk: rework calls to round and determine rate callbacks Jerome Brunet
2017-05-18 16:37 ` [PATCH 04/10] clk: add support for clock protection Jerome Brunet
2017-05-18 16:37 ` [PATCH 05/10] clk: add clk_set_rate_protect Jerome Brunet
2017-05-18 16:38 ` [PATCH 07/10] clk: cosmetic changes to clk_summary debugfs entry Jerome Brunet
2017-05-18 16:38 ` Jerome Brunet [this message]
2017-05-18 16:38 ` [PATCH 09/10] clk: fix CLK_SET_RATE_GATE with clock rate protection Jerome Brunet
2017-05-18 16:38 ` [PATCH 10/10] clk: move CLK_SET_RATE_GATE protection from prepare to enable Jerome Brunet
2017-05-19 10:05 ` [PATCH 00/10] clk: implement clock rate protection mechanism Jerome Brunet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170518163804.14123-9-jbrunet@baylibre.com \
--to=jbrunet@baylibre.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®