mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: carlo@caione.org (Carlo Caione)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v4 0/2] scpi-sensors: Fix SCP sensor readings scale
Date: Tue, 30 May 2017 11:05:05 +0200	[thread overview]
Message-ID: <20170530090507.16611-1-carlo@caione.org> (raw)

From: Carlo Caione <carlo@endlessm.com>

Sorry for the delay. This is the follow-up on the patches about scpi-sensors
with the fix suggested in [0].

The previous version is at [1].

The implementation details for SCPI seems to suggest that the sensor
readings must be reported by SCP using a well defined scale
(millidegree Celsius for temperature, millivolts for voltage,
milliamperes for current, microwatts for power and microjoules for
energy).

This is also important for the interaction with other subsystems: for
example both the thermal sub-system and the hwmon sysfs interface expect
the temperature expressed in millidegree Celsius.

Unfortunately since this behaviour is dependent on the firmware
implementation there are cases where the sensor readings are reported
using a different scale. For example in the Amlogic SoCs the
temperature is reported in degree and not millidegree Celsius.

In this patchset we introduce a new DT compatible
'amlogic,meson-gxbb-scpi-sensors' that is used by the scpi-hwmon driver to
convert the sensor readings to the expected scale.

v2:
 - Added data validation (scale != 0)
 - s/unsigned int/u32/ for the array
 - Switched to array initialiser notation
 - Introduced scpi_scale_reading()

v3:
 - scpi_scale_reading marked as static

v4:
 - Removed new binding and added a new compatible instead

[0] https://patchwork.kernel.org/patch/9612959/
[1] http://lists.infradead.org/pipermail/linux-arm-kernel/2017-March/492553.html

Carlo Caione (2):
  Documentation: bindings: add amlogic,meson-gxbb-scpi-sensors
    compatible
  hwmon: (scpi) Fix the scale of SCP sensor readings

 Documentation/devicetree/bindings/arm/arm,scpi.txt |  2 +-
 drivers/hwmon/scpi-hwmon.c                         | 54 +++++++++++++++++++---
 2 files changed, 49 insertions(+), 7 deletions(-)

-- 
2.9.3

             reply	other threads:[~2017-05-30  9:05 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-30  9:05 Carlo Caione [this message]
2017-05-30  9:05 ` [PATCH v4 1/2] Documentation: bindings: add amlogic, meson-gxbb-scpi-sensors compatible Carlo Caione
2017-06-02 13:14   ` [PATCH v4 1/2] Documentation: bindings: add amlogic,meson-gxbb-scpi-sensors compatible Guenter Roeck
2017-06-02 13:26     ` Sudeep Holla
2017-06-07 20:51   ` Rob Herring
2017-05-30  9:05 ` [PATCH v4 2/2] hwmon: (scpi) Fix the scale of SCP sensor readings Carlo Caione
2017-05-30 11:14   ` Sudeep Holla
2017-06-02 13:16   ` [v4,2/2] " Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170530090507.16611-1-carlo@caione.org \
    --to=carlo@caione.org \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®