mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: sudeep.holla@arm.com (Sudeep Holla)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH v4 2/2] hwmon: (scpi) Fix the scale of SCP sensor readings
Date: Tue, 30 May 2017 12:14:44 +0100	[thread overview]
Message-ID: <67c7a124-06fb-fa9e-18b6-5faeed030d10@arm.com> (raw)
In-Reply-To: <20170530090507.16611-3-carlo@caione.org>



On 30/05/17 10:05, Carlo Caione wrote:
> From: Carlo Caione <carlo@endlessm.com>
> 
> The implementation details for SCPI seems to suggest that the sensor
> readings must be reported by SCP using a well defined scale
> (millidegree Celsius for temperature, millivolts for voltage,
> milliamperes for current, microwatts for power and microjoules for
> energy).
> 
> This is also important for the interaction with other subsystems: for
> example both the thermal sub-system and the hwmon sysfs interface expect
> the temperature expressed in millidegree Celsius.
> 
> Unfortunately since this behaviour is dependent on the firmware
> implementation there are cases where the sensor readings are reported
> using a different scale. For example in the Amlogic SoCs the
> temperature is reported in degree and not millidegree Celsius.
> 
> To take into account this discrepancy and fixup the values reported by
> SCP a new compatible 'amlogic,meson-gxbb-scpi-sensors' is introduced and
> used in this patch by the scpi-hwmon driver to convert the sensor
> readings to the expected scale.
> 

Looks good to me

Acked-by: Sudeep Holla <sudeep.holla@arm.com>

-- 
Regards,
Sudeep

  reply	other threads:[~2017-05-30 11:14 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-05-30  9:05 [PATCH v4 0/2] scpi-sensors: Fix SCP sensor readings scale Carlo Caione
2017-05-30  9:05 ` [PATCH v4 1/2] Documentation: bindings: add amlogic, meson-gxbb-scpi-sensors compatible Carlo Caione
2017-06-02 13:14   ` [PATCH v4 1/2] Documentation: bindings: add amlogic,meson-gxbb-scpi-sensors compatible Guenter Roeck
2017-06-02 13:26     ` Sudeep Holla
2017-06-07 20:51   ` Rob Herring
2017-05-30  9:05 ` [PATCH v4 2/2] hwmon: (scpi) Fix the scale of SCP sensor readings Carlo Caione
2017-05-30 11:14   ` Sudeep Holla [this message]
2017-06-02 13:16   ` [v4,2/2] " Guenter Roeck

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=67c7a124-06fb-fa9e-18b6-5faeed030d10@arm.com \
    --to=sudeep.holla@arm.com \
    --cc=linus-amlogic@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®