From: ingrassia@epigenesys.com (Emiliano Ingrassia)
To: linus-amlogic@lists.infradead.org
Subject: [PATCH 0/1] Meson8b RGMII Ethernet pin cleanup
Date: Thu, 3 May 2018 19:06:35 +0200 [thread overview]
Message-ID: <20180503170635.GA1925@ingrassia.epigenesys.com> (raw)
In-Reply-To: <20180501220045.2004-1-martin.blumenstingl@googlemail.com>
Hi Martin,
the patch seems to work fine but I have two questions.
First, should we remove those pins from "ethernet_groups" structure
in "drivers/pinctrl/meson/pinctrl-meson8b.c" ?
Second, following the Odroid-C1+ schematics there are two pins,
"eth_rxd2" and "eth_rxd3" which are not configured by the pin controller
driver, nor included in the pins group in the relative device tree.
Should we configure and include them ?
Thanks,
Emiliano
On Wed, May 02, 2018 at 12:00:44AM +0200, Martin Blumenstingl wrote:
> Hi Emiliano, Hi Linus,
>
> could you please test the patch from this series on your Odroid-C1?
> I tested it on mine and Ethernet seems to be working fine with it.
>
> There should be no functional changes with this patch as it just
> removes an incorrect pad configuration for DIF_2_P and DIF_2_N for
> the TXD0 and TXD1 signal (as these are routed to GPIOH_5 and GPIOH_6
> on Odroid-C1).
>
>
> Martin Blumenstingl (1):
> ARM: dts: meson8b: RGMII doesn't use the eth_txd1_1 and eth_txd0_1
> pins
>
> arch/arm/boot/dts/meson8b.dtsi | 2 --
> 1 file changed, 2 deletions(-)
>
> --
> 2.17.0
>
next prev parent reply other threads:[~2018-05-03 17:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-05-01 22:00 Martin Blumenstingl
2018-05-01 22:00 ` [PATCH 1/1] ARM: dts: meson8b: RGMII doesn't use the eth_txd1_1 and eth_txd0_1 pins Martin Blumenstingl
2018-05-01 22:03 ` [PATCH 0/1] Meson8b RGMII Ethernet pin cleanup Martin Blumenstingl
2018-05-03 17:06 ` Emiliano Ingrassia [this message]
2018-05-04 20:09 ` Martin Blumenstingl
2018-05-06 21:53 ` Emiliano Ingrassia
2018-05-09 23:01 ` Martin Blumenstingl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180503170635.GA1925@ingrassia.epigenesys.com \
--to=ingrassia@epigenesys.com \
--cc=linus-amlogic@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®