* [linux-firmware] [GIT PULL] amlogic: add video decoder firmwares
@ 2018-10-01 15:26 Maxime Jourdan
2018-10-01 15:36 ` Josh Boyer
0 siblings, 1 reply; 3+ messages in thread
From: Maxime Jourdan @ 2018-10-01 15:26 UTC (permalink / raw)
To: linus-amlogic
Hello,
Below is a pull request to add the firmwares required by the Amlogic video
decoder.
The firmwares were dumped from GPLv2+ in-kernel source files from Amlogic's
vendor kernel, in their buildroot package
"buildroot_openlinux_kernel_4.9_wayland_20180316"
You can find an example of such a file in an older kernel here:
https://github.com/hardkernel/linux/blob/odroidc2-3.14.y/drivers/amlogic/amports/arch/ucode/mpeg12/vmpeg12_mc.c
The corresponding driver is currently being upstreamed:
https://lore.kernel.org/patchwork/cover/993093/
Regards,
Maxime
The following changes since commit 7c81f23ad903f72e87e2102d8f52408305c0f7a2:
ti-connectivity: add firmware for CC2560(A) Bluetooth (2018-10-01 10:08:30 -0400)
are available in the Git repository at:
https://github.com/Elyotna/linux-firmware.git
for you to fetch changes up to b99cf8dcfb6e7a3dd00bdb6aa4f6c71cb6b42e58:
amlogic: add video decoder firmwares (2018-10-01 17:06:18 +0200)
----------------------------------------------------------------
Maxime Jourdan (1):
amlogic: add video decoder firmwares
WHENCE | 16 ++++++++++++++++
amlogic/gx/h263_mc | Bin 0 -> 16384 bytes
amlogic/gx/vh265_mc | Bin 0 -> 16384 bytes
amlogic/gx/vh265_mc_mmu | Bin 0 -> 16384 bytes
amlogic/gx/vmjpeg_mc | Bin 0 -> 16384 bytes
amlogic/gx/vmpeg12_mc | Bin 0 -> 16384 bytes
amlogic/gx/vmpeg4_mc_5 | Bin 0 -> 16384 bytes
amlogic/gxbb/vh264_mc | Bin 0 -> 36864 bytes
amlogic/gxl/vh264_mc | Bin 0 -> 36864 bytes
amlogic/gxm/vh264_mc | Bin 0 -> 36864 bytes
10 files changed, 16 insertions(+)
create mode 100644 amlogic/gx/h263_mc
create mode 100644 amlogic/gx/vh265_mc
create mode 100644 amlogic/gx/vh265_mc_mmu
create mode 100644 amlogic/gx/vmjpeg_mc
create mode 100644 amlogic/gx/vmpeg12_mc
create mode 100644 amlogic/gx/vmpeg4_mc_5
create mode 100644 amlogic/gxbb/vh264_mc
create mode 100644 amlogic/gxl/vh264_mc
create mode 100644 amlogic/gxm/vh264_mc
^ permalink raw reply [flat|nested] 3+ messages in thread* [linux-firmware] [GIT PULL] amlogic: add video decoder firmwares
2018-10-01 15:26 [linux-firmware] [GIT PULL] amlogic: add video decoder firmwares Maxime Jourdan
@ 2018-10-01 15:36 ` Josh Boyer
2018-10-01 15:54 ` Maxime Jourdan
0 siblings, 1 reply; 3+ messages in thread
From: Josh Boyer @ 2018-10-01 15:36 UTC (permalink / raw)
To: linus-amlogic
On Mon, Oct 1, 2018 at 11:27 AM Maxime Jourdan <mjourdan@baylibre.com> wrote:
>
> Hello,
>
> Below is a pull request to add the firmwares required by the Amlogic video
> decoder.
>
> The firmwares were dumped from GPLv2+ in-kernel source files from Amlogic's
> vendor kernel, in their buildroot package
> "buildroot_openlinux_kernel_4.9_wayland_20180316"
>
> You can find an example of such a file in an older kernel here:
> https://github.com/hardkernel/linux/blob/odroidc2-3.14.y/drivers/amlogic/amports/arch/ucode/mpeg12/vmpeg12_mc.c
>
> The corresponding driver is currently being upstreamed:
> https://lore.kernel.org/patchwork/cover/993093/
>
> Regards,
> Maxime
>
> The following changes since commit 7c81f23ad903f72e87e2102d8f52408305c0f7a2:
>
> ti-connectivity: add firmware for CC2560(A) Bluetooth (2018-10-01 10:08:30 -0400)
>
> are available in the Git repository at:
>
> https://github.com/Elyotna/linux-firmware.git
This seems questionable to me. You have the license listed as GPLv2
or later, which is what the header file originally had but you have no
corresponding source included in your commit and it's completely
unclear who would be fulfilling the GPL obligations around this. Even
less clear is how one would take whatever source is provided and turn
them back into the binaries you've provided. Have you contacted AM
Logic to see if they can post the firmware files themselves or confirm
the license should be GPLv2?
josh
> for you to fetch changes up to b99cf8dcfb6e7a3dd00bdb6aa4f6c71cb6b42e58:
>
> amlogic: add video decoder firmwares (2018-10-01 17:06:18 +0200)
>
> ----------------------------------------------------------------
> Maxime Jourdan (1):
> amlogic: add video decoder firmwares
>
> WHENCE | 16 ++++++++++++++++
> amlogic/gx/h263_mc | Bin 0 -> 16384 bytes
> amlogic/gx/vh265_mc | Bin 0 -> 16384 bytes
> amlogic/gx/vh265_mc_mmu | Bin 0 -> 16384 bytes
> amlogic/gx/vmjpeg_mc | Bin 0 -> 16384 bytes
> amlogic/gx/vmpeg12_mc | Bin 0 -> 16384 bytes
> amlogic/gx/vmpeg4_mc_5 | Bin 0 -> 16384 bytes
> amlogic/gxbb/vh264_mc | Bin 0 -> 36864 bytes
> amlogic/gxl/vh264_mc | Bin 0 -> 36864 bytes
> amlogic/gxm/vh264_mc | Bin 0 -> 36864 bytes
> 10 files changed, 16 insertions(+)
> create mode 100644 amlogic/gx/h263_mc
> create mode 100644 amlogic/gx/vh265_mc
> create mode 100644 amlogic/gx/vh265_mc_mmu
> create mode 100644 amlogic/gx/vmjpeg_mc
> create mode 100644 amlogic/gx/vmpeg12_mc
> create mode 100644 amlogic/gx/vmpeg4_mc_5
> create mode 100644 amlogic/gxbb/vh264_mc
> create mode 100644 amlogic/gxl/vh264_mc
> create mode 100644 amlogic/gxm/vh264_mc
^ permalink raw reply [flat|nested] 3+ messages in thread
* [linux-firmware] [GIT PULL] amlogic: add video decoder firmwares
2018-10-01 15:36 ` Josh Boyer
@ 2018-10-01 15:54 ` Maxime Jourdan
0 siblings, 0 replies; 3+ messages in thread
From: Maxime Jourdan @ 2018-10-01 15:54 UTC (permalink / raw)
To: linus-amlogic
On Mon, Oct 1, 2018 at 5:36 PM Josh Boyer <jwboyer@kernel.org> wrote:
>
> On Mon, Oct 1, 2018 at 11:27 AM Maxime Jourdan <mjourdan@baylibre.com> wrote:
> >
> > Hello,
> >
> > Below is a pull request to add the firmwares required by the Amlogic video
> > decoder.
> >
> > The firmwares were dumped from GPLv2+ in-kernel source files from Amlogic's
> > vendor kernel, in their buildroot package
> > "buildroot_openlinux_kernel_4.9_wayland_20180316"
> >
> > You can find an example of such a file in an older kernel here:
> > https://github.com/hardkernel/linux/blob/odroidc2-3.14.y/drivers/amlogic/amports/arch/ucode/mpeg12/vmpeg12_mc.c
> >
> > The corresponding driver is currently being upstreamed:
> > https://lore.kernel.org/patchwork/cover/993093/
> >
> > Regards,
> > Maxime
> >
> > The following changes since commit 7c81f23ad903f72e87e2102d8f52408305c0f7a2:
> >
> > ti-connectivity: add firmware for CC2560(A) Bluetooth (2018-10-01 10:08:30 -0400)
> >
> > are available in the Git repository at:
> >
> > https://github.com/Elyotna/linux-firmware.git
>
> This seems questionable to me. You have the license listed as GPLv2
> or later, which is what the header file originally had but you have no
> corresponding source included in your commit and it's completely
> unclear who would be fulfilling the GPL obligations around this. Even
> less clear is how one would take whatever source is provided and turn
> them back into the binaries you've provided. Have you contacted AM
> Logic to see if they can post the firmware files themselves or confirm
> the license should be GPLv2?
>
> josh
>
Hi Josh,
I see your point. The "source" files that are GPLv2+ in the vendor
kernel only contain binary arrays, and there is no actual source code
available for these firmwares. I had hoped this would at least mean we
could redistribute the binary firmwares.
I will contact Amlogic and (hopefully) follow up with clarified
licensing regarding the firmwares.
Regards,
Maxime
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-01 15:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-10-01 15:26 [linux-firmware] [GIT PULL] amlogic: add video decoder firmwares Maxime Jourdan
2018-10-01 15:36 ` Josh Boyer
2018-10-01 15:54 ` Maxime Jourdan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®