mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
* [PATCH v2 1/3] arm64: dts: meson-gxl: add support for phicomm n1
@ 2018-11-04 16:50 He Yangxuan
  2018-11-05 10:45 ` Carlo Caione
  0 siblings, 1 reply; 2+ messages in thread
From: He Yangxuan @ 2018-11-04 16:50 UTC (permalink / raw)
  To: linus-amlogic

This patch adds support for the Phicomm N1. This device based on P230 reference design.
The phy is RTL8211F, need to disable Energy Efficient Ethernet (EEE) to make it stable.
And this box doesn't have cvbs, so disable related section in device tree.

Changes since v1:
 - rewrite external_phy section

Signed-off-by: He Yangxuan <yangxuan8282@gmail.com>
---
 arch/arm64/boot/dts/amlogic/Makefile               |  1 +
 .../dts/amlogic/meson-gxl-s905d-phicomm-n1.dts     | 26 ++++++++++++++++++++++
 2 files changed, 27 insertions(+)
 create mode 100644 arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts

diff --git a/arch/arm64/boot/dts/amlogic/Makefile b/arch/arm64/boot/dts/amlogic/Makefile
index c31f29d66..49f3ac5d8 100644
--- a/arch/arm64/boot/dts/amlogic/Makefile
+++ b/arch/arm64/boot/dts/amlogic/Makefile
@@ -18,6 +18,7 @@ dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-nexbox-a95x.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905x-p212.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p230.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-p231.dtb
+dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905d-phicomm-n1.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s805x-p241.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905w-p281.dtb
 dtb-$(CONFIG_ARCH_MESON) += meson-gxl-s905w-tx3-mini.dtb
diff --git a/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
new file mode 100644
index 000000000..1096509b2
--- /dev/null
+++ b/arch/arm64/boot/dts/amlogic/meson-gxl-s905d-phicomm-n1.dts
@@ -0,0 +1,26 @@
+// SPDX-License-Identifier: (GPL-2.0+ OR MIT)
+/*
+ * Copyright (c) 2018 He Yangxuan
+ */
+
+/dts-v1/;
+
+#include "meson-gxl-s905d-p230.dts"
+
+/ {
+	compatible = "phicomm,n1", "amlogic,s905d", "amlogic,meson-gxl";
+	model = "Phicomm N1";
+
+	cvbs-connector {
+		status = "disabled";
+	};
+};
+
+&cvbs_vdac_port {
+	status = "disabled";
+};
+
+&external_phy {
+	/* Realtek RTL8211F (0x001cc916) */
+	eee-broken-1000t;
+};
-- 
2.11.0

^ permalink raw reply	[flat|nested] 2+ messages in thread

* [PATCH v2 1/3] arm64: dts: meson-gxl: add support for phicomm n1
  2018-11-04 16:50 [PATCH v2 1/3] arm64: dts: meson-gxl: add support for phicomm n1 He Yangxuan
@ 2018-11-05 10:45 ` Carlo Caione
  0 siblings, 0 replies; 2+ messages in thread
From: Carlo Caione @ 2018-11-05 10:45 UTC (permalink / raw)
  To: linus-amlogic

On Mon, 2018-11-05 at 00:50 +0800, He Yangxuan wrote:
> This patch adds support for the Phicomm N1. This device based on P230
> reference design.
> The phy is RTL8211F, need to disable Energy Efficient Ethernet (EEE)
> to make it stable.
> And this box doesn't have cvbs, so disable related section in device
> tree.
> 
> Changes since v1:
>  - rewrite external_phy section

Probably it's better if you keep the changes recap out of the commit
message.

Thanks.

--
Carlo Caione

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2018-11-05 10:45 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-11-04 16:50 [PATCH v2 1/3] arm64: dts: meson-gxl: add support for phicomm n1 He Yangxuan
2018-11-05 10:45 ` Carlo Caione

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®