* [PATCH v4 0/1] Meson8b RGMII Ethernet pin fixes @ 2019-01-12 12:59 Martin Blumenstingl 2019-01-12 12:59 ` [PATCH v4 1/1] pinctrl: meson: meson8b: add the eth_rxd2 and eth_rxd3 pins Martin Blumenstingl 0 siblings, 1 reply; 3+ messages in thread From: Martin Blumenstingl @ 2019-01-12 12:59 UTC (permalink / raw) To: linux-amlogic, linux-gpio, linus.walleij Cc: Martin Blumenstingl, khilman, ingrassia, linux-arm-kernel This series fixes Ethernet RX performance on boards using a Gigabit PHY and a Meson8b SoC. We now reach near Gigabit speeds in RX and TX direction (when data is flowing in only one direction, full-duplex seems be have another issue which is probably not related to pinctrl). Changes since v3 at [2]: - Collected Emiliano's and Kevin's Reviewed-by/Tested-by - dropped patch #2 (.dts patch) as it has been applied by Kevin already - include the linux-gpio mailing list this time Changes since v2 at [1]: - Thanks to Jianxin for providing the documentation for the two missing bits in pin mux register 7 - added a patch to add the missing eth_rxd2 and eth_rxd3 pin groups to the pinctrl-meson8b driver - update the meson8.dtsi patch to include the eth_rxd2 and eth_rxd3 pin groups on top of the previous change which only removed eth_txd0_1 and eth_txd1_1 (including the patch description) - update subject of the cover-letter and the meson8b.dtsi patch Changes since v1 at [0]: - rebased so it applies on top of "ARM: dts: meson: meson8b: add the CPU OPP tables" which will be part of v4.20-rc1 once the arm-soc tree is merged into mainline - updated patch description with more details [0] http://lists.infradead.org/pipermail/linux-amlogic/2018-May/007274.html [1] https://patchwork.kernel.org/cover/10744709/ [2] https://patchwork.kernel.org/cover/10744905/ Martin Blumenstingl (1): pinctrl: meson: meson8b: add the eth_rxd2 and eth_rxd3 pins drivers/pinctrl/meson/pinctrl-meson8b.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) -- 2.20.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH v4 1/1] pinctrl: meson: meson8b: add the eth_rxd2 and eth_rxd3 pins 2019-01-12 12:59 [PATCH v4 0/1] Meson8b RGMII Ethernet pin fixes Martin Blumenstingl @ 2019-01-12 12:59 ` Martin Blumenstingl 2019-01-14 8:30 ` Linus Walleij 0 siblings, 1 reply; 3+ messages in thread From: Martin Blumenstingl @ 2019-01-12 12:59 UTC (permalink / raw) To: linux-amlogic, linux-gpio, linus.walleij Cc: Martin Blumenstingl, khilman, ingrassia, linux-arm-kernel, Jianxin Pan Gigabit Ethernet requires the Ethernet TXD0..3 and RXD0..3 data lines. Add the missing eth_rxd2 and eth_rxd3 definitions so we don't have to rely on the bootloader to set them up correctly. The vendor u-boot sources for Odroid-C1 use the following Ethernet pinmux configuration: SET_CBUS_REG_MASK(PERIPHS_PIN_MUX_6, 0x3f4f); SET_CBUS_REG_MASK(PERIPHS_PIN_MUX_7, 0xf00000); This translates to the following pin groups in the mainline kernel: - register 6 bit 0: eth_rxd1 (DIF_0_P) - register 6 bit 1: eth_rxd0 (DIF_0_N) - register 6 bit 2: eth_rx_dv (DIF_1_P) - register 6 bit 3: eth_rx_clk (DIF_1_N) - register 6 bit 6: eth_tx_en (DIF_3_P) - register 6 bit 8: eth_ref_clk (DIF_3_N) - register 6 bit 9: eth_mdc (DIF_4_P) - register 6 bit 10: eth_mdio_en (DIF_4_N) - register 6 bit 11: eth_tx_clk (GPIOH_9) - register 6 bit 12: eth_txd2 (GPIOH_8) - register 6 bit 13: eth_txd3 (GPIOH_7) - register 7 bit 20: eth_txd0_0 (GPIOH_6) - register 7 bit 21: eth_txd1_0 (GPIOH_5) - register 7 bit 22: eth_rxd3 (DIF_2_P) - register 7 bit 23: eth_rxd2 (DIF_2_N) All functions except eth_rxd2 and eth_rxd3 are already supported by the pinctrl-meson8b driver. Suggested-by: Jianxin Pan <jianxin.pan@amlogic.com> Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> Reviewed-by: Kevin Hilman <khilman@baylibre.com> Tested-by: Emiliano Ingrassia <ingrassia@epigenesys.com> Reviewed-by: Emiliano Ingrassia <ingrassia@epigenesys.com> --- drivers/pinctrl/meson/pinctrl-meson8b.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/pinctrl/meson/pinctrl-meson8b.c b/drivers/pinctrl/meson/pinctrl-meson8b.c index c69ca95b1ad5..84938bd73ac2 100644 --- a/drivers/pinctrl/meson/pinctrl-meson8b.c +++ b/drivers/pinctrl/meson/pinctrl-meson8b.c @@ -346,6 +346,8 @@ static const unsigned int eth_rx_dv_pins[] = { DIF_1_P }; static const unsigned int eth_rx_clk_pins[] = { DIF_1_N }; static const unsigned int eth_txd0_1_pins[] = { DIF_2_P }; static const unsigned int eth_txd1_1_pins[] = { DIF_2_N }; +static const unsigned int eth_rxd3_pins[] = { DIF_2_P }; +static const unsigned int eth_rxd2_pins[] = { DIF_2_N }; static const unsigned int eth_tx_en_pins[] = { DIF_3_P }; static const unsigned int eth_ref_clk_pins[] = { DIF_3_N }; static const unsigned int eth_mdc_pins[] = { DIF_4_P }; @@ -599,6 +601,8 @@ static struct meson_pmx_group meson8b_cbus_groups[] = { GROUP(eth_ref_clk, 6, 8), GROUP(eth_mdc, 6, 9), GROUP(eth_mdio_en, 6, 10), + GROUP(eth_rxd3, 7, 22), + GROUP(eth_rxd2, 7, 23), }; static struct meson_pmx_group meson8b_aobus_groups[] = { @@ -748,7 +752,7 @@ static const char * const ethernet_groups[] = { "eth_tx_clk", "eth_tx_en", "eth_txd1_0", "eth_txd1_1", "eth_txd0_0", "eth_txd0_1", "eth_rx_clk", "eth_rx_dv", "eth_rxd1", "eth_rxd0", "eth_mdio_en", "eth_mdc", "eth_ref_clk", - "eth_txd2", "eth_txd3" + "eth_txd2", "eth_txd3", "eth_rxd3", "eth_rxd2" }; static const char * const i2c_a_groups[] = { -- 2.20.1 _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v4 1/1] pinctrl: meson: meson8b: add the eth_rxd2 and eth_rxd3 pins 2019-01-12 12:59 ` [PATCH v4 1/1] pinctrl: meson: meson8b: add the eth_rxd2 and eth_rxd3 pins Martin Blumenstingl @ 2019-01-14 8:30 ` Linus Walleij 0 siblings, 0 replies; 3+ messages in thread From: Linus Walleij @ 2019-01-14 8:30 UTC (permalink / raw) To: Martin Blumenstingl Cc: Jianxin Pan, Kevin Hilman, open list:GPIO SUBSYSTEM, Linux ARM, open list:ARM/Amlogic Meson..., ingrassia On Sat, Jan 12, 2019 at 1:59 PM Martin Blumenstingl <martin.blumenstingl@googlemail.com> wrote: > Gigabit Ethernet requires the Ethernet TXD0..3 and RXD0..3 data lines. > Add the missing eth_rxd2 and eth_rxd3 definitions so we don't have to > rely on the bootloader to set them up correctly. > > The vendor u-boot sources for Odroid-C1 use the following Ethernet > pinmux configuration: > SET_CBUS_REG_MASK(PERIPHS_PIN_MUX_6, 0x3f4f); > SET_CBUS_REG_MASK(PERIPHS_PIN_MUX_7, 0xf00000); > This translates to the following pin groups in the mainline kernel: > - register 6 bit 0: eth_rxd1 (DIF_0_P) > - register 6 bit 1: eth_rxd0 (DIF_0_N) > - register 6 bit 2: eth_rx_dv (DIF_1_P) > - register 6 bit 3: eth_rx_clk (DIF_1_N) > - register 6 bit 6: eth_tx_en (DIF_3_P) > - register 6 bit 8: eth_ref_clk (DIF_3_N) > - register 6 bit 9: eth_mdc (DIF_4_P) > - register 6 bit 10: eth_mdio_en (DIF_4_N) > - register 6 bit 11: eth_tx_clk (GPIOH_9) > - register 6 bit 12: eth_txd2 (GPIOH_8) > - register 6 bit 13: eth_txd3 (GPIOH_7) > - register 7 bit 20: eth_txd0_0 (GPIOH_6) > - register 7 bit 21: eth_txd1_0 (GPIOH_5) > - register 7 bit 22: eth_rxd3 (DIF_2_P) > - register 7 bit 23: eth_rxd2 (DIF_2_N) > > All functions except eth_rxd2 and eth_rxd3 are already supported by the > pinctrl-meson8b driver. > > Suggested-by: Jianxin Pan <jianxin.pan@amlogic.com> > Signed-off-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com> > Reviewed-by: Kevin Hilman <khilman@baylibre.com> > Tested-by: Emiliano Ingrassia <ingrassia@epigenesys.com> > Reviewed-by: Emiliano Ingrassia <ingrassia@epigenesys.com> Patch applied. Yours, Linus Walleij _______________________________________________ linux-amlogic mailing list linux-amlogic@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-amlogic ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-01-14 8:31 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2019-01-12 12:59 [PATCH v4 0/1] Meson8b RGMII Ethernet pin fixes Martin Blumenstingl 2019-01-12 12:59 ` [PATCH v4 1/1] pinctrl: meson: meson8b: add the eth_rxd2 and eth_rxd3 pins Martin Blumenstingl 2019-01-14 8:30 ` Linus Walleij
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®