* [PATCH v1] clk: meson: pll: print out pll name when unable to lock it
@ 2024-03-28 19:57 Dmitry Rokosov
2024-03-29 11:26 ` Jerome Brunet
0 siblings, 1 reply; 2+ messages in thread
From: Dmitry Rokosov @ 2024-03-28 19:57 UTC (permalink / raw)
To: neil.armstrong, jbrunet, mturquette, khilman, martin.blumenstingl, sboyd
Cc: kernel, rockosov, linux-amlogic, linux-clk, linux-kernel,
linux-arm-kernel, Dmitry Rokosov
In most meson systems, multiple PLLs are present, making it difficult to
identify the specific PLL that fails to lock. To address this issue,
print out the name of the PLL that cannot be locked.
Signed-off-by: Dmitry Rokosov <ddrokosov@salutedevices.com>
---
drivers/clk/meson/clk-pll.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/clk/meson/clk-pll.c b/drivers/clk/meson/clk-pll.c
index 6fa7639a3050..78d17b2415af 100644
--- a/drivers/clk/meson/clk-pll.c
+++ b/drivers/clk/meson/clk-pll.c
@@ -436,8 +436,8 @@ static int meson_clk_pll_set_rate(struct clk_hw *hw, unsigned long rate,
ret = meson_clk_pll_enable(hw);
if (ret) {
- pr_warn("%s: pll did not lock, trying to restore old rate %lu\n",
- __func__, old_rate);
+ pr_warn("%s: pll %s didn't lock, trying to set old rate %lu\n",
+ __func__, clk_hw_get_name(hw), old_rate);
/*
* FIXME: Do we really need/want this HACK ?
* It looks unsafe. what happens if the clock gets into a
--
2.43.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 2+ messages in thread* Re: [PATCH v1] clk: meson: pll: print out pll name when unable to lock it
2024-03-28 19:57 [PATCH v1] clk: meson: pll: print out pll name when unable to lock it Dmitry Rokosov
@ 2024-03-29 11:26 ` Jerome Brunet
0 siblings, 0 replies; 2+ messages in thread
From: Jerome Brunet @ 2024-03-29 11:26 UTC (permalink / raw)
To: neil.armstrong, mturquette, khilman, martin.blumenstingl, sboyd,
Dmitry Rokosov
Cc: kernel, rockosov, linux-amlogic, linux-clk, linux-kernel,
linux-arm-kernel
Applied to clk-meson (v6.10/drivers), thanks!
[1/1] clk: meson: pll: print out pll name when unable to lock it
https://github.com/BayLibre/clk-meson/commit/16182ac30a68
Best regards,
--
Jerome
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2024-03-29 11:27 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-03-28 19:57 [PATCH v1] clk: meson: pll: print out pll name when unable to lock it Dmitry Rokosov
2024-03-29 11:26 ` Jerome Brunet
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®