[PATCH 1/2] pinctrl: meson-g12a: add pwm_d option

[PATCH 1/2] pinctrl: meson-g12a: add pwm_d option

[Theo Debrouwere]

Add missing PWM_D pin muxing for GPIOA_4.

Signed-off-by: Theo Debrouwere <theo.debrouwere@faytech.de>
---
 drivers/pinctrl/meson/pinctrl-meson-g12a.c | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/drivers/pinctrl/meson/pinctrl-meson-g12a.c b/drivers/pinctrl/meson/pinctrl-meson-g12a.c
index 32830269a5b4..6d927abbf8d0 100644
--- a/drivers/pinctrl/meson/pinctrl-meson-g12a.c
+++ b/drivers/pinctrl/meson/pinctrl-meson-g12a.c
@@ -277,6 +277,7 @@ static const unsigned int pwm_c_x5_pins[]		= { GPIOX_5 };
 static const unsigned int pwm_c_x8_pins[]		= { GPIOX_8 };
 
 /* pwm_d */
+static const unsigned int pwm_d_a4_pins[]		= { GPIOA_4 };
 static const unsigned int pwm_d_x3_pins[]		= { GPIOX_3 };
 static const unsigned int pwm_d_x6_pins[]		= { GPIOX_6 };
 
@@ -773,6 +774,7 @@ static struct meson_pmx_group meson_g12a_periphs_groups[] = {
 	GROUP(mclk0_a,			1),
 	GROUP(mclk1_a,			2),
 	GROUP(pwm_f_a,			3),
+	GROUP(pwm_d_a4,			3),
 };
 
 /* uart_ao_a */
@@ -1066,7 +1068,7 @@ static const char * const pwm_c_groups[] = {
 };
 
 static const char * const pwm_d_groups[] = {
-	"pwm_d_x3", "pwm_d_x6",
+	"pwm_d_x3", "pwm_d_x6", "pwm_d_a4",
 };
 
 static const char * const pwm_e_groups[] = {
-- 
2.45.2


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

[PATCH 2/2] arm64: dts: meson-g12-common: add pwm_d option

[Theo Debrouwere]

Add PWM_D pin muxing for GPIOA_4.

Signed-off-by: Theo Debrouwere <theo.debrouwere@faytech.de>
---
 arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
index b7baea4c33e3..0f7b6ed47ca2 100644
--- a/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-g12-common.dtsi
@@ -843,6 +843,14 @@ mux {
 						};
 					};
 
+					pwm_d_a4_pins: pwm-d-a4 {
+						mux {
+							groups = "pwm_d_a4";
+							function = "pwm_d";
+							bias-disable;
+						};
+					};
+
 					pwm_e_pins: pwm-e {
 						mux {
 							groups = "pwm_e";
-- 
2.45.2


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH 2/2] arm64: dts: meson-g12-common: add pwm_d option

[Martin Blumenstingl]

Hi Theo,

On Thu, Sep 5, 2024 at 6:46 PM Theo Debrouwere
<theo.debrouwere@gmail.com> wrote:
>
> Add PWM_D pin muxing for GPIOA_4.
Typically we add the pins to the .dtsi once a (new) board.dts requires them.
Are you planning to send other patches that require this new pin definition?

Driver support is independent of this (as we'd otherwise end up in a
long patch chain of boards - requires pins - requires driver changes -
every time we want to support a new mux configuration).


Best regards,
Martin

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH 1/2] pinctrl: meson-g12a: add pwm_d option

[Martin Blumenstingl]

On Thu, Sep 5, 2024 at 6:46 PM Theo Debrouwere
<theo.debrouwere@gmail.com> wrote:
>
> Add missing PWM_D pin muxing for GPIOA_4.
>
> Signed-off-by: Theo Debrouwere <theo.debrouwere@faytech.de>
Reviewed-by: Martin Blumenstingl <martin.blumenstingl@googlemail.com>

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic