[PATCH] arm64: dts: amlogic: meson-sm1-odroid: let the SD card be powered down

[PATCH] arm64: dts: amlogic: meson-sm1-odroid: let the SD card be powered down

[Igor Velkov via B4 Relay]

From: Igor Velkov <iav@iav.lv>

A warm reboot leaves the ODROID-HC4 in the bootloader: the card is still
detected - CID and CSD read fine - but data transfers fail, and both
U-Boot and the boot ROM give up on CMD18. A cold power cycle always
recovers it.

The card is left in UHS mode at 1.8 V, and nothing after Linux brings it
back to 3.3 V: the bootloader resets the controller, not the card. The
kernel does try to cut the power on the way out - mmc_bus_shutdown() ends
in _mmc_sd_suspend(), which calls mmc_power_off(), and meson-gx-mmc then
disables the vmmc regulator - but TFLASH_VDD is marked
regulator-always-on, so the regulator core keeps it enabled and the card
keeps its supply.

Drop the property. The regulator has a consumer that manages it, and
regulator-boot-on already describes the state it comes up in.

Tested on ODROID-HC4 with a card that reproduces the failure. Not tested
on ODROID-C4, which shares this file.

Fixes: 326e57518b0d ("arm64: dts: meson-sm1: add support for Hardkernel ODROID-C4")
Assisted-by: LLM
Signed-off-by: Igor Velkov <iav@iav.lv>
---
 arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi | 1 -
 1 file changed, 1 deletion(-)

diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi
index e6f02d738a21..7dbc75bfaea2 100644
--- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi
@@ -38,7 +38,6 @@ tflash_vdd: regulator-tflash-vdd {
 		gpio = <&gpio_ao GPIOAO_3 GPIO_OPEN_DRAIN>;
 		enable-active-high;
 		regulator-boot-on;
-		regulator-always-on;
 	};
 
 	tf_io: gpio-regulator-tf-io {

---
base-commit: b44e2be772f866985cafdf90355285069ea68495
change-id: 20261003-hc4-sd-power-off-67d3f58f1304

Best regards,
-- 
Igor Velkov <iav@iav.lv>



_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH] arm64: dts: amlogic: meson-sm1-odroid: let the SD card be powered down

[sashiko-bot]

Thank you for your contribution! Sashiko AI review found 1 potential issue(s) to consider:
- [High] dts: amlogic: SD card backpowering due to unpowered VMMC with powered VQMMC
--

commit 4f4437abf57138f198c4057f670c6a5c23c3af61
Author: Igor Velkov <iav@iav.lv>

arm64: dts: amlogic: meson-sm1-odroid: let the SD card be powered down

This commit drops the regulator-always-on property from the SD card's VMMC
supply (tflash_vdd) to allow it to be powered down during a warm reboot.

Fixes: 326e57518b0d ("arm64: dts: meson-sm1: add support for Hardkernel ODROID-C4")

> diff --git a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi
> index e6f02d738a21f..7dbc75bfaea25 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-sm1-odroid.dtsi
> @@ -38,7 +38,6 @@ tflash_vdd: regulator-tflash-vdd {
>  		gpio = <&gpio_ao GPIOAO_3 GPIO_OPEN_DRAIN>;
>  		enable-active-high;
>  		regulator-boot-on;
> -		regulator-always-on;
>  	};
>  
>  	tf_io: gpio-regulator-tf-io {

[Severity: High]
Does removing regulator-always-on from tflash_vdd cause the SD card to be
backpowered during shutdown or warm reboot?

Looking at the sd_emmc_b node, tf_io is configured as the vqmmc-supply
alongside tflash_vdd:

&sd_emmc_b {
	...
	vmmc-supply = <&tflash_vdd>;
	vqmmc-supply = <&tf_io>;
};

However, the tf_io node still retains its regulator-always-on property:

	tf_io: gpio-regulator-tf-io {
		...
		enable-active-high;
		regulator-boot-on;
		regulator-always-on;
	};

When mmc_power_off() disables VMMC (tflash_vdd), VMMC will drop to 0V.
Because tf_io is always-on, the regulator core will ignore the request to
disable VQMMC.

Can this leave the I/O lines driven while the core power is removed, leading
to an unpowered VMMC with a powered VQMMC?

-- 
Sashiko AI review · https://sashiko.dev/#/patchset/20261003-hc4-sd-power-off-v1-1-f7ffba01b348@iav.lv?part=1

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

Re: [PATCH] arm64: dts: amlogic: meson-sm1-odroid: let the SD card be powered down

[Igor Velkov]

Please drop this patch. With the SPI flash erased, so that the boot ROM
loads U-Boot from the SD card, a warm reboot with this change fails 2/2
(the ROM loops on SD:800); compare dc7f2cb218b5 for ODROID-N2. The
4/4 reboots I tested went through U-Boot in SPI flash, which powers the
card itself.

--
Igor Velkov

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic