* Re: [PATCH 18/22] drm/tilcdc: Use GEM DMA fbdev emulation
@ 2023-03-07 14:06 sarha
0 siblings, 0 replies; 3+ messages in thread
From: sarha @ 2023-03-07 14:06 UTC (permalink / raw)
To: Thomas Zimmermann, javierm, maarten.lankhorst, mripard, airlied,
daniel, andrew, laurentiu.palcu, l.stach, shawnguo, s.hauer,
kernel, festevam, linux-imx, p.zabel, anitha.chrisanthus,
edmund.j.dea, khilman, jbrunet, martin.blumenstingl,
alain.volmat, yannick.fertre, raphael.gallais-pou,
philippe.cornu, mcoquelin.stm32, alexandre.torgue,
jernej.skrabec, samuel, jyri.sarha, tomba, linus.walleij,
hyun.kwon, laurent.pinchart
Cc: dri-devel, linux-aspeed, linux-arm-kernel, linux-amlogic,
linux-stm32, linux-sunxi
March 1, 2023 at 5:30 PM, "Thomas Zimmermann" <tzimmermann@suse.de mailto:tzimmermann@suse.de?to=%22Thomas%20Zimmermann%22%20%3Ctzimmermann%40suse.de%3E > wrote:
>
> Use the fbdev emulation that is optimized for DMA helpers. Avoids
> possible shadow buffering and makes the code simpler.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
>
Acked-by: Jyri Sarha <jyri.s
>
> ---
> drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> index 4ca426007dc8..fe56beea3e93 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
> @@ -16,7 +16,7 @@
> #include <drm/drm_atomic_helper.h>
> #include <drm/drm_debugfs.h>
> #include <drm/drm_drv.h>
> -#include <drm/drm_fbdev_generic.h>
> +#include <drm/drm_fbdev_dma.h>
> #include <drm/drm_fourcc.h>
> #include <drm/drm_gem_dma_helper.h>
> #include <drm/drm_gem_framebuffer_helper.h>
> @@ -384,7 +384,7 @@ static int tilcdc_init(const struct drm_driver *ddrv, struct device *dev)
> goto init_failed;
> priv->is_registered = true;
>
> - drm_fbdev_generic_setup(ddev, bpp);
> + drm_fbdev_dma_setup(ddev, bpp);
> return 0;
>
> init_failed:
> --
> 2.39.2
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 00/22] drm/dma-helper: Add dedicated fbdev emulation
@ 2023-03-01 15:30 Thomas Zimmermann
2023-03-01 15:30 ` [PATCH 18/22] drm/tilcdc: Use GEM DMA " Thomas Zimmermann
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Zimmermann @ 2023-03-01 15:30 UTC (permalink / raw)
To: javierm, maarten.lankhorst, mripard, airlied, daniel, andrew,
laurentiu.palcu, l.stach, shawnguo, s.hauer, kernel, festevam,
linux-imx, p.zabel, anitha.chrisanthus, edmund.j.dea, khilman,
jbrunet, martin.blumenstingl, alain.volmat, yannick.fertre,
raphael.gallais-pou, philippe.cornu, mcoquelin.stm32,
alexandre.torgue, jernej.skrabec, samuel, jyri.sarha, tomba,
linus.walleij, hyun.kwon, laurent.pinchart
Cc: dri-devel, linux-aspeed, linux-arm-kernel, linux-amlogic,
linux-stm32, linux-sunxi, Thomas Zimmermann
Add fbdev emulation that is optimized for DMA helpers, as used by most
drivers. It operates directly on GEM DMA buffers in system memory.
Memory pages are mmap'ed directly to userspace. No implicit shadow
buffers need to be allocated; as can happen with the generic fbdev
emulation. Convert drivers that fulfil the requirements.
Tested with fbcon and IGT on vc4.
Future direction: providing a dedicated fbdev emulation for GEM DMA
helpers will allow us to remove this case from the generic fbdev code.
The latter can then be simplified.
Thomas Zimmermann (22):
drm/fbdev-dma: Implement fbdev emulation for GEM DMA helpers
arm/hdlcd: Use GEM DMA fbdev emulation
arm/malidp: Use GEM DMA fbdev emulation
drm/aspeed: Use GEM DMA fbdev emulation
drm/atmel-hlcdc: Use GEM DMA fbdev emulation
drm/fsl-dcu: Use GEM DMA fbdev emulation
drm/imx/dcss: Use GEM DMA fbdev emulation
drm/imx: Use GEM DMA fbdev emulation
drm/kmb: Use GEM DMA fbdev emulation
drm/logicvc: Use GEM DMA fbdev emulation
drm/meson: Use GEM DMA fbdev emulation
drm/mxsfb/lcdif: Use GEM DMA fbdev emulation
drm/mxsfb: Use GEM DMA fbdev emulation
drm/sti: Use GEM DMA fbdev emulation
drm/stm: Use GEM DMA fbdev emulation
drm/sun4i: Use GEM DMA fbdev emulation
drm/tidss: Use GEM DMA fbdev emulation
drm/tilcdc: Use GEM DMA fbdev emulation
drm/arcpgu: Use GEM DMA fbdev emulation
drm/tve200: Use GEM DMA fbdev emulation
drm/vc4: Use GEM DMA fbdev emulation
drm/xlnx: Use GEM DMA fbdev emulation
drivers/gpu/drm/Makefile | 1 +
drivers/gpu/drm/arm/hdlcd_drv.c | 4 +-
drivers/gpu/drm/arm/malidp_drv.c | 4 +-
drivers/gpu/drm/aspeed/aspeed_gfx_drv.c | 4 +-
drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_dc.c | 4 +-
drivers/gpu/drm/drm_fbdev_dma.c | 275 +++++++++++++++++++
drivers/gpu/drm/fsl-dcu/fsl_dcu_drm_drv.c | 4 +-
drivers/gpu/drm/imx/dcss/dcss-kms.c | 4 +-
drivers/gpu/drm/imx/ipuv3/imx-drm-core.c | 4 +-
drivers/gpu/drm/kmb/kmb_drv.c | 4 +-
drivers/gpu/drm/logicvc/logicvc_drm.c | 4 +-
drivers/gpu/drm/meson/meson_drv.c | 4 +-
drivers/gpu/drm/mxsfb/lcdif_drv.c | 4 +-
drivers/gpu/drm/mxsfb/mxsfb_drv.c | 4 +-
drivers/gpu/drm/sti/sti_drv.c | 4 +-
drivers/gpu/drm/stm/drv.c | 4 +-
drivers/gpu/drm/sun4i/sun4i_drv.c | 4 +-
drivers/gpu/drm/tidss/tidss_drv.c | 4 +-
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 +-
drivers/gpu/drm/tiny/arcpgu.c | 4 +-
drivers/gpu/drm/tve200/tve200_drv.c | 4 +-
drivers/gpu/drm/vc4/vc4_drv.c | 4 +-
drivers/gpu/drm/xlnx/zynqmp_kms.c | 4 +-
include/drm/drm_fbdev_dma.h | 15 +
24 files changed, 333 insertions(+), 42 deletions(-)
create mode 100644 drivers/gpu/drm/drm_fbdev_dma.c
create mode 100644 include/drm/drm_fbdev_dma.h
base-commit: 734cd918122f6ec06e4c9366fb3283b29b1c7ea5
prerequisite-patch-id: 0aa359f6144c4015c140c8a6750be19099c676fb
prerequisite-patch-id: c67e5d886a47b7d0266d81100837557fda34cb24
prerequisite-patch-id: 3f204510fcbf9530d6540bd8e6128cce598988b6
--
2.39.2
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH 18/22] drm/tilcdc: Use GEM DMA fbdev emulation
2023-03-01 15:30 [PATCH 00/22] drm/dma-helper: Add dedicated " Thomas Zimmermann
@ 2023-03-01 15:30 ` Thomas Zimmermann
2023-03-09 11:27 ` Javier Martinez Canillas
0 siblings, 1 reply; 3+ messages in thread
From: Thomas Zimmermann @ 2023-03-01 15:30 UTC (permalink / raw)
To: javierm, maarten.lankhorst, mripard, airlied, daniel, andrew,
laurentiu.palcu, l.stach, shawnguo, s.hauer, kernel, festevam,
linux-imx, p.zabel, anitha.chrisanthus, edmund.j.dea, khilman,
jbrunet, martin.blumenstingl, alain.volmat, yannick.fertre,
raphael.gallais-pou, philippe.cornu, mcoquelin.stm32,
alexandre.torgue, jernej.skrabec, samuel, jyri.sarha, tomba,
linus.walleij, hyun.kwon, laurent.pinchart
Cc: dri-devel, linux-aspeed, linux-arm-kernel, linux-amlogic,
linux-stm32, linux-sunxi, Thomas Zimmermann
Use the fbdev emulation that is optimized for DMA helpers. Avoids
possible shadow buffering and makes the code simpler.
Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/tilcdc/tilcdc_drv.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/tilcdc/tilcdc_drv.c b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
index 4ca426007dc8..fe56beea3e93 100644
--- a/drivers/gpu/drm/tilcdc/tilcdc_drv.c
+++ b/drivers/gpu/drm/tilcdc/tilcdc_drv.c
@@ -16,7 +16,7 @@
#include <drm/drm_atomic_helper.h>
#include <drm/drm_debugfs.h>
#include <drm/drm_drv.h>
-#include <drm/drm_fbdev_generic.h>
+#include <drm/drm_fbdev_dma.h>
#include <drm/drm_fourcc.h>
#include <drm/drm_gem_dma_helper.h>
#include <drm/drm_gem_framebuffer_helper.h>
@@ -384,7 +384,7 @@ static int tilcdc_init(const struct drm_driver *ddrv, struct device *dev)
goto init_failed;
priv->is_registered = true;
- drm_fbdev_generic_setup(ddev, bpp);
+ drm_fbdev_dma_setup(ddev, bpp);
return 0;
init_failed:
--
2.39.2
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH 18/22] drm/tilcdc: Use GEM DMA fbdev emulation
2023-03-01 15:30 ` [PATCH 18/22] drm/tilcdc: Use GEM DMA " Thomas Zimmermann
@ 2023-03-09 11:27 ` Javier Martinez Canillas
0 siblings, 0 replies; 3+ messages in thread
From: Javier Martinez Canillas @ 2023-03-09 11:27 UTC (permalink / raw)
To: Thomas Zimmermann, maarten.lankhorst, mripard, airlied, daniel,
andrew, laurentiu.palcu, l.stach, shawnguo, s.hauer, kernel,
festevam, linux-imx, p.zabel, anitha.chrisanthus, edmund.j.dea,
khilman, jbrunet, martin.blumenstingl, alain.volmat,
yannick.fertre, raphael.gallais-pou, philippe.cornu,
mcoquelin.stm32, alexandre.torgue, jernej.skrabec, samuel,
jyri.sarha, tomba, linus.walleij, hyun.kwon, laurent.pinchart
Cc: dri-devel, linux-aspeed, linux-arm-kernel, linux-amlogic,
linux-stm32, linux-sunxi, Thomas Zimmermann
Thomas Zimmermann <tzimmermann@suse.de> writes:
> Use the fbdev emulation that is optimized for DMA helpers. Avoids
> possible shadow buffering and makes the code simpler.
>
> Signed-off-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-03-19 16:02 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-03-07 14:06 [PATCH 18/22] drm/tilcdc: Use GEM DMA fbdev emulation sarha
-- strict thread matches above, loose matches on Subject: below --
2023-03-01 15:30 [PATCH 00/22] drm/dma-helper: Add dedicated " Thomas Zimmermann
2023-03-01 15:30 ` [PATCH 18/22] drm/tilcdc: Use GEM DMA " Thomas Zimmermann
2023-03-09 11:27 ` Javier Martinez Canillas
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®