* [PATCH] pmdomain: amlogic: fix T7 ISP secpower
@ 2025-03-03 9:06 Xianwei Zhao via B4 Relay
2025-03-04 10:15 ` Neil Armstrong
2025-03-05 14:53 ` Ulf Hansson
0 siblings, 2 replies; 3+ messages in thread
From: Xianwei Zhao via B4 Relay @ 2025-03-03 9:06 UTC (permalink / raw)
To: Ulf Hansson, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl
Cc: linux-pm, linux-arm-kernel, linux-amlogic, linux-kernel, Xianwei Zhao
From: Xianwei Zhao <xianwei.zhao@amlogic.com>
ISP and MIPI_ISP, these two have a parent-child relationship,
ISP depends on MIPI_ISP.
Fixes: ca75e4b214c6 ("pmdomain: amlogic: Add support for T7 power domains controller")
Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
---
drivers/pmdomain/amlogic/meson-secure-pwrc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/pmdomain/amlogic/meson-secure-pwrc.c b/drivers/pmdomain/amlogic/meson-secure-pwrc.c
index 42ce41a2fe3a..ff76ea36835e 100644
--- a/drivers/pmdomain/amlogic/meson-secure-pwrc.c
+++ b/drivers/pmdomain/amlogic/meson-secure-pwrc.c
@@ -221,7 +221,7 @@ static const struct meson_secure_pwrc_domain_desc t7_pwrc_domains[] = {
SEC_PD(T7_VI_CLK2, 0),
/* ETH is for ethernet online wakeup, and should be always on */
SEC_PD(T7_ETH, GENPD_FLAG_ALWAYS_ON),
- SEC_PD(T7_ISP, 0),
+ TOP_PD(T7_ISP, 0, PWRC_T7_MIPI_ISP_ID),
SEC_PD(T7_MIPI_ISP, 0),
TOP_PD(T7_GDC, 0, PWRC_T7_NIC3_ID),
TOP_PD(T7_DEWARP, 0, PWRC_T7_NIC3_ID),
---
base-commit: 73e4ffb27bb8a093d557bb2dac1a271474cca99c
change-id: 20250303-fix-t7-pwrc-f33650b190ef
Best regards,
--
Xianwei Zhao <xianwei.zhao@amlogic.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] pmdomain: amlogic: fix T7 ISP secpower
2025-03-03 9:06 [PATCH] pmdomain: amlogic: fix T7 ISP secpower Xianwei Zhao via B4 Relay
@ 2025-03-04 10:15 ` Neil Armstrong
2025-03-05 14:53 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Neil Armstrong @ 2025-03-04 10:15 UTC (permalink / raw)
To: xianwei.zhao, Ulf Hansson, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl
Cc: linux-pm, linux-arm-kernel, linux-amlogic, linux-kernel
On 03/03/2025 10:06, Xianwei Zhao via B4 Relay wrote:
> From: Xianwei Zhao <xianwei.zhao@amlogic.com>
>
> ISP and MIPI_ISP, these two have a parent-child relationship,
> ISP depends on MIPI_ISP.
>
> Fixes: ca75e4b214c6 ("pmdomain: amlogic: Add support for T7 power domains controller")
> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
> ---
> drivers/pmdomain/amlogic/meson-secure-pwrc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pmdomain/amlogic/meson-secure-pwrc.c b/drivers/pmdomain/amlogic/meson-secure-pwrc.c
> index 42ce41a2fe3a..ff76ea36835e 100644
> --- a/drivers/pmdomain/amlogic/meson-secure-pwrc.c
> +++ b/drivers/pmdomain/amlogic/meson-secure-pwrc.c
> @@ -221,7 +221,7 @@ static const struct meson_secure_pwrc_domain_desc t7_pwrc_domains[] = {
> SEC_PD(T7_VI_CLK2, 0),
> /* ETH is for ethernet online wakeup, and should be always on */
> SEC_PD(T7_ETH, GENPD_FLAG_ALWAYS_ON),
> - SEC_PD(T7_ISP, 0),
> + TOP_PD(T7_ISP, 0, PWRC_T7_MIPI_ISP_ID),
> SEC_PD(T7_MIPI_ISP, 0),
> TOP_PD(T7_GDC, 0, PWRC_T7_NIC3_ID),
> TOP_PD(T7_DEWARP, 0, PWRC_T7_NIC3_ID),
>
> ---
> base-commit: 73e4ffb27bb8a093d557bb2dac1a271474cca99c
> change-id: 20250303-fix-t7-pwrc-f33650b190ef
>
> Best regards,
Reviewed-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] pmdomain: amlogic: fix T7 ISP secpower
2025-03-03 9:06 [PATCH] pmdomain: amlogic: fix T7 ISP secpower Xianwei Zhao via B4 Relay
2025-03-04 10:15 ` Neil Armstrong
@ 2025-03-05 14:53 ` Ulf Hansson
1 sibling, 0 replies; 3+ messages in thread
From: Ulf Hansson @ 2025-03-05 14:53 UTC (permalink / raw)
To: xianwei.zhao
Cc: Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl,
linux-pm, linux-arm-kernel, linux-amlogic, linux-kernel
On Mon, 3 Mar 2025 at 10:06, Xianwei Zhao via B4 Relay
<devnull+xianwei.zhao.amlogic.com@kernel.org> wrote:
>
> From: Xianwei Zhao <xianwei.zhao@amlogic.com>
>
> ISP and MIPI_ISP, these two have a parent-child relationship,
> ISP depends on MIPI_ISP.
>
> Fixes: ca75e4b214c6 ("pmdomain: amlogic: Add support for T7 power domains controller")
> Signed-off-by: Xianwei Zhao <xianwei.zhao@amlogic.com>
Applied for fixes and by adding a stable tag, thanks!
Kind regards
Uffe
> ---
> drivers/pmdomain/amlogic/meson-secure-pwrc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pmdomain/amlogic/meson-secure-pwrc.c b/drivers/pmdomain/amlogic/meson-secure-pwrc.c
> index 42ce41a2fe3a..ff76ea36835e 100644
> --- a/drivers/pmdomain/amlogic/meson-secure-pwrc.c
> +++ b/drivers/pmdomain/amlogic/meson-secure-pwrc.c
> @@ -221,7 +221,7 @@ static const struct meson_secure_pwrc_domain_desc t7_pwrc_domains[] = {
> SEC_PD(T7_VI_CLK2, 0),
> /* ETH is for ethernet online wakeup, and should be always on */
> SEC_PD(T7_ETH, GENPD_FLAG_ALWAYS_ON),
> - SEC_PD(T7_ISP, 0),
> + TOP_PD(T7_ISP, 0, PWRC_T7_MIPI_ISP_ID),
> SEC_PD(T7_MIPI_ISP, 0),
> TOP_PD(T7_GDC, 0, PWRC_T7_NIC3_ID),
> TOP_PD(T7_DEWARP, 0, PWRC_T7_NIC3_ID),
>
> ---
> base-commit: 73e4ffb27bb8a093d557bb2dac1a271474cca99c
> change-id: 20250303-fix-t7-pwrc-f33650b190ef
>
> Best regards,
> --
> Xianwei Zhao <xianwei.zhao@amlogic.com>
>
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2025-03-05 14:57 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-03 9:06 [PATCH] pmdomain: amlogic: fix T7 ISP secpower Xianwei Zhao via B4 Relay
2025-03-04 10:15 ` Neil Armstrong
2025-03-05 14:53 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®