From: Neil Armstrong <neil.armstrong@linaro.org>
To: "Adrián Larumbe" <adrian.larumbe@collabora.com>,
narmstrong@baylibre.com, khilman@baylibre.com,
linux-amlogic@lists.infradead.org,
dri-devel@lists.freedesktop.org, rfoss@kernel.org,
andrzej.hajda@intel.com
Cc: kernel@collabora.com
Subject: Re: [PATCH 3/3] dw-hdmi: remove dead code and fix indentation
Date: Tue, 30 May 2023 09:49:15 +0200 [thread overview]
Message-ID: <3b48e709-5bc5-74ed-05a4-2e9909e2f0ed@linaro.org> (raw)
In-Reply-To: <20230528140001.1057084-4-adrian.larumbe@collabora.com>
On 28/05/2023 16:00, Adrián Larumbe wrote:
> Signed-off-by: Adrián Larumbe <adrian.larumbe@collabora.com>
> ---
> drivers/gpu/drm/bridge/synopsys/dw-hdmi.c | 22 ++++------------------
> 1 file changed, 4 insertions(+), 18 deletions(-)
>
> diff --git a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> index 1afb8f2603a0..0accfb51509c 100644
> --- a/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> +++ b/drivers/gpu/drm/bridge/synopsys/dw-hdmi.c
> @@ -49,20 +49,6 @@
>
> #define HDMI14_MAX_TMDSCLK 340000000
>
> -enum hdmi_datamap {
> - RGB444_8B = 0x01,
> - RGB444_10B = 0x03,
> - RGB444_12B = 0x05,
> - RGB444_16B = 0x07,
> - YCbCr444_8B = 0x09,
> - YCbCr444_10B = 0x0B,
> - YCbCr444_12B = 0x0D,
> - YCbCr444_16B = 0x0F,
> - YCbCr422_8B = 0x16,
> - YCbCr422_10B = 0x14,
> - YCbCr422_12B = 0x12,
> -};
> -
> static const u16 csc_coeff_default[3][4] = {
> { 0x2000, 0x0000, 0x0000, 0x0000 },
> { 0x0000, 0x2000, 0x0000, 0x0000 },
> @@ -856,10 +842,10 @@ static void dw_hdmi_gp_audio_enable(struct dw_hdmi *hdmi)
>
> if (pdata->enable_audio)
> pdata->enable_audio(hdmi,
> - hdmi->channels,
> - hdmi->sample_width,
> - hdmi->sample_rate,
> - hdmi->sample_non_pcm);
> + hdmi->channels,
> + hdmi->sample_width,
> + hdmi->sample_rate,
> + hdmi->sample_non_pcm);
> }
>
> static void dw_hdmi_gp_audio_disable(struct dw_hdmi *hdmi)
With proper commit description:
Acked-by: Neil Armstrong <neil.armstrong@linaro.org>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2023-05-30 7:49 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-28 13:59 [PATCH 0/3] Add additional YUV420 bus format check for dw-meson's bridge enable Adrián Larumbe
2023-05-28 13:59 ` [PATCH 1/3] drm/meson: dw-hdmi: change YUV420 selection logic at clock setup Adrián Larumbe
2023-05-30 7:48 ` Neil Armstrong
2023-05-28 14:00 ` [PATCH 2/3] dw-hdmi: truly enforce 420-only formats when drm mode demands it Adrián Larumbe
2023-05-30 7:46 ` Neil Armstrong
2023-05-28 14:00 ` [PATCH 3/3] dw-hdmi: remove dead code and fix indentation Adrián Larumbe
2023-05-29 8:40 ` AngeloGioacchino Del Regno
2023-05-30 7:49 ` Neil Armstrong [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3b48e709-5bc5-74ed-05a4-2e9909e2f0ed@linaro.org \
--to=neil.armstrong@linaro.org \
--cc=adrian.larumbe@collabora.com \
--cc=andrzej.hajda@intel.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kernel@collabora.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=narmstrong@baylibre.com \
--cc=rfoss@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®