From: Krzysztof Kozlowski <krzk@kernel.org>
To: xianwei.zhao@amlogic.com, Sunny Luo <sunny.luo@amlogic.com>,
Mark Brown <broonie@kernel.org>, Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>
Cc: linux-amlogic@lists.infradead.org, linux-spi@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Conor Dooley <conor.dooley@microchip.com>
Subject: Re: [PATCH v3 1/3] dt-bindings: spi: Add binding document of Amlogic SPISG controller
Date: Mon, 23 Jun 2025 11:15:18 +0200 [thread overview]
Message-ID: <45514054-1bb0-450c-bff6-ffdf491417b1@kernel.org> (raw)
In-Reply-To: <20250623-spisg-v3-1-c731f57e289c@amlogic.com>
On 23/06/2025 10:53, Xianwei Zhao via B4 Relay wrote:
Please use subject prefixes matching the subsystem. You can get them for
example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
your patch is touching. For bindings, the preferred subjects are
explained here:
https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
> +properties:
> + compatible:
> + const: amlogic,a4-spisg
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + minItems: 2
Nope, maxItems. Look at other bindings.
> +
> + clock-names:
> + items:
> + - const: core
> + - const: pclk
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> +
> +unevaluatedProperties: false
> +
> +examples:
> + - |
> + spi@50000 {
> + compatible = "amlogic,a4-spisg";
> + reg = <0x50000 0x38>;
> + interrupts = <0 183 4>;
Use proper defines
Best regards,
Krzysztof
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2025-06-23 9:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-23 8:53 [PATCH v3 0/3] support for amlogic the new SPI IP Xianwei Zhao via B4 Relay
2025-06-23 8:53 ` [PATCH v3 1/3] dt-bindings: spi: Add binding document of Amlogic SPISG controller Xianwei Zhao via B4 Relay
2025-06-23 9:15 ` Krzysztof Kozlowski [this message]
2025-06-24 9:05 ` Xianwei Zhao
2025-06-23 8:53 ` [PATCH v3 2/3] spi: Add Amlogic SPISG driver Xianwei Zhao via B4 Relay
2025-06-23 9:17 ` Krzysztof Kozlowski
2025-06-24 9:52 ` Xianwei Zhao
2025-06-23 8:53 ` [PATCH v3 3/3] MAINTAINERS: Add an entry for Amlogic spi driver Xianwei Zhao via B4 Relay
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=45514054-1bb0-450c-bff6-ffdf491417b1@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=conor+dt@kernel.org \
--cc=conor.dooley@microchip.com \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=robh@kernel.org \
--cc=sunny.luo@amlogic.com \
--cc=xianwei.zhao@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®