Re: [PATCH v3 1/3] dt-bindings: spi: Add binding document of Amlogic SPISG controller

[Xianwei Zhao <xianwei.zhao@amlogic.com>]

Hi Krzysztof,
    Thanks for your reply.

On 2025/6/23 17:15, Krzysztof Kozlowski wrote:
> [ EXTERNAL EMAIL ]
> 
> On 23/06/2025 10:53, Xianwei Zhao via B4 Relay wrote:
> 
> Please use subject prefixes matching the subsystem. You can get them for
> example with `git log --oneline -- DIRECTORY_OR_FILE` on the directory
> your patch is touching. For bindings, the preferred subjects are
> explained here:
> https://www.kernel.org/doc/html/latest/devicetree/bindings/submitting-patches.html#i-for-patch-submitters
> 

Will fix subjects "spi: dt-bindings: Add binding document of Amlogic 
SPISG controller"

>> +properties:
>> +  compatible:
>> +    const: amlogic,a4-spisg
>> +
>> +  reg:
>> +    maxItems: 1
>> +
>> +  interrupts:
>> +    maxItems: 1
>> +
>> +  clocks:
>> +    minItems: 2
> 
> Nope, maxItems. Look at other bindings.
> 

Will do.

>> +
>> +  clock-names:
>> +    items:
>> +      - const: core
>> +      - const: pclk
>> +
>> +required:
>> +  - compatible
>> +  - reg
>> +  - interrupts
>> +  - clocks
>> +  - clock-names
>> +
>> +unevaluatedProperties: false
>> +
>> +examples:
>> +  - |
>> +    spi@50000 {
>> +        compatible = "amlogic,a4-spisg";
>> +        reg = <0x50000 0x38>;
>> +        interrupts = <0 183 4>;
> 
> Use proper defines
> 
Will modify "interrupts = <GIC_SPI 183 IRQ_TYPE_LEVEL_HIGH>;"
> 
> 
> Best regards,
> Krzysztof

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic