* [PATCH] phy: meson-usb2: Fix build dependency
[not found] <1473991635-27973-1-git-send-email-axel.lin@ingics.com>
@ 2016-09-18 21:41 ` Martin Blumenstingl
2016-09-19 16:44 ` Kevin Hilman
0 siblings, 1 reply; 6+ messages in thread
From: Martin Blumenstingl @ 2016-09-18 21:41 UTC (permalink / raw)
To: linus-amlogic
Hi Axel,
On Fri, Sep 16, 2016 at 4:07 AM, Axel Lin <axel.lin@ingics.com> wrote:
> of_usb_get_dr_mode_by_phy will not be compiled if !USB_COMMON, fix below
> build error:
>
> drivers/built-in.o: In function `phy_meson_usb2_probe':
> debugfs.c:(.text+0x76b4): undefined reference to `of_usb_get_dr_mode_by_phy'
> Makefile:961: recipe for target 'vmlinux' failed
> make: *** [vmlinux] Error 1
>
> Signed-off-by: Axel Lin <axel.lin@ingics.com>
> ---
> drivers/phy/Kconfig | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
> index 6ad87ec..cc27c12 100644
> --- a/drivers/phy/Kconfig
> +++ b/drivers/phy/Kconfig
> @@ -458,6 +458,8 @@ config PHY_MESON_USB2
> tristate "Meson USB2 PHY driver"
> default ARCH_MESON
> depends on OF && (ARCH_MESON || COMPILE_TEST)
> + depends on USB_SUPPORT
> + select USB_COMMON
> select GENERIC_PHY
> help
> Enable this to support the Meson USB2 PHYs found in Meson8b
> --
> 2.7.4
>
thanks for this patch!
How do we handle patches for drivers which will (unfortunately) not
land in the linux 4.8 - should I integrate that into v3 of the patch
(which I'll have to send anyways) or do we keep them separate?
Maybe Kishon and/or Kevin can share their opinion on this.
Regards,
Martin
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] phy: meson-usb2: Fix build dependency
2016-09-18 21:41 ` [PATCH] phy: meson-usb2: Fix build dependency Martin Blumenstingl
@ 2016-09-19 16:44 ` Kevin Hilman
2016-09-21 4:06 ` Kishon Vijay Abraham I
0 siblings, 1 reply; 6+ messages in thread
From: Kevin Hilman @ 2016-09-19 16:44 UTC (permalink / raw)
To: linus-amlogic
Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:
> Hi Axel,
>
> On Fri, Sep 16, 2016 at 4:07 AM, Axel Lin <axel.lin@ingics.com> wrote:
>> of_usb_get_dr_mode_by_phy will not be compiled if !USB_COMMON, fix below
>> build error:
>>
>> drivers/built-in.o: In function `phy_meson_usb2_probe':
>> debugfs.c:(.text+0x76b4): undefined reference to `of_usb_get_dr_mode_by_phy'
>> Makefile:961: recipe for target 'vmlinux' failed
>> make: *** [vmlinux] Error 1
>>
>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>> ---
>> drivers/phy/Kconfig | 2 ++
>> 1 file changed, 2 insertions(+)
>>
>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
>> index 6ad87ec..cc27c12 100644
>> --- a/drivers/phy/Kconfig
>> +++ b/drivers/phy/Kconfig
>> @@ -458,6 +458,8 @@ config PHY_MESON_USB2
>> tristate "Meson USB2 PHY driver"
>> default ARCH_MESON
>> depends on OF && (ARCH_MESON || COMPILE_TEST)
>> + depends on USB_SUPPORT
>> + select USB_COMMON
>> select GENERIC_PHY
>> help
>> Enable this to support the Meson USB2 PHYs found in Meson8b
>> --
>> 2.7.4
>>
> thanks for this patch!
>
> How do we handle patches for drivers which will (unfortunately) not
> land in the linux 4.8 - should I integrate that into v3 of the patch
> (which I'll have to send anyways) or do we keep them separate?
> Maybe Kishon and/or Kevin can share their opinion on this.
It's up to Kishon if he wants a v3, or if he can fold in the fix
himself.
Kevin
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] phy: meson-usb2: Fix build dependency
2016-09-19 16:44 ` Kevin Hilman
@ 2016-09-21 4:06 ` Kishon Vijay Abraham I
2016-09-21 4:13 ` Axel Lin
0 siblings, 1 reply; 6+ messages in thread
From: Kishon Vijay Abraham I @ 2016-09-21 4:06 UTC (permalink / raw)
To: linus-amlogic
On Monday 19 September 2016 10:14 PM, Kevin Hilman wrote:
> Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:
>
>> Hi Axel,
>>
>> On Fri, Sep 16, 2016 at 4:07 AM, Axel Lin <axel.lin@ingics.com> wrote:
>>> of_usb_get_dr_mode_by_phy will not be compiled if !USB_COMMON, fix below
>>> build error:
>>>
>>> drivers/built-in.o: In function `phy_meson_usb2_probe':
>>> debugfs.c:(.text+0x76b4): undefined reference to `of_usb_get_dr_mode_by_phy'
>>> Makefile:961: recipe for target 'vmlinux' failed
>>> make: *** [vmlinux] Error 1
>>>
>>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>>> ---
>>> drivers/phy/Kconfig | 2 ++
>>> 1 file changed, 2 insertions(+)
>>>
>>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
>>> index 6ad87ec..cc27c12 100644
>>> --- a/drivers/phy/Kconfig
>>> +++ b/drivers/phy/Kconfig
>>> @@ -458,6 +458,8 @@ config PHY_MESON_USB2
>>> tristate "Meson USB2 PHY driver"
>>> default ARCH_MESON
>>> depends on OF && (ARCH_MESON || COMPILE_TEST)
>>> + depends on USB_SUPPORT
>>> + select USB_COMMON
>>> select GENERIC_PHY
>>> help
>>> Enable this to support the Meson USB2 PHYs found in Meson8b
>>> --
>>> 2.7.4
>>>
>> thanks for this patch!
>>
>> How do we handle patches for drivers which will (unfortunately) not
>> land in the linux 4.8 - should I integrate that into v3 of the patch
>> (which I'll have to send anyways) or do we keep them separate?
>> Maybe Kishon and/or Kevin can share their opinion on this.
Since you are anyways planning to send v3, merge this patch too.
Thanks
Kishon
>
> It's up to Kishon if he wants a v3, or if he can fold in the fix
> himself.
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] phy: meson-usb2: Fix build dependency
2016-09-21 4:06 ` Kishon Vijay Abraham I
@ 2016-09-21 4:13 ` Axel Lin
2016-09-21 5:11 ` Kevin Hilman
2016-09-26 5:03 ` Kishon Vijay Abraham I
0 siblings, 2 replies; 6+ messages in thread
From: Axel Lin @ 2016-09-21 4:13 UTC (permalink / raw)
To: linus-amlogic
2016-09-21 12:06 GMT+08:00 Kishon Vijay Abraham I <kishon@ti.com>:
>
>
> On Monday 19 September 2016 10:14 PM, Kevin Hilman wrote:
>> Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:
>>
>>> Hi Axel,
>>>
>>> On Fri, Sep 16, 2016 at 4:07 AM, Axel Lin <axel.lin@ingics.com> wrote:
>>>> of_usb_get_dr_mode_by_phy will not be compiled if !USB_COMMON, fix below
>>>> build error:
>>>>
>>>> drivers/built-in.o: In function `phy_meson_usb2_probe':
>>>> debugfs.c:(.text+0x76b4): undefined reference to `of_usb_get_dr_mode_by_phy'
>>>> Makefile:961: recipe for target 'vmlinux' failed
>>>> make: *** [vmlinux] Error 1
>>>>
>>>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>>>> ---
>>>> drivers/phy/Kconfig | 2 ++
>>>> 1 file changed, 2 insertions(+)
>>>>
>>>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
>>>> index 6ad87ec..cc27c12 100644
>>>> --- a/drivers/phy/Kconfig
>>>> +++ b/drivers/phy/Kconfig
>>>> @@ -458,6 +458,8 @@ config PHY_MESON_USB2
>>>> tristate "Meson USB2 PHY driver"
>>>> default ARCH_MESON
>>>> depends on OF && (ARCH_MESON || COMPILE_TEST)
>>>> + depends on USB_SUPPORT
>>>> + select USB_COMMON
>>>> select GENERIC_PHY
>>>> help
>>>> Enable this to support the Meson USB2 PHYs found in Meson8b
>>>> --
>>>> 2.7.4
>>>>
>>> thanks for this patch!
>>>
>>> How do we handle patches for drivers which will (unfortunately) not
>>> land in the linux 4.8 - should I integrate that into v3 of the patch
>>> (which I'll have to send anyways) or do we keep them separate?
>>> Maybe Kishon and/or Kevin can share their opinion on this.
>
> Since you are anyways planning to send v3, merge this patch too.
I got confused why this driver appears in linux-next but it's not from phy
tree? I thought it's because other dependency so it needs to go via other tree,
but looks like not the case. And the driver does not get Kishon's Ack?
BTW, Kishon, do you consider to add phy tree to linux-next?
Axel
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] phy: meson-usb2: Fix build dependency
2016-09-21 4:13 ` Axel Lin
@ 2016-09-21 5:11 ` Kevin Hilman
2016-09-26 5:03 ` Kishon Vijay Abraham I
1 sibling, 0 replies; 6+ messages in thread
From: Kevin Hilman @ 2016-09-21 5:11 UTC (permalink / raw)
To: linus-amlogic
On Tue, Sep 20, 2016 at 9:13 PM, Axel Lin <axel.lin@ingics.com> wrote:
> 2016-09-21 12:06 GMT+08:00 Kishon Vijay Abraham I <kishon@ti.com>:
>>
>>
>> On Monday 19 September 2016 10:14 PM, Kevin Hilman wrote:
>>> Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:
>>>
>>>> Hi Axel,
>>>>
>>>> On Fri, Sep 16, 2016 at 4:07 AM, Axel Lin <axel.lin@ingics.com> wrote:
>>>>> of_usb_get_dr_mode_by_phy will not be compiled if !USB_COMMON, fix below
>>>>> build error:
>>>>>
>>>>> drivers/built-in.o: In function `phy_meson_usb2_probe':
>>>>> debugfs.c:(.text+0x76b4): undefined reference to `of_usb_get_dr_mode_by_phy'
>>>>> Makefile:961: recipe for target 'vmlinux' failed
>>>>> make: *** [vmlinux] Error 1
>>>>>
>>>>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>>>>> ---
>>>>> drivers/phy/Kconfig | 2 ++
>>>>> 1 file changed, 2 insertions(+)
>>>>>
>>>>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
>>>>> index 6ad87ec..cc27c12 100644
>>>>> --- a/drivers/phy/Kconfig
>>>>> +++ b/drivers/phy/Kconfig
>>>>> @@ -458,6 +458,8 @@ config PHY_MESON_USB2
>>>>> tristate "Meson USB2 PHY driver"
>>>>> default ARCH_MESON
>>>>> depends on OF && (ARCH_MESON || COMPILE_TEST)
>>>>> + depends on USB_SUPPORT
>>>>> + select USB_COMMON
>>>>> select GENERIC_PHY
>>>>> help
>>>>> Enable this to support the Meson USB2 PHYs found in Meson8b
>>>>> --
>>>>> 2.7.4
>>>>>
>>>> thanks for this patch!
>>>>
>>>> How do we handle patches for drivers which will (unfortunately) not
>>>> land in the linux 4.8 - should I integrate that into v3 of the patch
>>>> (which I'll have to send anyways) or do we keep them separate?
>>>> Maybe Kishon and/or Kevin can share their opinion on this.
>>
>> Since you are anyways planning to send v3, merge this patch too.
>
> I got confused why this driver appears in linux-next but it's not from phy
> tree? I thought it's because other dependency so it needs to go via other tree,
> but looks like not the case. And the driver does not get Kishon's Ack?
That was my fault, it got (mistakenly) included in the branch I submit
to linux-next for the amlogic SoC support.
Kevin
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH] phy: meson-usb2: Fix build dependency
2016-09-21 4:13 ` Axel Lin
2016-09-21 5:11 ` Kevin Hilman
@ 2016-09-26 5:03 ` Kishon Vijay Abraham I
1 sibling, 0 replies; 6+ messages in thread
From: Kishon Vijay Abraham I @ 2016-09-26 5:03 UTC (permalink / raw)
To: linus-amlogic
On Wednesday 21 September 2016 09:43 AM, Axel Lin wrote:
> 2016-09-21 12:06 GMT+08:00 Kishon Vijay Abraham I <kishon@ti.com>:
>>
>>
>> On Monday 19 September 2016 10:14 PM, Kevin Hilman wrote:
>>> Martin Blumenstingl <martin.blumenstingl@googlemail.com> writes:
>>>
>>>> Hi Axel,
>>>>
>>>> On Fri, Sep 16, 2016 at 4:07 AM, Axel Lin <axel.lin@ingics.com> wrote:
>>>>> of_usb_get_dr_mode_by_phy will not be compiled if !USB_COMMON, fix below
>>>>> build error:
>>>>>
>>>>> drivers/built-in.o: In function `phy_meson_usb2_probe':
>>>>> debugfs.c:(.text+0x76b4): undefined reference to `of_usb_get_dr_mode_by_phy'
>>>>> Makefile:961: recipe for target 'vmlinux' failed
>>>>> make: *** [vmlinux] Error 1
>>>>>
>>>>> Signed-off-by: Axel Lin <axel.lin@ingics.com>
>>>>> ---
>>>>> drivers/phy/Kconfig | 2 ++
>>>>> 1 file changed, 2 insertions(+)
>>>>>
>>>>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
>>>>> index 6ad87ec..cc27c12 100644
>>>>> --- a/drivers/phy/Kconfig
>>>>> +++ b/drivers/phy/Kconfig
>>>>> @@ -458,6 +458,8 @@ config PHY_MESON_USB2
>>>>> tristate "Meson USB2 PHY driver"
>>>>> default ARCH_MESON
>>>>> depends on OF && (ARCH_MESON || COMPILE_TEST)
>>>>> + depends on USB_SUPPORT
>>>>> + select USB_COMMON
>>>>> select GENERIC_PHY
>>>>> help
>>>>> Enable this to support the Meson USB2 PHYs found in Meson8b
>>>>> --
>>>>> 2.7.4
>>>>>
>>>> thanks for this patch!
>>>>
>>>> How do we handle patches for drivers which will (unfortunately) not
>>>> land in the linux 4.8 - should I integrate that into v3 of the patch
>>>> (which I'll have to send anyways) or do we keep them separate?
>>>> Maybe Kishon and/or Kevin can share their opinion on this.
>>
>> Since you are anyways planning to send v3, merge this patch too.
>
> I got confused why this driver appears in linux-next but it's not from phy
> tree? I thought it's because other dependency so it needs to go via other tree,
> but looks like not the case. And the driver does not get Kishon's Ack?
>
> BTW, Kishon, do you consider to add phy tree to linux-next?
yes.. that's been pending for a long time.
-Kishon
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2016-09-26 5:03 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <1473991635-27973-1-git-send-email-axel.lin@ingics.com>
2016-09-18 21:41 ` [PATCH] phy: meson-usb2: Fix build dependency Martin Blumenstingl
2016-09-19 16:44 ` Kevin Hilman
2016-09-21 4:06 ` Kishon Vijay Abraham I
2016-09-21 4:13 ` Axel Lin
2016-09-21 5:11 ` Kevin Hilman
2016-09-26 5:03 ` Kishon Vijay Abraham I
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®