* [PATCH v1] arm64: dts: amlogic: meson-axg: pinctrl node for NAND
@ 2023-11-09 5:30 Arseniy Krasnov
2023-11-09 8:54 ` Krzysztof Kozlowski
0 siblings, 1 reply; 3+ messages in thread
From: Arseniy Krasnov @ 2023-11-09 5:30 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Neil Armstrong,
Kevin Hilman, Jerome Brunet, Martin Blumenstingl
Cc: oxffffaa, kernel, Liang Yang, Arseniy Krasnov, devicetree,
linux-arm-kernel, linux-amlogic, linux-kernel
Add pinctrl node for the Meson NAND controller.
Signed-off-by: Arseniy Krasnov <avkrasnov@salutedevices.com>
---
arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 23 ++++++++++++++++++++++
1 file changed, 23 insertions(+)
diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
index a49aa62e3f9f..98a17953e969 100644
--- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
+++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
@@ -432,6 +432,27 @@ mux-1 {
};
};
+ nand_all_pins: nand_all_pins {
+ mux {
+ groups = "emmc_nand_d0",
+ "emmc_nand_d1",
+ "emmc_nand_d2",
+ "emmc_nand_d3",
+ "emmc_nand_d4",
+ "emmc_nand_d5",
+ "emmc_nand_d6",
+ "emmc_nand_d7",
+ "nand_ce0",
+ "nand_ale",
+ "nand_cle",
+ "nand_wen_clk",
+ "nand_ren_wr";
+ function = "nand";
+ input-enable;
+ bias-pull-up;
+ };
+ };
+
emmc_ds_pins: emmc_ds {
mux {
groups = "emmc_ds";
@@ -1913,6 +1934,8 @@ nfc: nand-controller@7800 {
reg = <0x0 0x7800 0x0 0x100>,
<0x0 0x7000 0x0 0x800>;
reg-names = "nfc", "emmc";
+ pinctrl-0 = <&nand_all_pins>;
+ pinctrl-names = "default";
#address-cells = <1>;
#size-cells = <0>;
interrupts = <GIC_SPI 34 IRQ_TYPE_EDGE_RISING>;
--
2.35.0
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] arm64: dts: amlogic: meson-axg: pinctrl node for NAND
2023-11-09 5:30 [PATCH v1] arm64: dts: amlogic: meson-axg: pinctrl node for NAND Arseniy Krasnov
@ 2023-11-09 8:54 ` Krzysztof Kozlowski
2023-11-09 9:46 ` Arseniy Krasnov
0 siblings, 1 reply; 3+ messages in thread
From: Krzysztof Kozlowski @ 2023-11-09 8:54 UTC (permalink / raw)
To: Arseniy Krasnov, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Neil Armstrong, Kevin Hilman, Jerome Brunet, Martin Blumenstingl
Cc: oxffffaa, kernel, Liang Yang, devicetree, linux-arm-kernel,
linux-amlogic, linux-kernel
On 09/11/2023 06:30, Arseniy Krasnov wrote:
> Add pinctrl node for the Meson NAND controller.
>
> Signed-off-by: Arseniy Krasnov <avkrasnov@salutedevices.com>
> ---
> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 23 ++++++++++++++++++++++
> 1 file changed, 23 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> index a49aa62e3f9f..98a17953e969 100644
> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
> @@ -432,6 +432,27 @@ mux-1 {
> };
> };
>
> + nand_all_pins: nand_all_pins {
No underscores in node names. Doesn't dtbs_check point it?
Best regards,
Krzysztof
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v1] arm64: dts: amlogic: meson-axg: pinctrl node for NAND
2023-11-09 8:54 ` Krzysztof Kozlowski
@ 2023-11-09 9:46 ` Arseniy Krasnov
0 siblings, 0 replies; 3+ messages in thread
From: Arseniy Krasnov @ 2023-11-09 9:46 UTC (permalink / raw)
To: Krzysztof Kozlowski, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Neil Armstrong, Kevin Hilman, Jerome Brunet,
Martin Blumenstingl
Cc: oxffffaa, kernel, Liang Yang, devicetree, linux-arm-kernel,
linux-amlogic, linux-kernel
On 09.11.2023 11:54, Krzysztof Kozlowski wrote:
> On 09/11/2023 06:30, Arseniy Krasnov wrote:
>> Add pinctrl node for the Meson NAND controller.
>>
>> Signed-off-by: Arseniy Krasnov <avkrasnov@salutedevices.com>
>> ---
>> arch/arm64/boot/dts/amlogic/meson-axg.dtsi | 23 ++++++++++++++++++++++
>> 1 file changed, 23 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>> index a49aa62e3f9f..98a17953e969 100644
>> --- a/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>> +++ b/arch/arm64/boot/dts/amlogic/meson-axg.dtsi
>> @@ -432,6 +432,27 @@ mux-1 {
>> };
>> };
>>
>> + nand_all_pins: nand_all_pins {
>
> No underscores in node names. Doesn't dtbs_check point it?
Ok, thanks, done in v2! No, dtbs_check passes ok in my case
Thanks, Arseniy
>
> Best regards,
> Krzysztof
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2023-11-09 9:54 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-11-09 5:30 [PATCH v1] arm64: dts: amlogic: meson-axg: pinctrl node for NAND Arseniy Krasnov
2023-11-09 8:54 ` Krzysztof Kozlowski
2023-11-09 9:46 ` Arseniy Krasnov
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®