* [PATCH] soc: amlogic: canvas: add missing put_device() call in meson_canvas_get()
@ 2020-11-17 1:13 Yu Kuai
2020-11-17 8:32 ` Neil Armstrong
0 siblings, 1 reply; 2+ messages in thread
From: Yu Kuai @ 2020-11-17 1:13 UTC (permalink / raw)
To: khilman
Cc: yi.zhang, linux-kernel, yukuai3, linux-amlogic, zhangxiaoxu5,
linux-arm-kernel
if of_find_device_by_node() succeed, meson_canvas_get() doesn't have
a corresponding put_device(). Thus add put_device() to fix the exception
handling for this function implementation.
Fixes: commit 382f8be04551 ("soc: amlogic: canvas: Fix meson_canvas_get when probe failed")
Signed-off-by: Yu Kuai <yukuai3@huawei.com>
---
drivers/soc/amlogic/meson-canvas.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/soc/amlogic/meson-canvas.c b/drivers/soc/amlogic/meson-canvas.c
index c655f5f92b12..d0329ad170d1 100644
--- a/drivers/soc/amlogic/meson-canvas.c
+++ b/drivers/soc/amlogic/meson-canvas.c
@@ -72,8 +72,10 @@ struct meson_canvas *meson_canvas_get(struct device *dev)
* current state, this driver probe cannot return -EPROBE_DEFER
*/
canvas = dev_get_drvdata(&canvas_pdev->dev);
- if (!canvas)
+ if (!canvas) {
+ put_device(&canvas_pdev->dev);
return ERR_PTR(-EINVAL);
+ }
return canvas;
}
--
2.25.4
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] soc: amlogic: canvas: add missing put_device() call in meson_canvas_get()
2020-11-17 1:13 [PATCH] soc: amlogic: canvas: add missing put_device() call in meson_canvas_get() Yu Kuai
@ 2020-11-17 8:32 ` Neil Armstrong
0 siblings, 0 replies; 2+ messages in thread
From: Neil Armstrong @ 2020-11-17 8:32 UTC (permalink / raw)
To: Yu Kuai, khilman
Cc: linux-amlogic, zhangxiaoxu5, linux-kernel, linux-arm-kernel, yi.zhang
On 17/11/2020 02:13, Yu Kuai wrote:
> if of_find_device_by_node() succeed, meson_canvas_get() doesn't have
> a corresponding put_device(). Thus add put_device() to fix the exception
> handling for this function implementation.
>
> Fixes: commit 382f8be04551 ("soc: amlogic: canvas: Fix meson_canvas_get when probe failed")
> Signed-off-by: Yu Kuai <yukuai3@huawei.com>
> ---
> drivers/soc/amlogic/meson-canvas.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/soc/amlogic/meson-canvas.c b/drivers/soc/amlogic/meson-canvas.c
> index c655f5f92b12..d0329ad170d1 100644
> --- a/drivers/soc/amlogic/meson-canvas.c
> +++ b/drivers/soc/amlogic/meson-canvas.c
> @@ -72,8 +72,10 @@ struct meson_canvas *meson_canvas_get(struct device *dev)
> * current state, this driver probe cannot return -EPROBE_DEFER
> */
> canvas = dev_get_drvdata(&canvas_pdev->dev);
> - if (!canvas)
> + if (!canvas) {
> + put_device(&canvas_pdev->dev);
> return ERR_PTR(-EINVAL);
> + }
>
> return canvas;
> }
>
Reviewed-by: Neil Armstrong <narmstrong@baylibre.com>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-11-17 8:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-11-17 1:13 [PATCH] soc: amlogic: canvas: add missing put_device() call in meson_canvas_get() Yu Kuai
2020-11-17 8:32 ` Neil Armstrong
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®