From: Xianwei Zhao <xianwei.zhao@amlogic.com>
To: Markus Elfring <Markus.Elfring@web.de>,
Junyi Zhao <junyi.zhao@amlogic.com>,
linux-amlogic@lists.infradead.org, linux-i2c@vger.kernel.org,
devicetree@vger.kernel.org, Andi Shyti <andi.shyti@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Rob Herring <robh@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/2] i2c: amlogic: Add Amlogic A9 I2C controller driver
Date: Mon, 2 Nov 2026 13:17:07 +0800 [thread overview]
Message-ID: <9a654737-fa21-4c6c-878e-7a4d69e65b70@amlogic.com> (raw)
In-Reply-To: <fa1813ed-c908-47f8-8176-24b8fb5acfd7@web.de>
Hi Markus,
Thanks for your advice.
On 2026/10/31 16:09, Markus Elfring wrote:
> …
>> +++ b/drivers/i2c/busses/i2c-amlogic-a9.c
>> @@ -0,0 +1,445 @@
> …
>> +static int aml_i2c_xfer_msg(struct aml_i2c *i2c, struct i2c_msg *msg, bool last)
>> +{
> …
>> + if (!time_left) {
>> + spin_lock_irqsave(&i2c->lock, flags);
>> + i2c->state = A9_STATE_IDLE;
>> + clear_irq_status(i2c, IRQ_ALL_MASK);
>> + reset_fifo_pos(i2c);
>> + spin_unlock_irqrestore(&i2c->lock, flags);
>> + return -ETIMEDOUT;
>> + }
> …
>
> Under which circumstances would you become interested to apply a statement
> like “guard(spinlock_irqsave)(&i2c->lock);”?
> https://elixir.bootlin.com/linux/v7.3/source/include/linux/spinlock.h#L642-L645
>
Will do.
> Regards,
> Markus
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
prev parent reply other threads:[~2026-11-02 5:17 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 8:33 [PATCH v3 0/2] i2c: Add driver support Amlogic A9 I2C Xianwei Zhao via B4 Relay
2026-10-29 8:33 ` [PATCH v3 1/2] dt-bindings: i2c: add Amlogic A9 I2C controller Xianwei Zhao via B4 Relay
2026-10-29 18:38 ` Conor Dooley
2026-10-29 8:33 ` [PATCH v3 2/2] i2c: amlogic: Add Amlogic A9 I2C controller driver Xianwei Zhao via B4 Relay
2026-10-29 8:48 ` sashiko-bot
2026-10-30 9:27 ` Xianwei Zhao
2026-10-31 8:09 ` Markus Elfring
2026-11-02 5:17 ` Xianwei Zhao [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9a654737-fa21-4c6c-878e-7a4d69e65b70@amlogic.com \
--to=xianwei.zhao@amlogic.com \
--cc=Markus.Elfring@web.de \
--cc=andi.shyti@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=junyi.zhao@amlogic.com \
--cc=krzk+dt@kernel.org \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®