Re: [PATCH 2/3] dt-bindings: media: Add compatible for Meson-S4 IR Controller

From: Zelong Dong <Zelong.Dong@amlogic.com>
To: neil.armstrong@linaro.org, Sean Young <sean@mess.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Jerome Brunet <jbrunet@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-media@vger.kernel.org, linux-amlogic@lists.infradead.org,
	devicetree@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: media: Add compatible for Meson-S4 IR Controller
Date: Tue, 22 Aug 2023 19:11:22 +0800	[thread overview]
Message-ID: <9dc78ceb-3852-e5e8-0b8e-b95f9bec4557@amlogic.com> (raw)
In-Reply-To: <80fe197a-3f15-d1b8-ed99-adeb4a8c24d2@linaro.org>


在 2023/3/2 17:24, Neil Armstrong 写道:
> On 02/03/2023 07:34, zelong dong wrote:
>> From: Zelong Dong <zelong.dong@amlogic.com>
>>
>> Add new compatible for Amlogic's Meson-S4 IR Controller
>>
>> Signed-off-by: Zelong Dong <zelong.dong@amlogic.com>
>> ---
>>   Documentation/devicetree/bindings/media/meson-ir.txt | 3 +++
>>   1 file changed, 3 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/media/meson-ir.txt 
>> b/Documentation/devicetree/bindings/media/meson-ir.txt
>> index efd9d29a8f10..2a6662edd04d 100644
>> --- a/Documentation/devicetree/bindings/media/meson-ir.txt
>> +++ b/Documentation/devicetree/bindings/media/meson-ir.txt
>> @@ -5,11 +5,14 @@ Required properties:
>>             - "amlogic,meson6-ir"
>>             - "amlogic,meson8b-ir"
>>             - "amlogic,meson-gxbb-ir"
>> +          - "amlogic,meson-s4-ir"
>>    - reg        : physical base address and length of the device 
>> registers
>>    - interrupts    : a single specifier for the interrupt from the device
>>   Optional properties:
>>    - linux,rc-map-name:    see rc.txt file in the same directory.
>> + - amlogic,ir-support-hw-decode: enable hardware IR Decoder, and 
>> register
>> +                 rc driver as type RC_DRIVER_SCANCODE
> 
> AFAIK this is a software parameter since the HW is capable of decoding,
> if you want to make the HW decoding a runtime option, please use another 
> way.

Part 1 patch for HW IR Decoder was queued, now I'm preparing part 2.
I add a new property "amlogic,ir-support-hw-decode" because I think rc 
driver don't support change the driver type (enum rc_driver_type) 
dynamically, it need to declare the type in DTS.
Am I right?
> 
>>   Example:
> 
> Please base changes on top of 
> https://lore.kernel.org/all/20221117-b4-amlogic-bindings-convert-v3-4-e28dd31e3bed@linaro.org/
> 
> Thanks,
> Neil
> 

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic