From: Krzysztof Kozlowski <krzk@kernel.org>
To: zelong dong <zelong.dong@amlogic.com>,
Neil Armstrong <neil.armstrong@linaro.org>,
Sean Young <sean@mess.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Jerome Brunet <jbrunet@baylibre.com>,
Kevin Hilman <khilman@baylibre.com>,
Martin Blumenstingl <martin.blumenstingl@googlemail.com>
Cc: linux-media@vger.kernel.org, linux-amlogic@lists.infradead.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 2/3] dt-bindings: media: Add compatible for Meson-S4 IR Controller
Date: Thu, 2 Mar 2023 09:56:21 +0100 [thread overview]
Message-ID: <ad325c16-b0ae-0bb8-407c-f37cc3f070e7@kernel.org> (raw)
In-Reply-To: <20230302063402.42708-3-zelong.dong@amlogic.com>
On 02/03/2023 07:34, zelong dong wrote:
> From: Zelong Dong <zelong.dong@amlogic.com>
>
> Add new compatible for Amlogic's Meson-S4 IR Controller
You do more than written here... Also, add full stop to the commit msg.
>
> Signed-off-by: Zelong Dong <zelong.dong@amlogic.com>
> ---
> Documentation/devicetree/bindings/media/meson-ir.txt | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/media/meson-ir.txt b/Documentation/devicetree/bindings/media/meson-ir.txt
> index efd9d29a8f10..2a6662edd04d 100644
> --- a/Documentation/devicetree/bindings/media/meson-ir.txt
> +++ b/Documentation/devicetree/bindings/media/meson-ir.txt
> @@ -5,11 +5,14 @@ Required properties:
> - "amlogic,meson6-ir"
> - "amlogic,meson8b-ir"
> - "amlogic,meson-gxbb-ir"
> + - "amlogic,meson-s4-ir"
> - reg : physical base address and length of the device registers
> - interrupts : a single specifier for the interrupt from the device
>
> Optional properties:
> - linux,rc-map-name: see rc.txt file in the same directory.
> + - amlogic,ir-support-hw-decode: enable hardware IR Decoder, and register
> + rc driver as type RC_DRIVER_SCANCODE
Please convert the file to DT schema (YAML) first, before adding new
properties. New compatible would be fine, but not new properties.
Best regards,
Krzysztof
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2023-03-02 8:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-02 6:33 [PATCH 0/3] media: rc: meson-s4: support RC_DRIVER_SCANCODE driver zelong dong
2023-03-02 6:34 ` [PATCH 1/3] media: rc: meson-ir: support rc driver type RC_DRIVER_SCANCODE zelong dong
2023-03-02 9:27 ` Neil Armstrong
2023-03-03 13:37 ` Dmitry Rokosov
2023-03-02 6:34 ` [PATCH 2/3] dt-bindings: media: Add compatible for Meson-S4 IR Controller zelong dong
2023-03-02 8:56 ` Krzysztof Kozlowski [this message]
2023-03-02 9:24 ` Neil Armstrong
2023-08-22 11:11 ` Zelong Dong
2023-08-22 13:25 ` neil.armstrong
2023-03-03 13:20 ` Dmitry Rokosov
2023-03-02 6:34 ` [PATCH 3/3] arm64: dts: meson: add IR controller for Meson-S4 SoC zelong dong
2023-03-02 8:56 ` Krzysztof Kozlowski
2023-03-02 9:28 ` Neil Armstrong
2023-03-03 13:18 ` Dmitry Rokosov
2023-08-25 11:53 [PATCH 0/3] This patchset adds IR controller driver support for zelong dong
2023-08-25 11:53 ` [PATCH 2/3] dt-bindings: media: Add compatible for Meson-S4 IR Controller zelong dong
2023-08-25 12:03 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ad325c16-b0ae-0bb8-407c-f37cc3f070e7@kernel.org \
--to=krzk@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=jbrunet@baylibre.com \
--cc=khilman@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=linux-media@vger.kernel.org \
--cc=martin.blumenstingl@googlemail.com \
--cc=mchehab@kernel.org \
--cc=neil.armstrong@linaro.org \
--cc=robh+dt@kernel.org \
--cc=sean@mess.org \
--cc=zelong.dong@amlogic.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®