mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
From: Martin Blumenstingl <martin.blumenstingl@googlemail.com>
To: Ulf Hansson <ulf.hansson@linaro.org>
Cc: linux-amlogic@lists.infradead.org, linux-mmc@vger.kernel.org,
	 Brian Norris <briannorris@chromium.org>,
	Shawn Lin <shawn.lin@rock-chips.com>,
	 Luca Weiss <luca@z3ntu.xyz>
Subject: Re: Odroid-C1 regression with commit 4bc31edebde5 ("mmc: core: Set HS clock speed before sending HS CMD13")
Date: Tue, 16 May 2023 22:45:13 +0200	[thread overview]
Message-ID: <CAFBinCDSv_vdu5887vveotvaOGFrZvaSX4jM+7Q3QvDhTdazzw@mail.gmail.com> (raw)
In-Reply-To: <CAPDyKFr+hQo+N31r=3f58taf9sYW0UF0ApCJhwz9vRsyNizcvg@mail.gmail.com>

On Mon, May 15, 2023 at 11:44 AM Ulf Hansson <ulf.hansson@linaro.org> wrote:
[...]
> > > 3) If 2) seems to work above, we need to figure out why
> > > mmc_switch_status() is hanging. If there is a problem with the eMMC
> > > card responding in-correctly, the host driver should return with an
> > > error code, right?
> > You're right: it's indeed hanging in mmc_switch_status()
> > I don't get any interrupts (timeout, CRC error, ...) for it.
> > Do you have any suggestions what to check next?
>
> So the mmc_switch_status() is sending a CMD13. Even if the card
> doesn't reply, I would expect that the meson mmc controller would
> raise some kind of error condition, probably via a timeout-irq.
>
> Did you verify that the driver is actually waiting for an IRQ to
> happen, which also means waiting for a CMD13 response?
register 0x24 is ICTL (interrupt control) and 0x28 is ISTAT (interrupt status)
ISTAT is all zeros and ICTL is 0x3067 which translates so:
- BIT(0): RESP_OK
- BIT(1): RESP_TIMEOUT
- BIT(2): RESP_ERR_CRC
- BIT(5): DATA_TIMEOUT
- BIT(6): DATA_ERR_CRC
- BIT(12): RXFIFO_FULL
- BIT(13): TXFIFO_EMPTY

I guess in this case BIT(1) RESP_TIMEOUT is the relevant one.

register 0x04 is SEND and reads 0x4d which translates to:
- CMD13
- MMC_RSP_PRESENT (HAS_RESP, BIT(6))
- no other flags (STOP, R1B, ...) are set

Full register dump:
# cat /sys/kernel/debug/regmap/c1108e00.mmc/registers
00: 00000900
04: 0000004d
08: e7ffe002
0c: 02f0003f
10: 0003f009
14: 03b81c00
18: 2c43bcf0
1c: e0000150
20: 00000000
24: 00003067
28: 00000000
2c: 00000000
30: 00000000
34: 00fe0cff
38: 0000100b

In case you are curious, the driver is: drivers/mmc/host/meson-mx-sdhc-mmc.c


Best regards,
Martin

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

  reply	other threads:[~2023-05-16 20:45 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-04-10 23:13 Martin Blumenstingl
2023-04-13 14:00 ` Linux regression tracking (Thorsten Leemhuis)
2023-05-08 20:12 ` Martin Blumenstingl
2023-05-10 14:20 ` Ulf Hansson
2023-05-10 20:54   ` Martin Blumenstingl
2023-05-11 10:42     ` Ulf Hansson
2023-05-14 20:42       ` Martin Blumenstingl
2023-05-15  9:43         ` Ulf Hansson
2023-05-16 20:45           ` Martin Blumenstingl [this message]
2023-06-02 13:17             ` Linux regression tracking (Thorsten Leemhuis)
2023-06-05 21:01               ` Martin Blumenstingl
2023-06-14 15:49             ` Ulf Hansson
2023-06-19 19:54               ` Martin Blumenstingl
2023-06-20  9:53                 ` Ulf Hansson
2023-08-29  9:59                   ` Linux regression tracking (Thorsten Leemhuis)
2023-09-11  8:48                     ` Thorsten Leemhuis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAFBinCDSv_vdu5887vveotvaOGFrZvaSX4jM+7Q3QvDhTdazzw@mail.gmail.com \
    --to=martin.blumenstingl@googlemail.com \
    --cc=briannorris@chromium.org \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-mmc@vger.kernel.org \
    --cc=luca@z3ntu.xyz \
    --cc=shawn.lin@rock-chips.com \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®