From: Neil Armstrong <narmstrong@baylibre.com>
To: Anatolij Gustschin <agust@denx.de>
Cc: mjourdan@baylibre.com, u-boot@lists.denx.de,
linux-amlogic@lists.infradead.org,
Jorge Ramire-Ortiz <jramirez@baylibre.com>,
jbrunet@baylibre.com
Subject: Re: [PATCH u-boot 04/11] video: Add Meson Video Processing Unit Driver
Date: Tue, 29 Jan 2019 09:26:58 +0100 [thread overview]
Message-ID: <bcbb5e37-d57b-47b5-4f24-58dad577c919@baylibre.com> (raw)
In-Reply-To: <20190128205611.46598f8a@crub>
Hi Anatolij,
On 28/01/2019 20:56, Anatolij Gustschin wrote:
> On Tue, 15 Jan 2019 17:17:52 +0100
> Neil Armstrong narmstrong@baylibre.com wrote:
>
>> This adds video output support for Amlogic GXBB/GXL/GXM chips.
>> The supported ports are CVBS and HDMI (based on DW_HDMI).
>>
>> When using HDMI, only DMT modes are supported.
>>
>> There is support for simple-framebuffer (CONFIG_VIDEO_DT_SIMPLEFB)
>>
>> Signed-off-by: Neil Armstrong <narmstrong@baylibre.com>
>> Signed-off-by: Jorge Ramire-Ortiz <jramirez@baylibre.com>
>> Signed-off-by: Maxime Jourdan <mjourdan@baylibre.com>
>
> Reviewed-by: Anatolij Gustschin <agust@denx.de>
>
> Please see minor comment below.
>
>> diff --git a/drivers/video/meson/meson_canvas.c b/drivers/video/meson/meson_canvas.c
> ...
>> +/* DMC Registers */
>> +#define DMC_CAV_LUT_DATAL 0x48 /* 0x12 offset in data sheet */
>> +#define CANVAS_WIDTH_LBIT 29
>> +#define CANVAS_WIDTH_LWID 3
>> +#define DMC_CAV_LUT_DATAH 0x4c /* 0x13 offset in data sheet */
>> +#define CANVAS_WIDTH_HBIT 0
>> +#define CANVAS_HEIGHT_BIT 9
>> +#define CANVAS_BLKMODE_BIT 24
>> +#define DMC_CAV_LUT_ADDR 0x50 /* 0x14 offset in data sheet */
>> +#define CANVAS_LUT_WR_EN (0x2 << 8)
>> +#define CANVAS_LUT_RD_EN (0x1 << 8)
>
> Some define values are not aligned by tab here.
Thanks for reviewing,
I'll fix it.
Do you mind if I push this serie via the amlogic custodian ?
Tom is it ok for you ?
Neil
>
> --
> Anatolij
>
_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic
next prev parent reply other threads:[~2019-01-29 8:27 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-15 16:17 [PATCH u-boot 00/11] meson: add support for Video Output Neil Armstrong
2019-01-15 16:17 ` [PATCH u-boot 01/11] power: domain: meson-gx-pwrc-vpu: add missing depends Neil Armstrong
2019-01-28 19:58 ` Anatolij Gustschin
2019-01-15 16:17 ` [PATCH u-boot 02/11] video: dw_hdmi: support SoC specific read/write ops Neil Armstrong
2019-01-28 16:00 ` Anatolij Gustschin
2019-01-15 16:17 ` [PATCH u-boot 03/11] video: dw_hdmi: add support for color conversion Neil Armstrong
2019-01-28 16:01 ` Anatolij Gustschin
2019-01-15 16:17 ` [PATCH u-boot 04/11] video: Add Meson Video Processing Unit Driver Neil Armstrong
2019-01-28 19:56 ` Anatolij Gustschin
2019-01-29 8:26 ` Neil Armstrong [this message]
2019-01-29 10:28 ` Anatolij Gustschin
2019-01-15 16:17 ` [PATCH u-boot 05/11] arm64: dts: meson-gx: vpu should be probed before relocation Neil Armstrong
2019-01-15 16:17 ` [PATCH u-boot 06/11] arm64: dts: meson-gx: Add hdmi_5v regulator as hdmi tx supply Neil Armstrong
2019-01-15 16:17 ` [PATCH u-boot 07/11] arm64: dts: meson-gx: add hhi reg entry to hdmi_tx Neil Armstrong
2019-01-15 16:17 ` [PATCH u-boot 08/11] arm: meson: board-gx: Setup VPU in fdt Neil Armstrong
2019-01-28 20:07 ` Anatolij Gustschin
2019-01-15 16:17 ` [PATCH u-boot 09/11] configs: meson64: use vidconsole and usbkbd if enabled Neil Armstrong
2019-01-28 20:09 ` Anatolij Gustschin
2019-01-15 16:17 ` [PATCH u-boot 10/11] arm: meson64: enable console mux and console env by default Neil Armstrong
2019-01-28 20:11 ` Anatolij Gustschin
2019-01-15 16:17 ` [PATCH u-boot 11/11] arm: libretech-cc: enable video " Neil Armstrong
2019-01-28 20:12 ` Anatolij Gustschin
2019-01-28 9:10 ` [PATCH u-boot 00/11] meson: add support for Video Output Neil Armstrong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bcbb5e37-d57b-47b5-4f24-58dad577c919@baylibre.com \
--to=narmstrong@baylibre.com \
--cc=agust@denx.de \
--cc=jbrunet@baylibre.com \
--cc=jramirez@baylibre.com \
--cc=linux-amlogic@lists.infradead.org \
--cc=mjourdan@baylibre.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®