mirror of https://lore.kernel.org/linux-amlogic/
 help / color / mirror / Atom feed
* Re: [PATCH] dt-bindings: arm: amlogic: add S4 based AQ222 bindings
       [not found] <20211208093347.4837-1-xianwei.zhao@amlogic.com>
@ 2021-12-09 13:55 ` Neil Armstrong
  2021-12-09 13:58   ` Neil Armstrong
  0 siblings, 1 reply; 3+ messages in thread
From: Neil Armstrong @ 2021-12-09 13:55 UTC (permalink / raw)
  To: xianwei.zhao, devicetree, linux-kernel
  Cc: Rob Herring, Christian Hewitt, Kevin Hilman, Vyacheslav Bocharov,
	Martin Blumenstingl, open list:ARM/Amlogic Meson...,
	linux-arm-kernel

+cc linux-amlogic@lists.infradead.org linux-arm-kernel@lists.infradead.org

On 08/12/2021 10:33, xianwei.zhao wrote:
> Add bindings for the new Amlogic S4 SoC family,
> and the compatible for the Amlogic S4 Based AQ222 board.
> 
> S4 is an application processor designed for hybrid OTT/IP Set To
> Box(STB) and high-end media box applications, with quad core Cortex-A35.
> 
> Signed-off-by: xianwei.zhao <xianwei.zhao@amlogic.com>
> ---
>  Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
> index 36081734f720..63037ebdd7bf 100644
> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
> @@ -183,6 +183,12 @@ properties:
>                - amlogic,ad401
>            - const: amlogic,a1
>  
> +      - description: Boards with the Amlogic Meson S4 AQ222 SoC
> +        items:
> +          - enum:
> +              - amlogic,aq222
> +          - const: amlogic,s4
> +
>  additionalProperties: true
>  
>  ...
> 
> base-commit: a3ebdcc8fb3d94de390e58ad3da6161826a58a87
> 


_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: arm: amlogic: add S4 based AQ222 bindings
  2021-12-09 13:55 ` [PATCH] dt-bindings: arm: amlogic: add S4 based AQ222 bindings Neil Armstrong
@ 2021-12-09 13:58   ` Neil Armstrong
  2021-12-10  6:28     ` xianwei.zhao
  0 siblings, 1 reply; 3+ messages in thread
From: Neil Armstrong @ 2021-12-09 13:58 UTC (permalink / raw)
  To: xianwei.zhao, devicetree, linux-kernel
  Cc: Rob Herring, Christian Hewitt, Kevin Hilman, Vyacheslav Bocharov,
	Martin Blumenstingl, open list:ARM/Amlogic Meson...,
	linux-arm-kernel

On 09/12/2021 14:55, Neil Armstrong wrote:
> +cc linux-amlogic@lists.infradead.org linux-arm-kernel@lists.infradead.org
> 
> On 08/12/2021 10:33, xianwei.zhao wrote:
>> Add bindings for the new Amlogic S4 SoC family,
>> and the compatible for the Amlogic S4 Based AQ222 board.

What's the SoC commercial name ? s805x2 ? and the board model ? AQ222 and the family ? S4 ?

>>
>> S4 is an application processor designed for hybrid OTT/IP Set To
>> Box(STB) and high-end media box applications, with quad core Cortex-A35.
>>
>> Signed-off-by: xianwei.zhao <xianwei.zhao@amlogic.com>
>> ---
>>  Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
>> index 36081734f720..63037ebdd7bf 100644
>> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
>> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
>> @@ -183,6 +183,12 @@ properties:
>>                - amlogic,ad401
>>            - const: amlogic,a1
>>  
>> +      - description: Boards with the Amlogic Meson S4 AQ222 SoC

So it should be:
      - description: Boards with the Amlogic Meson S4 S805X2 SoC

>> +        items:
>> +          - enum:
>> +              - amlogic,aq222
>> +          - const: amlogic,s4
>> +
>>  additionalProperties: true
>>  
>>  ...
>>
>> base-commit: a3ebdcc8fb3d94de390e58ad3da6161826a58a87
>>
> 

Neil

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 3+ messages in thread
* Re: [PATCH] dt-bindings: arm: amlogic: add S4 based AQ222 bindings
  2021-12-09 13:58   ` Neil Armstrong
@ 2021-12-10  6:28     ` xianwei.zhao
  0 siblings, 0 replies; 3+ messages in thread
From: xianwei.zhao @ 2021-12-10  6:28 UTC (permalink / raw)
  To: Neil Armstrong, devicetree, linux-kernel
  Cc: Rob Herring, Christian Hewitt, Kevin Hilman, Vyacheslav Bocharov,
	Martin Blumenstingl, open list:ARM/Amlogic Meson...,
	linux-arm-kernel

Hi Neil,




  I will modify the line and update the patch later.




Thanks!




Best regards,




xianwei.zhao



On 2021/12/9 下午9:58, Neil Armstrong wrote:
> 
> On 09/12/2021 14:55, Neil Armstrong wrote:
>> +cc linux-amlogic@lists.infradead.org linux-arm-kernel@lists.infradead.org
>>
>> On 08/12/2021 10:33, xianwei.zhao wrote:
>>> Add bindings for the new Amlogic S4 SoC family,
>>> and the compatible for the Amlogic S4 Based AQ222 board.
> 
> What's the SoC commercial name ? s805x2 ? and the board model ? AQ222 and the family ? S4 ?
> 
>>>
>>> S4 is an application processor designed for hybrid OTT/IP Set To
>>> Box(STB) and high-end media box applications, with quad core Cortex-A35.
>>>
>>> Signed-off-by: xianwei.zhao <xianwei.zhao@amlogic.com>
>>> ---
>>>   Documentation/devicetree/bindings/arm/amlogic.yaml | 6 ++++++
>>>   1 file changed, 6 insertions(+)
>>>
>>> diff --git a/Documentation/devicetree/bindings/arm/amlogic.yaml b/Documentation/devicetree/bindings/arm/amlogic.yaml
>>> index 36081734f720..63037ebdd7bf 100644
>>> --- a/Documentation/devicetree/bindings/arm/amlogic.yaml
>>> +++ b/Documentation/devicetree/bindings/arm/amlogic.yaml
>>> @@ -183,6 +183,12 @@ properties:
>>>                 - amlogic,ad401
>>>             - const: amlogic,a1
>>>   
>>> +      - description: Boards with the Amlogic Meson S4 AQ222 SoC
> 
> So it should be:
>        - description: Boards with the Amlogic Meson S4 S805X2 SoC
> 
>>> +        items:
>>> +          - enum:
>>> +              - amlogic,aq222
>>> +          - const: amlogic,s4
>>> +
>>>   additionalProperties: true
>>>   
>>>   ...
>>>
>>> base-commit: a3ebdcc8fb3d94de390e58ad3da6161826a58a87
>>>
>>
> 
> Neil
> 
> .
> 

_______________________________________________
linux-amlogic mailing list
linux-amlogic@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-amlogic

^ permalink raw reply	[flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-12-10  6:28 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
     [not found] <20211208093347.4837-1-xianwei.zhao@amlogic.com>
2021-12-09 13:55 ` [PATCH] dt-bindings: arm: amlogic: add S4 based AQ222 bindings Neil Armstrong
2021-12-09 13:58   ` Neil Armstrong
2021-12-10  6:28     ` xianwei.zhao

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®